From: Greg KH <gregkh@linuxfoundation.org>
To: peng.hao2@zte.com.cn
Cc: arnd@arndb.de, andy.shevchenko@gmail.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH V4 1/3] misc/pvpanic: return 0 for empty body registerfunction
Date: Wed, 19 Dec 2018 07:56:21 +0100 [thread overview]
Message-ID: <20181219065621.GA21256@kroah.com> (raw)
In-Reply-To: <201812190811376451432@zte.com.cn>
On Wed, Dec 19, 2018 at 08:11:37AM +0800, peng.hao2@zte.com.cn wrote:
> >On Tue, Dec 18, 2018 at 05:46:41PM +0800, Peng Hao wrote:
> >> Return 0 for empty body register function normally.
> >>
> >> Signed-off-by: Peng Hao <peng.hao2@zte.com.cn>
> >> ---
> >> QEMU community requires additional PCI devices to simulate PVPANIC devices
> >> so that some architectures can not occupy precious less than 4G of memory
> >> space.
> >
> >What is this for below the --- line?
> >
> >And again, you did not specify what changed from the previous versions.
> >I can not take these unless you provide it.
>
> The previous version of the code is basically unchanged, and the new patches just
> adds a PCI interface. Previous versions only support ACPI and FDT interfaces.
> The QEMU community requires a PCI interface so that some architectures do not occupy
> precious low 4G memory address.
No, you are changing things between each version, hopefully based on the
review comments. And the testing that is being provided for you showing
you where your code breaks the build.
That goes in the "what changed" lines, as is documented in the kernel
documentation. Please follow that when resubmitting if you wish for
your changes to be able to be accepted.
thanks,
greg k-h
prev parent reply other threads:[~2018-12-19 6:56 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-18 9:46 [PATCH V4 1/3] misc/pvpanic: return 0 for empty body register function Peng Hao
2018-12-18 9:46 ` [PATCH V4 2/3] misc/pvpanic : add pci interface for pvpanic Peng Hao
2018-12-18 13:31 ` kbuild test robot
2018-12-18 13:38 ` kbuild test robot
2018-12-18 9:46 ` [PATCH V4 3/3] misc/pvpanic : add pci dependency in Kconfig Peng Hao
2018-12-18 10:28 ` [PATCH V4 1/3] misc/pvpanic: return 0 for empty body register function Greg KH
[not found] ` <201812190811376451432@zte.com.cn>
2018-12-19 6:56 ` Greg KH [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181219065621.GA21256@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=andy.shevchenko@gmail.com \
--cc=arnd@arndb.de \
--cc=linux-kernel@vger.kernel.org \
--cc=peng.hao2@zte.com.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.