All of lore.kernel.org
 help / color / mirror / Atom feed
From: Charles Keepax <ckeepax@opensource.cirrus.com>
To: Paul Gortmaker <paul.gortmaker@windriver.com>
Cc: Lee Jones <lee.jones@linaro.org>, <linux-kernel@vger.kernel.org>,
	Linus Walleij <linus.walleij@linaro.org>,
	<patches@opensource.cirrus.com>
Subject: Re: [PATCH 17/18] mfd: wm8350-core: drop unused module infrastructure from non-modular code
Date: Wed, 19 Dec 2018 09:15:10 +0000	[thread overview]
Message-ID: <20181219091510.GZ16508@imbe.wolfsonmicro.main> (raw)
In-Reply-To: <1545078688-21217-18-git-send-email-paul.gortmaker@windriver.com>

On Mon, Dec 17, 2018 at 03:31:27PM -0500, Paul Gortmaker wrote:
> The Kconfig currently controlling compilation of this code is:
> 
> drivers/mfd/Kconfig:config MFD_WM8350
> drivers/mfd/Kconfig:    bool
> 
> ...meaning that it currently is not being built as a module by anyone.
> 
> Lets remove the couple traces of modular infrastructure use, so that
> when reading the driver there is no doubt it is builtin-only.
> 
> We delete the MODULE_LICENSE tag etc. since all that information
> is already contained at the top of the file in the comments.
> 
> We replace module.h with init.h and export.h ; the latter since the
> file does export some symbols.
> 
> Previous demodularizaion work has made wm8350_device_exit() no longer
> used, so it is also removed from the 8350 core code.
> 
> Cc: Linus Walleij <linus.walleij@linaro.org>
> Cc: Charles Keepax <ckeepax@opensource.cirrus.com>
> Cc: Lee Jones <lee.jones@linaro.org>
> Cc: patches@opensource.cirrus.com
> Signed-off-by: Paul Gortmaker <paul.gortmaker@windriver.com>
> ---

Acked-by: Charles Keepax <ckeepax@opensource.cirrus.com>

Thanks,
Charles

  reply	other threads:[~2018-12-19  9:15 UTC|newest]

Thread overview: 37+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-12-17 20:31 [PATCH v4 00/18] mfd: demodularization of non-modular drivers Paul Gortmaker
2018-12-17 20:31 ` Paul Gortmaker
2018-12-17 20:31 ` [PATCH 01/18] mfd: aat2870-core: Make it explicitly non-modular Paul Gortmaker
2018-12-18  6:21   ` jinyoungp
2018-12-17 20:31 ` [PATCH 02/18] mfd: adp5520: " Paul Gortmaker
2018-12-18  7:43   ` Hennerich, Michael
2018-12-17 20:31 ` [PATCH 03/18] mfd: as3711: " Paul Gortmaker
2018-12-17 20:31 ` [PATCH 04/18] mfd: db8500-prcmu: drop unused MODULE_ tags from non-modular code Paul Gortmaker
2018-12-17 20:31 ` [PATCH 05/18] mfd: htc-i2cpld: Make it explicitly non-modular Paul Gortmaker
2018-12-17 20:31 ` [PATCH 06/18] mfd: max8925-core: drop unused MODULE_ tags from non-modular code Paul Gortmaker
2018-12-17 20:31 ` [PATCH 07/18] mfd: rc5t583: Make it explicitly non-modular Paul Gortmaker
2018-12-18 10:04   ` Laxman Dewangan
2018-12-17 20:31 ` [PATCH 08/18] mfd: sta2x11: drop unused MODULE_ tags from non-modular code Paul Gortmaker
2018-12-17 20:31 ` [PATCH 09/18] mfd: syscon: Make it explicitly non-modular Paul Gortmaker
2018-12-17 20:31 ` [PATCH 10/18] mfd: tps65090: " Paul Gortmaker
2018-12-17 20:31 ` [PATCH 11/18] mfd: tps65910: " Paul Gortmaker
2018-12-17 20:31   ` Paul Gortmaker
2018-12-23 16:35   ` Tony Lindgren
2018-12-17 20:31 ` [PATCH 12/18] mfd: tps80031: " Paul Gortmaker
2018-12-18 10:07   ` Laxman Dewangan
2018-12-17 20:31 ` [PATCH 13/18] mfd: wm831x-spi: " Paul Gortmaker
2018-12-19  9:14   ` Charles Keepax
2018-12-17 20:31 ` [PATCH 14/18] mfd: wm831x-i2c: " Paul Gortmaker
2018-12-19  9:14   ` Charles Keepax
2018-12-17 20:31 ` [PATCH 15/18] mfd: wm831x-core: drop unused module infrastructure from non-modular code Paul Gortmaker
2018-12-19  9:14   ` Charles Keepax
2018-12-17 20:31 ` [PATCH 16/18] mfd: wm8350-i2c: Make it explicitly non-modular Paul Gortmaker
2018-12-19  9:14   ` Charles Keepax
2018-12-17 20:31 ` [PATCH 17/18] mfd: wm8350-core: drop unused module infrastructure from non-modular code Paul Gortmaker
2018-12-19  9:15   ` Charles Keepax [this message]
2018-12-17 20:31 ` [PATCH 18/18] mfd: wm8400-core: Make it explicitly non-modular Paul Gortmaker
2018-12-19  9:17   ` Charles Keepax
2018-12-21 15:55     ` Paul Gortmaker
2018-12-28  9:42       ` Charles Keepax
2018-12-19  8:03 ` [PATCH v4 00/18] mfd: demodularization of non-modular drivers Lee Jones
2018-12-19  8:03   ` Lee Jones
  -- strict thread matches above, loose matches on Subject: below --
2019-01-13 18:36 [PATCH v5 " Paul Gortmaker
2019-01-13 18:36 ` [PATCH 17/18] mfd: wm8350-core: drop unused module infrastructure from non-modular code Paul Gortmaker

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20181219091510.GZ16508@imbe.wolfsonmicro.main \
    --to=ckeepax@opensource.cirrus.com \
    --cc=lee.jones@linaro.org \
    --cc=linus.walleij@linaro.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=patches@opensource.cirrus.com \
    --cc=paul.gortmaker@windriver.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.