All of lore.kernel.org
 help / color / mirror / Atom feed
From: Andrew Lunn <andrew@lunn.ch>
To: Guenter Roeck <linux@roeck-us.net>
Cc: wim@linux-watchdog.org, linux-watchdog@vger.kernel.org
Subject: Re: [PATCH v3] watchdog: tqmx86: Add watchdog driver for the IO controller
Date: Wed, 19 Dec 2018 10:25:29 +0100	[thread overview]
Message-ID: <20181219092529.GD14923@lunn.ch> (raw)
In-Reply-To: <20181218234226.GA6713@roeck-us.net>

On Tue, Dec 18, 2018 at 03:42:26PM -0800, Guenter Roeck wrote:
> On Tue, Dec 18, 2018 at 05:34:41PM +0100, Andrew Lunn wrote:
> > Some TQ-Systems ComExpress modules have an IO controller with a
> > watchdog timer.
> > 
> > Signed-off-by: Andrew Lunn <andrew@lunn.ch>
> 
> Reviewed-by: Guenter Roeck <linux@roeck-us.net>
> 
> Nitpicks:
> - SPDX license and MODULE_LICENSE mismatch
>   Maybe GPLv2 for both ?
> - Signed-off-by: and MODULE_AUTHOR mismatch
>   Given the changes you have made, it might make sense
>   to mention "Based on out-of-tree driver from ..."
>   in the header and make yourself the module author.
>   Just a thought.
> 
> Not sure if this warrants a resubmit. Your call.

Hi Guenter

I will probably respin, to fix the license at least. I've got a few
similar issues in the Ethernet PHY subsystem i'm wondering what to do
with, i don't really want to add another...

Thanks
	Andrew

  reply	other threads:[~2018-12-19  9:25 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-12-18 23:42 [PATCH v3] watchdog: tqmx86: Add watchdog driver for the IO controller Guenter Roeck
2018-12-19  9:25 ` Andrew Lunn [this message]
  -- strict thread matches above, loose matches on Subject: below --
2018-12-18 16:34 Andrew Lunn

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20181219092529.GD14923@lunn.ch \
    --to=andrew@lunn.ch \
    --cc=linux-watchdog@vger.kernel.org \
    --cc=linux@roeck-us.net \
    --cc=wim@linux-watchdog.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.