All of lore.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: Buland Singh <bsingh@redhat.com>
Cc: clemens@ladisch.de, arnd@arndb.de, linux-kernel@vger.kernel.org,
	trivial@kernel.org, prarit@redhat.com
Subject: Re: [PATCH] hpet: Fix missing '=' character in the __setup() code of hpet_mmap_enable.
Date: Wed, 19 Dec 2018 10:46:27 +0100	[thread overview]
Message-ID: <20181219094627.GC11441@kroah.com> (raw)
In-Reply-To: <20181219092502.3079-1-bsingh@redhat.com>

On Wed, Dec 19, 2018 at 02:55:02PM +0530, Buland Singh wrote:
> The kernel command parameter 'hpet_mmap' never takes effect due to missing
> '=' character in the __setup() code of hpet_mmap_enable and the memory map
> of the HPET registers never get expose to userspace.
> 
> Signed-off-by: Buland Singh <bsingh@redhat.com>
> ---
>  drivers/char/hpet.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/char/hpet.c b/drivers/char/hpet.c
> index 4a22b4b41aef..9bffcd37cc7b 100644
> --- a/drivers/char/hpet.c
> +++ b/drivers/char/hpet.c
> @@ -377,7 +377,7 @@ static __init int hpet_mmap_enable(char *str)
>  	pr_info("HPET mmap %s\n", hpet_mmap_enabled ? "enabled" : "disabled");
>  	return 1;
>  }
> -__setup("hpet_mmap", hpet_mmap_enable);
> +__setup("hpet_mmap=", hpet_mmap_enable);

What commit caused this bug?  Should this go to the stable kernel trees?

thanks,

greg k-h

  reply	other threads:[~2018-12-19  9:46 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-12-19  9:25 [PATCH] hpet: Fix missing '=' character in the __setup() code of hpet_mmap_enable Buland Singh
2018-12-19  9:46 ` Greg KH [this message]
2018-12-19 12:04   ` Buland Singh
2018-12-19 12:37     ` Greg KH
2018-12-20  6:37       ` Buland Singh

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20181219094627.GC11441@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=arnd@arndb.de \
    --cc=bsingh@redhat.com \
    --cc=clemens@ladisch.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=prarit@redhat.com \
    --cc=trivial@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.