All of lore.kernel.org
 help / color / mirror / Atom feed
From: Niklas Cassel <niklas.cassel@linaro.org>
To: David Miller <davem@redhat.com>
Cc: Jose.Abreu@synopsys.com, netdev@vger.kernel.org,
	f.fainelli@gmail.com, narmstrong@baylibre.com,
	jbrunet@baylibre.com, martin.blumenstingl@googlemail.com,
	Joao.Pinto@synopsys.com, peppe.cavallaro@st.com,
	alexandre.torgue@st.com, vinod.koul@linaro.org
Subject: Re: [PATCH net 0/2] net: stmmac: Coalesce and tail addr fixes
Date: Wed, 19 Dec 2018 13:02:45 +0100	[thread overview]
Message-ID: <20181219120245.GA5205@centauri.lan> (raw)
In-Reply-To: <20180918.194846.1887226614778546543.davem@redhat.com>

On Tue, Sep 18, 2018 at 07:48:46PM -0700, David Miller wrote:
> 
> From: Jose Abreu <Jose.Abreu@synopsys.com>
> Date: Mon, 17 Sep 2018 09:22:55 +0100
> 
> > The fix for coalesce timer and a fix in tail address setting that impacts
> > XGMAC2 operation.
> > 
> > The series is:
> > 	Tested-by: Jerome Brunet <jbrunet@baylibre.com>
> > 	on a113 s400 board (single queue)
> 
> Series applied and queued up for -stable.

Hello David, Jose,

While it says that the series was queued up for -stable, only patch 2/2:
0431100b3d82 ("net: stmmac: Fixup the tail addr setting in xmit path")
was queued up for 4.14 stable.

patch 1/2:
8fce33317023 ("net: stmmac: Rework coalesce timer and fix multi-queue races")
is missing in 4.14 stable, even though the fixes tag refers to a commit
that was first included in v4.12.

Patch 1/2 does not apply without conflicts.
However, since this fixes multi-queue races, and appears to fix the irq
coalescing implementation that has been giving us problems in the past:
https://lkml.org/lkml/2016/11/24/571
I suggest that we try to get this backported.
If the conflicts are non-trivial, perhaps Jose can help with the backport
to 4.14 stable?


Kind regards,
Niklas

      reply	other threads:[~2018-12-19 12:02 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-09-17  8:22 [PATCH net 0/2] net: stmmac: Coalesce and tail addr fixes Jose Abreu
2018-09-17  8:22 ` [PATCH net 1/2] net: stmmac: Rework coalesce timer and fix multi-queue races Jose Abreu
2018-09-17  8:22 ` [PATCH net 2/2] net: stmmac: Fixup the tail addr setting in xmit path Jose Abreu
2018-09-19  2:48 ` [PATCH net 0/2] net: stmmac: Coalesce and tail addr fixes David Miller
2018-12-19 12:02   ` Niklas Cassel [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20181219120245.GA5205@centauri.lan \
    --to=niklas.cassel@linaro.org \
    --cc=Joao.Pinto@synopsys.com \
    --cc=Jose.Abreu@synopsys.com \
    --cc=alexandre.torgue@st.com \
    --cc=davem@redhat.com \
    --cc=f.fainelli@gmail.com \
    --cc=jbrunet@baylibre.com \
    --cc=martin.blumenstingl@googlemail.com \
    --cc=narmstrong@baylibre.com \
    --cc=netdev@vger.kernel.org \
    --cc=peppe.cavallaro@st.com \
    --cc=vinod.koul@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.