From mboxrd@z Thu Jan 1 00:00:00 1970 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Subject: [v1,02/12] dt-bindings: phy: Add support for HiSilicon's hi3660 USB PHY From: Rob Herring Message-Id: <20181219141419.GA17302@bogus> Date: Wed, 19 Dec 2018 08:14:19 -0600 To: Yu Chen Cc: linux-usb@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, suzhuangluan@hisilicon.com, kongfei@hisilicon.com, Mark Rutland , John Stultz , Binghui Wang List-ID: T24gTW9uLCBEZWMgMDMsIDIwMTggYXQgMTE6NDU6MDVBTSArMDgwMCwgWXUgQ2hlbiB3cm90ZToK PiBUaGlzIHBhdGNoIGFkZHMgYmluZGluZyBkb2N1bWVudGF0aW9uIGZvciBzdXBwb3J0aW5nIHRo ZSBoaTM2NjAgdXNiCj4gcGh5IG9uIGJvYXJkcyBsaWtlIHRoZSBIaUtleTk2MC4KPiAKPiBDYzog Um9iIEhlcnJpbmcgPHJvYmgrZHRAa2VybmVsLm9yZz4KPiBDYzogTWFyayBSdXRsYW5kIDxtYXJr LnJ1dGxhbmRAYXJtLmNvbT4KPiBDYzogSm9obiBTdHVsdHogPGpvaG4uc3R1bHR6QGxpbmFyby5v cmc+Cj4gQ2M6IEJpbmdodWkgV2FuZyA8d2FuZ2JpbmdodWlAaGlzaWxpY29uLmNvbT4KPiBTaWdu ZWQtb2ZmLWJ5OiBZdSBDaGVuIDxjaGVueXU1NkBodWF3ZWkuY29tPgo+IC0tCj4gdjE6IEZpeCBz b21lIGZvcm1hdCBlcnJvciBhcyBzdWdnZXN0ZWQgYnkgUm9iLgo+IC0tCj4gLS0tCj4gIC4uLi9k ZXZpY2V0cmVlL2JpbmRpbmdzL3BoeS9waHktaGkzNjYwLXVzYjMudHh0ICAgICB8IDIxICsrKysr KysrKysrKysrKysrKysrKwo+ICAxIGZpbGUgY2hhbmdlZCwgMjEgaW5zZXJ0aW9ucygrKQo+ICBj cmVhdGUgbW9kZSAxMDA2NDQgRG9jdW1lbnRhdGlvbi9kZXZpY2V0cmVlL2JpbmRpbmdzL3BoeS9w aHktaGkzNjYwLXVzYjMudHh0Cj4gCj4gZGlmZiAtLWdpdCBhL0RvY3VtZW50YXRpb24vZGV2aWNl dHJlZS9iaW5kaW5ncy9waHkvcGh5LWhpMzY2MC11c2IzLnR4dCBiL0RvY3VtZW50YXRpb24vZGV2 aWNldHJlZS9iaW5kaW5ncy9waHkvcGh5LWhpMzY2MC11c2IzLnR4dAo+IG5ldyBmaWxlIG1vZGUg MTAwNjQ0Cj4gaW5kZXggMDAwMDAwMDAwMDAwLi44ZWE1MmQ1MWFhMTMKPiAtLS0gL2Rldi9udWxs Cj4gKysrIGIvRG9jdW1lbnRhdGlvbi9kZXZpY2V0cmVlL2JpbmRpbmdzL3BoeS9waHktaGkzNjYw LXVzYjMudHh0Cj4gQEAgLTAsMCArMSwyMSBAQAo+ICtIaXNpbGljb24gaGkzNjYwIHVzYiBQSFkK CnMvdXNiL1VTQi8KCj4gKy0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tCj4gKwo+ICtSZXF1aXJlZCBw cm9wZXJ0aWVzOgo+ICstIGNvbXBhdGlibGU6IHNob3VsZCBiZSAiaGlzaWxpY29uLGhpMzY2MC11 c2ItcGh5Igo+ICstICNwaHktY2VsbHM6IG11c3QgYmUgMAo+ICstIGhpc2lsaWNvbixwZXJpY3Jn LXN5c2NvbjogcGhhbmRsZSBvZiBzeXNjb24gdXNlZCB0byBjb250cm9sIHBoeS4KPiArLSBoaXNp bGljb24scGN0cmwtc3lzY29uOiBwaGFuZGxlIG9mIHN5c2NvbiB1c2VkIHRvIGNvbnRyb2wgcGh5 Lgo+ICstIGhpc2lsaWNvbix1c2IzLW90Zy1iYy1zeXNjb246IHBoYW5kbGUgb2Ygc3lzY29uIHVz ZWQgdG8gY29udHJvbCBwaHkuCj4gKy0gaGlzaWxpY29uLGV5ZS1kaWFncmFtLXBhcmFtOiBwYXJh bWV0ZXIgc2V0IGZvciBwaHkKPiArUmVmZXIgdG8gcGh5L3BoeS1iaW5kaW5ncy50eHQgZm9yIHRo ZSBnZW5lcmljIFBIWSBiaW5kaW5nIHByb3BlcnRpZXMKCkRvZXNuJ3QgYSBwaHkgbmVlZCBzb21l IGNsb2Nrcz8KCj4gKwo+ICtFeGFtcGxlOgo+ICsJdXNiLXBoeSB7Cj4gKwkJY29tcGF0aWJsZSA9 ICJoaXNpbGljb24saGkzNjYwLXVzYi1waHkiOwo+ICsJCSNwaHktY2VsbHMgPSA8MD47Cj4gKwkJ aGlzaWxpY29uLHBlcmljcmctc3lzY29uID0gPCZjcmdfY3RybD47Cj4gKwkJaGlzaWxpY29uLHBj dHJsLXN5c2NvbiA9IDwmcGN0cmw+Owo+ICsJCWhpc2lsaWNvbix1c2IzLW90Zy1iYy1zeXNjb24g PSA8JnVzYjNfb3RnX2JjPjsKCklzIG9uZSBvZiB0aGVzZSB0aGUgIm1haW4iIHJlZ2lzdGVycyBm b3IgdGhlIHBoeT8gSWYgc28sIHRoZW4gbWFrZSB0aGlzIAphIGNoaWxkIG9mIHRoYXQgc3lzY29u IG5vZGUuCgo+ICsJCWhpc2lsaWNvbixleWUtZGlhZ3JhbS1wYXJhbSA9IDwweDIyNDY2ZTQ+Owo+ ICsJfTsKPiAtLSAKPiAyLjE1LjAtcmMyCj4K From mboxrd@z Thu Jan 1 00:00:00 1970 From: Rob Herring Subject: Re: [PATCH v1 02/12] dt-bindings: phy: Add support for HiSilicon's hi3660 USB PHY Date: Wed, 19 Dec 2018 08:14:19 -0600 Message-ID: <20181219141419.GA17302@bogus> References: <20181203034515.91412-1-chenyu56@huawei.com> <20181203034515.91412-3-chenyu56@huawei.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <20181203034515.91412-3-chenyu56@huawei.com> Sender: linux-kernel-owner@vger.kernel.org To: Yu Chen Cc: linux-usb@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, suzhuangluan@hisilicon.com, kongfei@hisilicon.com, Mark Rutland , John Stultz , Binghui Wang List-Id: devicetree@vger.kernel.org On Mon, Dec 03, 2018 at 11:45:05AM +0800, Yu Chen wrote: > This patch adds binding documentation for supporting the hi3660 usb > phy on boards like the HiKey960. > > Cc: Rob Herring > Cc: Mark Rutland > Cc: John Stultz > Cc: Binghui Wang > Signed-off-by: Yu Chen > -- > v1: Fix some format error as suggested by Rob. > -- > --- > .../devicetree/bindings/phy/phy-hi3660-usb3.txt | 21 +++++++++++++++++++++ > 1 file changed, 21 insertions(+) > create mode 100644 Documentation/devicetree/bindings/phy/phy-hi3660-usb3.txt > > diff --git a/Documentation/devicetree/bindings/phy/phy-hi3660-usb3.txt b/Documentation/devicetree/bindings/phy/phy-hi3660-usb3.txt > new file mode 100644 > index 000000000000..8ea52d51aa13 > --- /dev/null > +++ b/Documentation/devicetree/bindings/phy/phy-hi3660-usb3.txt > @@ -0,0 +1,21 @@ > +Hisilicon hi3660 usb PHY s/usb/USB/ > +----------------------- > + > +Required properties: > +- compatible: should be "hisilicon,hi3660-usb-phy" > +- #phy-cells: must be 0 > +- hisilicon,pericrg-syscon: phandle of syscon used to control phy. > +- hisilicon,pctrl-syscon: phandle of syscon used to control phy. > +- hisilicon,usb3-otg-bc-syscon: phandle of syscon used to control phy. > +- hisilicon,eye-diagram-param: parameter set for phy > +Refer to phy/phy-bindings.txt for the generic PHY binding properties Doesn't a phy need some clocks? > + > +Example: > + usb-phy { > + compatible = "hisilicon,hi3660-usb-phy"; > + #phy-cells = <0>; > + hisilicon,pericrg-syscon = <&crg_ctrl>; > + hisilicon,pctrl-syscon = <&pctrl>; > + hisilicon,usb3-otg-bc-syscon = <&usb3_otg_bc>; Is one of these the "main" registers for the phy? If so, then make this a child of that syscon node. > + hisilicon,eye-diagram-param = <0x22466e4>; > + }; > -- > 2.15.0-rc2 >