From: "Ville Syrjälä" <ville.syrjala@linux.intel.com>
To: emersion <contact@emersion.fr>
Cc: dri-devel@lists.freedesktop.org
Subject: Re: [PATCH] drm: add missing flags to DRM_MODE_FLAG_ALL
Date: Wed, 19 Dec 2018 16:33:01 +0200 [thread overview]
Message-ID: <20181219143301.GD20097@intel.com> (raw)
In-Reply-To: <JkfnSb7RDcZaOKz0nXtnmG7P1O-pKSpxs2UOikgoPjZ47GlzkKREyzwFz_6SVgqi29vKqrtFnjAWLqNVtACBTnCkuYnvBKVDVkthg9hbhsg=@emersion.fr>
On Wed, Dec 19, 2018 at 01:42:41PM +0000, emersion wrote:
> I guess DRM_MODE_FLAG_PIC_AR_MASK has been overlooked.
Nope. We don't hang on to the aspect ratio flags internally
and they get wiped before we check against DRM_MODE_FLAG_ALL.
Not sure this makes any sense really, but that's how it is atm.
>
> Signed-off-by: Simon Ser <contact@emersion.fr>
> ---
> include/uapi/drm/drm_mode.h | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/include/uapi/drm/drm_mode.h b/include/uapi/drm/drm_mode.h
> index d3e0fe31efc..b8d5226c8e5 100644
> --- a/include/uapi/drm/drm_mode.h
> +++ b/include/uapi/drm/drm_mode.h
> @@ -128,7 +128,8 @@ extern "C" {
> DRM_MODE_FLAG_HSKEW | \
> DRM_MODE_FLAG_DBLCLK | \
> DRM_MODE_FLAG_CLKDIV2 | \
> - DRM_MODE_FLAG_3D_MASK)
> + DRM_MODE_FLAG_3D_MASK | \
> + DRM_MODE_FLAG_PIC_AR_MASK)
>
> /* DPMS flags */
> /* bit compatible with the xorg definitions. */
> --
> 2.20.1
>
>
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel
--
Ville Syrjälä
Intel
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2018-12-19 14:33 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-19 13:42 [PATCH] drm: add missing flags to DRM_MODE_FLAG_ALL emersion
2018-12-19 14:33 ` Ville Syrjälä [this message]
2018-12-19 15:24 ` Daniel Vetter
2018-12-19 15:42 ` Ville Syrjälä
2018-12-19 15:58 ` Daniel Vetter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181219143301.GD20097@intel.com \
--to=ville.syrjala@linux.intel.com \
--cc=contact@emersion.fr \
--cc=dri-devel@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.