From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stephan Gerhold Subject: Re: ASoC: Intel: sst: Missing IRQ at index 5 on BYT-T device Date: Wed, 19 Dec 2018 18:35:02 +0100 Message-ID: <20181219173502.GA44176@gerhold.net> References: <20181217191054.GA10938@gerhold.net> <20181217203242.GB10938@gerhold.net> <20181217204320.GC10938@gerhold.net> <86b92282-5bc1-b8de-93e7-97e7ee17db4b@linux.intel.com> <20181219130747.GA83656@gerhold.net> <20181219150103.GA52375@gerhold.net> <65b445e8-2202-0554-b920-97ce0f7833ce@linux.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mo4-p01-ob.smtp.rzone.de (mo4-p01-ob.smtp.rzone.de [81.169.146.164]) by alsa0.perex.cz (Postfix) with ESMTP id E271E267B14 for ; Wed, 19 Dec 2018 18:35:15 +0100 (CET) Content-Disposition: inline In-Reply-To: <65b445e8-2202-0554-b920-97ce0f7833ce@linux.intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: alsa-devel-bounces@alsa-project.org To: Pierre-Louis Bossart , Antonio Ospite Cc: Liam Girdwood , Hans de Goede , alsa-devel@alsa-project.org, Mark Brown , Jie Yang List-Id: alsa-devel@alsa-project.org On Wed, Dec 19, 2018 at 10:54:55AM -0600, Pierre-Louis Bossart wrote: > > > -static int is_byt_cr(struct device *dev, bool *bytcr) > > +static int is_byt_cr(struct platform_device *pdev, bool *bytcr) > > { > > + struct device *dev = &pdev->dev; > > int status = 0; > > + if (platform_get_resource(pdev, IORESOURCE_IRQ, 5) == NULL) { > > + /* This message is even shown if the device would be detected as BYT-CR below */ > > + dev_info(dev, "Falling back to Baytrail-CR platform\n"); > > + *bytcr = true; > > + return status; > > + } > > + > > if (IS_ENABLED(CONFIG_IOSF_MBI)) { > > u32 bios_status; > > This would be my preferred solution but if it doesn't work as Hans mentions > it then we need to think of alternatives. > > Baytrail platforms are so different (BIOS and hardware) that I don't think > we'll manage to pull this off without quirks. > It definitely works on my device and the few others I have seen with only one IRQ listed. But there might be devices out there which are not covered by the pmic-type based detection but still have all 6 IRQs listed. As for the "Teclast X98 Air 3G": Antonio, you mentioned that you have last tested mainline a few years back. Can you re-test without any modifications to the DSDT table on a recent mainline kernel? I just wonder if it is really not covered by the pmic-type based detection. It does have quirks in mainline that were added with the pull request that also added the pmic-type based BYT-CR detection (see [1]). [1]: http://mailman.alsa-project.org/pipermail/alsa-devel/2016-August/111704.html