All of lore.kernel.org
 help / color / mirror / Atom feed
From: Yann E. MORIN <yann.morin.1998@free.fr>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH v2 1/4] system cfg: introduce option BR2_SYSTEM_DEFAULT_PATH
Date: Wed, 19 Dec 2018 22:32:45 +0100	[thread overview]
Message-ID: <20181219213245.GO24194@scaer> (raw)
In-Reply-To: <20181219210455.14754-2-mmayer@broadcom.com>

Markus, All,

On 2018-12-19 13:04 -0800, Markus Mayer spake thusly:
> The configuration option BR2_SYSTEM_DEFAULT_PATH allows the user to
> override the default path, which can be used by /etc/profile and some
> system daemons.
> 
> It defaults to the value previously hard-coded in /etc/profile. This
> default should be suitable for most users.
> 
> Signed-off-by: Markus Mayer <mmayer@broadcom.com>
> ---
>  system/Config.in | 9 +++++++++
>  system/system.mk | 4 ++++
>  2 files changed, 13 insertions(+)
> 
> diff --git a/system/Config.in b/system/Config.in
> index 0f77b9b6721a..afae487a4bd5 100644
> --- a/system/Config.in
> +++ b/system/Config.in
> @@ -386,6 +386,15 @@ comment "automatic network configuration via DHCP needs ifupdown or busybox or n
>  
>  endif # BR2_ROOTFS_SKELETON_DEFAULT
>  
> +config BR2_SYSTEM_DEFAULT_PATH
> +	string "Set the system's default PATH"
> +	default "/bin:/sbin:/usr/bin:/usr/sbin"
> +	help
> +	  Sets the system's default PATH. It is being used in /etc/profile

Slight formatting issue here, check-package conplains:

    system/Config.in:393: help text: <tab><2 spaces><62 chars> (http://nightly.buildroot.org/#writing-rules-config-in)

Otherwise (no need to respin, that can be fixed when applying I hope):

Acked-by: "Yann E. MORIN" <yann.morin.1998@free.fr>

Regards,
Yann E. MORIN.

> +	  in the skeleton-init-common package and by some daemons.
> +
> +	  The default should work in most cases.
> +
>  config BR2_ENABLE_LOCALE_PURGE
>  	bool "Purge unwanted locales"
>  	default y
> diff --git a/system/system.mk b/system/system.mk
> index ca6bf1388f39..8db87cb12930 100644
> --- a/system/system.mk
> +++ b/system/system.mk
> @@ -86,3 +86,7 @@ define SYSTEM_REMOUNT_ROOT_INITTAB
>  	$(SED) '/^[^#].*-o remount,rw \/$$/s~^~#~' $(TARGET_DIR)/etc/inittab
>  endef
>  endif
> +
> +ifeq ($(BR_BUILDING)$(BR2_SYSTEM_DEFAULT_PATH),y"")
> +$(error BR2_SYSTEM_DEFAULT_PATH can't be empty)
> +endif
> -- 
> 2.17.1
> 

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 223 225 172 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'

  reply	other threads:[~2018-12-19 21:32 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-12-19 21:04 [Buildroot] [PATCH v2 0/4] Allow customization of system default PATH Markus Mayer
2018-12-19 21:04 ` [Buildroot] [PATCH v2 1/4] system cfg: introduce option BR2_SYSTEM_DEFAULT_PATH Markus Mayer
2018-12-19 21:32   ` Yann E. MORIN [this message]
2018-12-19 21:04 ` [Buildroot] [PATCH v2 2/4] skeleton: use BR2_SYSTEM_DEFAULT_PATH as default PATH Markus Mayer
2018-12-19 21:34   ` Yann E. MORIN
2018-12-19 23:24     ` Markus Mayer
2018-12-20 16:04       ` Yann E. MORIN
2018-12-19 21:04 ` [Buildroot] [PATCH v2 3/4] openssh: " Markus Mayer
2018-12-19 21:34   ` Yann E. MORIN
2018-12-19 21:04 ` [Buildroot] [PATCH v2 4/4] dropbear: " Markus Mayer
2018-12-19 21:38   ` Yann E. MORIN

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20181219213245.GO24194@scaer \
    --to=yann.morin.1998@free.fr \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.