From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <stable-owner@vger.kernel.org>
Received: from mail.kernel.org ([198.145.29.99]:42342 "EHLO mail.kernel.org"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1728835AbeLTB5L (ORCPT <rfc822;stable@vger.kernel.org>);
        Wed, 19 Dec 2018 20:57:11 -0500
Date: Wed, 19 Dec 2018 20:57:08 -0500
From: Sasha Levin <sashal@kernel.org>
To: Daniel Borkmann <daniel@iogearbox.net>
Cc: gregkh@linuxfoundation.org, ast@kernel.org, nschichan@freebox.fr,
        stable@vger.kernel.org, Russell King <rmk+kernel@armlinux.org.uk>
Subject: Re: [PATCH stable 4.14] bpf, arm: fix emit_ldx_r and emit_mov_i
 using TMP_REG_1
Message-ID: <20181220015708.GD86645@sasha-vm>
References: <4c897861da96ab890fdf9ccf2b78337748a0d4b3.1545255104.git.daniel@iogearbox.net>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii; format=flowed
Content-Disposition: inline
In-Reply-To: <4c897861da96ab890fdf9ccf2b78337748a0d4b3.1545255104.git.daniel@iogearbox.net>
Sender: stable-owner@vger.kernel.org
List-ID: <stable.vger.kernel.org>

On Wed, Dec 19, 2018 at 10:40:42PM +0100, Daniel Borkmann wrote:
>From: Nicolas Schichan <nschichan@freebox.fr>
>
>emit_ldx_r() and emit_a32_mov_i() were both using TMP_REG_1 and
>clashing with each other. Using TMP_REG_2 in emit_ldx_r() fixes
>the issue.
>
>Fixes: ec19e02b343 ("ARM: net: bpf: fix LDX instructions")
>Cc: Russell King <rmk+kernel@armlinux.org.uk>
>Signed-off-by: Nicolas Schichan <nschichan@freebox.fr>
>Signed-off-by: Daniel Borkmann <daniel@iogearbox.net>
>---
> [ Note, this has been implicitly fixed upstream by a6eccac507e
>   ("ARM: net: bpf: 64-bit accessor functions for BPF registers"),
>   so the fix here is a minimal stand-alone fix for 4.14. test_bpf
>   suite runs without error after the fix. ]

Queued for 4.14, thank you.

--
Thanks,
Sasha