From mboxrd@z Thu Jan 1 00:00:00 1970 From: Greg Kroah-Hartman Subject: [PATCH 4.14 51/72] drm/msm: Fix error return checking Date: Thu, 20 Dec 2018 10:18:50 +0100 Message-ID: <20181220085924.350437005@linuxfoundation.org> References: <20181220085922.332225035@linuxfoundation.org> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <20181220085922.332225035@linuxfoundation.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: linux-kernel@vger.kernel.org Cc: Sasha Levin , David Airlie , Greg Kroah-Hartman , stable@vger.kernel.org, Julia Lawall , Sean Paul , dri-devel@lists.freedesktop.org, linux-arm-msm@vger.kernel.org, freedreno@lists.freedesktop.org, Wen Yang List-Id: linux-arm-msm@vger.kernel.org NC4xNC1zdGFibGUgcmV2aWV3IHBhdGNoLiAgSWYgYW55b25lIGhhcyBhbnkgb2JqZWN0aW9ucywg cGxlYXNlIGxldCBtZSBrbm93LgoKLS0tLS0tLS0tLS0tLS0tLS0tCgpbIFVwc3RyZWFtIGNvbW1p dCAwOTgzMzZkZWI5NDZmMzdhNzBhZmMwOTc5YWYzODhiNjE1YzM3OGJmIF0KClRoZSBlcnJvciBj aGVja3Mgb24gcmV0IGZvciBhIG5lZ2F0aXZlIGVycm9yIHJldHVybiBhbHdheXMgZmFpbHMgYmVj YXVzZQp0aGUgcmV0dXJuIHZhbHVlIG9mIGlvbW11X21hcF9zZygpIGlzIHVuc2lnbmVkIGFuZCBj YW4gbmV2ZXIgYmUgbmVnYXRpdmUuCgpEZXRlY3RlZCB3aXRoIENvY2NpbmVsbGU6CmRyaXZlcnMv Z3B1L2RybS9tc20vbXNtX2lvbW11LmM6Njk6OS0xMjogV0FSTklORzogVW5zaWduZWQgZXhwcmVz c2lvbgpjb21wYXJlZCB3aXRoIHplcm86IHJldCA8IDAKClNpZ25lZC1vZmYtYnk6IFdlbiBZYW5n IDx3ZW4ueWFuZzk5QHp0ZS5jb20uY24+CkNDOiBSb2IgQ2xhcmsgPHJvYmRjbGFya0BnbWFpbC5j b20+CkNDOiBEYXZpZCBBaXJsaWUgPGFpcmxpZWRAbGludXguaWU+CkNDOiBKdWxpYSBMYXdhbGwg PGp1bGlhLmxhd2FsbEBsaXA2LmZyPgpDQzogbGludXgtYXJtLW1zbUB2Z2VyLmtlcm5lbC5vcmcK Q0M6IGRyaS1kZXZlbEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKQ0M6IGZyZWVkcmVub0BsaXN0cy5m cmVlZGVza3RvcC5vcmcKQ0M6IGxpbnV4LWtlcm5lbEB2Z2VyLmtlcm5lbC5vcmcKU2lnbmVkLW9m Zi1ieTogU2VhbiBQYXVsIDxzZWFucGF1bEBjaHJvbWl1bS5vcmc+ClNpZ25lZC1vZmYtYnk6IFNh c2hhIExldmluIDxzYXNoYWxAa2VybmVsLm9yZz4KLS0tCiBkcml2ZXJzL2dwdS9kcm0vbXNtL21z bV9pb21tdS5jIHwgMiArLQogMSBmaWxlIGNoYW5nZWQsIDEgaW5zZXJ0aW9uKCspLCAxIGRlbGV0 aW9uKC0pCgpkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL21zbS9tc21faW9tbXUuYyBiL2Ry aXZlcnMvZ3B1L2RybS9tc20vbXNtX2lvbW11LmMKaW5kZXggYjIzZDMzNjIyZjM3Li4yYTkwYWE0 Y2FlYzAgMTAwNjQ0Ci0tLSBhL2RyaXZlcnMvZ3B1L2RybS9tc20vbXNtX2lvbW11LmMKKysrIGIv ZHJpdmVycy9ncHUvZHJtL21zbS9tc21faW9tbXUuYwpAQCAtNjYsNyArNjYsNyBAQCBzdGF0aWMg aW50IG1zbV9pb21tdV9tYXAoc3RydWN0IG1zbV9tbXUgKm1tdSwgdWludDY0X3QgaW92YSwKIC8v CXBtX3J1bnRpbWVfZ2V0X3N5bmMobW11LT5kZXYpOwogCXJldCA9IGlvbW11X21hcF9zZyhpb21t dS0+ZG9tYWluLCBpb3ZhLCBzZ3QtPnNnbCwgc2d0LT5uZW50cywgcHJvdCk7CiAvLwlwbV9ydW50 aW1lX3B1dF9zeW5jKG1tdS0+ZGV2KTsKLQlXQVJOX09OKHJldCA8IDApOworCVdBUk5fT04oIXJl dCk7CiAKIAlyZXR1cm4gKHJldCA9PSBsZW4pID8gMCA6IC1FSU5WQUw7CiB9Ci0tIAoyLjE5LjEK CgoKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KZHJpLWRl dmVsIG1haWxpbmcgbGlzdApkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8v bGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vZHJpLWRldmVsCg== From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.0 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS,URIBL_BLOCKED, USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id F00A5C43387 for ; Thu, 20 Dec 2018 09:36:50 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id BB3D620449 for ; Thu, 20 Dec 2018 09:36:50 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1545298610; bh=pTcMKgYXSqRdfDNm05MA+LmStAIdl75SfcDLj8E5l7w=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=0gQ3FfGQnO63xO1KP6nAyQOnm1+tR874zcPPxiR7z76JN+y28lFpXIQg3CiVWR047 24B2CK+2RJxZq1roI9aoRZZ/ljs26wWsLeHQElL2USItvA+o8Iad4c3otxNKsBjB/T nxtBhHstqcdH6FLYm+0/Eokq2nTXk3xWLcs9QqoU= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1733280AbeLTJgt (ORCPT ); Thu, 20 Dec 2018 04:36:49 -0500 Received: from mail.kernel.org ([198.145.29.99]:36658 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1732318AbeLTJ11 (ORCPT ); Thu, 20 Dec 2018 04:27:27 -0500 Received: from localhost (5356596B.cm-6-7b.dynamic.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 9470F217D4; Thu, 20 Dec 2018 09:27:25 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1545298046; bh=pTcMKgYXSqRdfDNm05MA+LmStAIdl75SfcDLj8E5l7w=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=nHl1qc6Atn1GqdHg4WBcKNpQydSg21MUi4vtxP19CbuEjpMx8htOPpOiNtIBW94s0 hGXvylsBXSDHqq3ClfZygJSjwCG1RgnfgDY/738NL3mTTYGGYt4znK+IdIq7sOsYoq NaVybeaCmCNI3XhWUhJxkaT2guW6g+ObktNGNPrQ= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Wen Yang , Rob Clark , David Airlie , Julia Lawall , linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org, Sean Paul , Sasha Levin Subject: [PATCH 4.14 51/72] drm/msm: Fix error return checking Date: Thu, 20 Dec 2018 10:18:50 +0100 Message-Id: <20181220085924.350437005@linuxfoundation.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20181220085922.332225035@linuxfoundation.org> References: <20181220085922.332225035@linuxfoundation.org> User-Agent: quilt/0.65 X-stable: review X-Patchwork-Hint: ignore MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org 4.14-stable review patch. If anyone has any objections, please let me know. ------------------ [ Upstream commit 098336deb946f37a70afc0979af388b615c378bf ] The error checks on ret for a negative error return always fails because the return value of iommu_map_sg() is unsigned and can never be negative. Detected with Coccinelle: drivers/gpu/drm/msm/msm_iommu.c:69:9-12: WARNING: Unsigned expression compared with zero: ret < 0 Signed-off-by: Wen Yang CC: Rob Clark CC: David Airlie CC: Julia Lawall CC: linux-arm-msm@vger.kernel.org CC: dri-devel@lists.freedesktop.org CC: freedreno@lists.freedesktop.org CC: linux-kernel@vger.kernel.org Signed-off-by: Sean Paul Signed-off-by: Sasha Levin --- drivers/gpu/drm/msm/msm_iommu.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/msm/msm_iommu.c b/drivers/gpu/drm/msm/msm_iommu.c index b23d33622f37..2a90aa4caec0 100644 --- a/drivers/gpu/drm/msm/msm_iommu.c +++ b/drivers/gpu/drm/msm/msm_iommu.c @@ -66,7 +66,7 @@ static int msm_iommu_map(struct msm_mmu *mmu, uint64_t iova, // pm_runtime_get_sync(mmu->dev); ret = iommu_map_sg(iommu->domain, iova, sgt->sgl, sgt->nents, prot); // pm_runtime_put_sync(mmu->dev); - WARN_ON(ret < 0); + WARN_ON(!ret); return (ret == len) ? 0 : -EINVAL; } -- 2.19.1