All of lore.kernel.org
 help / color / mirror / Atom feed
From: Andrew Lunn <andrew@lunn.ch>
To: Steen Hegelund <steen.hegelund@microchip.com>
Cc: netdev@vger.kernel.org, davem@davemloft.net,
	alexandre.belloni@bootlin.com
Subject: Re: [PATCH net] mscc: Register poll timeout should be wall time not attempts
Date: Thu, 20 Dec 2018 11:31:50 +0100	[thread overview]
Message-ID: <20181220103150.GD13180@lunn.ch> (raw)
In-Reply-To: <20181220090816.12764-1-steen.hegelund@microchip.com>

On Thu, Dec 20, 2018 at 10:08:16AM +0100, Steen Hegelund wrote:
> When doing indirect access in the Ocelot chip, a command is setup,
> issued and then we need to poll until the result is ready. The polling
> timeout is specified in milliseconds in the datasheet and not in
> register access attempts.
> 
> Signed-off-by: Steen Hegelund <steen.hegelund@microchip.com>

Hi Steen

Have you seen real issues with this code? You have marked this for
net, indicating it is a bug fix. If it is a real fix, please provide a
fixes: tag.

Thanks
	Andrew

  parent reply	other threads:[~2018-12-20 10:31 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-12-20  9:08 [PATCH net] mscc: Register poll timeout should be wall time not attempts Steen Hegelund
2018-12-20 10:29 ` Alexandre Belloni
2018-12-20 10:31 ` Andrew Lunn [this message]
2018-12-20 11:11   ` Steen Hegelund
2018-12-20 11:31     ` Andrew Lunn

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20181220103150.GD13180@lunn.ch \
    --to=andrew@lunn.ch \
    --cc=alexandre.belloni@bootlin.com \
    --cc=davem@davemloft.net \
    --cc=netdev@vger.kernel.org \
    --cc=steen.hegelund@microchip.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.