From mboxrd@z Thu Jan 1 00:00:00 1970 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Subject: [v5] cdc-acm: fix abnormal DATA RX issue for Mediatek Preloader. From: Greg Kroah-Hartman Message-Id: <20181220151959.GA17408@kroah.com> Date: Thu, 20 Dec 2018 16:19:59 +0100 To: Oliver Neukum Cc: Macpaul Lin , Lars Melin , Andrey Arapov , Johan Hovold , Mediatek WSD Upstream , linux-usb@vger.kernel.org, stable@vger.kernel.org List-ID: T24gV2VkLCBEZWMgMTksIDIwMTggYXQgMDk6NTY6MjJBTSArMDEwMCwgT2xpdmVyIE5ldWt1bSB3 cm90ZToKPiBPbiBNaSwgMjAxOC0xMi0xOSBhdCAxMjowMyArMDgwMCwgTWFjcGF1bCBMaW4gd3Jv dGU6Cj4gPiBPbiBXZWQsIDIwMTgtMTItMTkgYXQgMTA6MzEgKzA3MDAsIExhcnMgTWVsaW4gd3Jv dGU6Cj4gPiA+IE9uIDEyLzE5LzIwMTggMTA6MTYsIE1hY3BhdWwgTGluIHdyb3RlOiAKPiA+ID4g Cj4gPiA+IEhpIE1hY3BhdWwsCj4gPiA+IHlvdXIgdmVyYm9zZSB1c2IgbGlzdGluZyBzaG93IG1l IHRoYXQgTWVkaWF0ZWsgaGFzIG1hZGUgdHdvIGRpZmZlcmVudCAKPiA+ID4gMGU4ZDowMDMgZGV2 aWNlcywgc2VlIG15IHZlcmJvc2UgbHN1c2IgbGlzdGluZyBiZWxvdy4KPiA+ID4gKE5vdGljZSBh bHNvIHRoZSByZXZlcnNlIG9yZGVyIGZvciBjbWQgYW5kIGRhdGEgaW50ZXJmYWNlcyBpbiBpdCAK PiA+ID4gY29tcGFyZWQgdG8geW91cnMpLgo+ID4gPiBVU0IgaWQncyBhcmUgaW50ZW5kZWQgdG8g aWRlbnRpZnkgYSBkZXZpY2UgYW5kIGl0cyBuZWVkcyBzbyB0aGVyZSBzaG91bGQKPiA+ID4gbmV2 ZXIgYmUgbW9yZSB0aGFuIG9uZSB1bmlxdWUgZGV2aWNlIHBlciBpZC4KPiA+ID4gCj4gPiA+IAo+ ID4gPiBGYWlycGhvbmUgRlAtMSwgTVQ2MjI3ICAobm8gQ0RDIHVuaW9uICEhISkKPiA+ID4gCj4g PiAKPiA+IEhpIExhcnMsCj4gPiAKPiA+IEhhIGhhIGhhLCBpdCBpcyBhIGxpdHRsZSBiaXQgZW1i YXJyYXNzaW5nLgo+ID4gV2hhdCBJJ3ZlIHVzZWQgdG8gY2FwdHVyZSB2ZXJib3NlIGxvZyBpcyBN VDY3NjUgcGxhdGZvcm0uCj4gPiBUaGVuIEkndmUgY2hlY2tlZCBGYWlycGhvbmUgRlAtMSwgd2hp Y2ggaXMgTVQ2NTg5IGEgcHJldHR5IG9sZCBwbGF0Zm9ybS4KPiA+IFRoZSBCUk9NIChib290IFJP TSkgaGFzIGJlZW4gbWFpbnRhaW5lZCBieSBvdGhlciB0ZWFtcyBhbmQgd2lsbCB2YXJ5IGJ5Cj4g PiBkaWZmZXJlbnQgU29DIHByb2plY3QgaW4gTWVkaWF0ZWsuIEknbSBub3Qgc3VyZSB3aHkgdGhl eSBjaGFuZ2VkIHRoZQo+ID4gZGVzY3JpcHRvcnMuCj4gPiAKPiA+IEZvciB0aGUgY29uc2lzdGVu Y3kgb2YgQlJPTSdzIGJlaGF2aW9yLCBJJ2xsIHVwZGF0ZSBhIG5ldyBwYXRjaCBrZWVwcwo+ID4g UElEOjAwMDMgcmVtYWluIHVudG91Y2hlZC4gSSdsbCB0cnlpbmcgdG8gcmVwb3J0IGl0IHRvIEJS T00gdGVhbSBhbmQgc2VlCj4gPiBpZiB0aGV5IGhhdmUgYW55IGFjdGlvbiBvbiB0aGlzIGlzc3Vl Lgo+IAo+IFRoYW5rIHlvdSBhbGwgZm9yIHRha2luZyBjYXJlIG9mIHRoZXNlIGltcG9ydGFudCBp c3N1ZXMuCj4gUGxlYXNlIHN1Ym1pdCB0aGF0IG5ldyBwYXRjaC4KCkNhbiB5b3UgcmV2aWV3IHY3 IHBsZWFzZT8KCnRoYW5rcywKCmdyZWcgay1oCg== From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.kernel.org ([198.145.29.99]:50396 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729693AbeLTPUC (ORCPT ); Thu, 20 Dec 2018 10:20:02 -0500 Date: Thu, 20 Dec 2018 16:19:59 +0100 From: Greg Kroah-Hartman To: Oliver Neukum Cc: Macpaul Lin , Lars Melin , Andrey Arapov , Johan Hovold , Mediatek WSD Upstream , linux-usb@vger.kernel.org, stable@vger.kernel.org Subject: Re: [PATCH v5] cdc-acm: fix abnormal DATA RX issue for Mediatek Preloader. Message-ID: <20181220151959.GA17408@kroah.com> References: <1545140229.18594.3.camel@suse.com> <1545143195.10193.6.camel@mtkswgap22> <1545146389.10193.12.camel@mtkswgap22> <5b0e5bf4-0411-0c58-ccae-fe66c937a36b@gmail.com> <1545155303.16619.11.camel@mtkswgap22> <1545186137.1821.5.camel@mtkswgap22> <1545189395.3262.2.camel@mtkswgap22> <3465233a-1afd-8112-ebd6-78cceb426c9d@gmail.com> <1545192203.4134.11.camel@mtkswgap22> <1545209782.31763.2.camel@suse.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1545209782.31763.2.camel@suse.com> Sender: stable-owner@vger.kernel.org List-ID: On Wed, Dec 19, 2018 at 09:56:22AM +0100, Oliver Neukum wrote: > On Mi, 2018-12-19 at 12:03 +0800, Macpaul Lin wrote: > > On Wed, 2018-12-19 at 10:31 +0700, Lars Melin wrote: > > > On 12/19/2018 10:16, Macpaul Lin wrote: > > > > > > Hi Macpaul, > > > your verbose usb listing show me that Mediatek has made two different > > > 0e8d:003 devices, see my verbose lsusb listing below. > > > (Notice also the reverse order for cmd and data interfaces in it > > > compared to yours). > > > USB id's are intended to identify a device and its needs so there should > > > never be more than one unique device per id. > > > > > > > > > Fairphone FP-1, MT6227 (no CDC union !!!) > > > > > > > Hi Lars, > > > > Ha ha ha, it is a little bit embarrassing. > > What I've used to capture verbose log is MT6765 platform. > > Then I've checked Fairphone FP-1, which is MT6589 a pretty old platform. > > The BROM (boot ROM) has been maintained by other teams and will vary by > > different SoC project in Mediatek. I'm not sure why they changed the > > descriptors. > > > > For the consistency of BROM's behavior, I'll update a new patch keeps > > PID:0003 remain untouched. I'll trying to report it to BROM team and see > > if they have any action on this issue. > > Thank you all for taking care of these important issues. > Please submit that new patch. Can you review v7 please? thanks, greg k-h