From: Thierry Reding <thierry.reding@gmail.com>
To: Anson Huang <anson.huang@nxp.com>
Cc: "linux-pwm@vger.kernel.org" <linux-pwm@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
dl-linux-imx <linux-imx@nxp.com>
Subject: Re: [PATCH] pwm: imx: add ipg clock operation
Date: Thu, 20 Dec 2018 18:28:24 +0100 [thread overview]
Message-ID: <20181220172824.GC9408@ulmo> (raw)
In-Reply-To: <1545196822-31361-1-git-send-email-Anson.Huang@nxp.com>
[-- Attachment #1: Type: text/plain, Size: 869 bytes --]
On Wed, Dec 19, 2018 at 05:24:58AM +0000, Anson Huang wrote:
> i.MX PWM module's ipg_clk_s is for PWM register access, on
> most of i.MX SoCs, this ipg_clk_s is from system ipg clock
> or perclk which is always enabled, but on i.MX7D, the ipg_clk_s
> is from PWM1_CLK_ROOT which is controlled by CCGR132, that means
> the CCGR132 MUST be enabled first before accessing PWM registers
> on i.MX7D. This patch adds ipg clock operation to make sure
> register access successfully on i.MX7D and it fixes Linux kernel
> boot up hang during PWM driver probe.
>
> Fixes: 4a23e6ee9f69 ("ARM: dts: imx7d-sdb: Restore pwm backlight support")
> Signed-off-by: Anson Huang <Anson.Huang@nxp.com>
> ---
> drivers/pwm/pwm-imx.c | 53 ++++++++++++++++++++++++++++++++++++++++++++++-----
> 1 file changed, 48 insertions(+), 5 deletions(-)
Applied, thanks.
Thierry
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
prev parent reply other threads:[~2018-12-20 17:28 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-19 5:24 [PATCH] pwm: imx: add ipg clock operation Anson Huang
2018-12-20 17:28 ` Thierry Reding [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181220172824.GC9408@ulmo \
--to=thierry.reding@gmail.com \
--cc=anson.huang@nxp.com \
--cc=linux-imx@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pwm@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.