From: Christoph Hellwig <hch@lst.de>
To: Jason Gunthorpe <jgg@ziepe.ca>
Cc: Stephen Warren <swarren@wwwdotorg.org>,
Tariq Toukan <tariqt@mellanox.com>,
xavier.huwei@huawei.com, netdev@vger.kernel.org,
linux-rdma@vger.kernel.org, Doug Ledford <dledford@redhat.com>,
Christoph Hellwig <hch@lst.de>,
Stephen Warren <swarren@nvidia.com>
Subject: Re: [PATCH V3] net/mlx4: Get rid of page operation after dma_alloc_coherent
Date: Thu, 20 Dec 2018 18:44:48 +0100 [thread overview]
Message-ID: <20181220174448.GA21149@lst.de> (raw)
In-Reply-To: <20181220174318.GA21404@ziepe.ca>
On Thu, Dec 20, 2018 at 10:43:18AM -0700, Jason Gunthorpe wrote:
> > - chunk->coherent is an int not a bool since checkpatch complains about
> > using bool in structs; see https://lkml.org/lkml/2017/11/21/384.
>
> :( bool is much more readable and there is no performance concern in
> this struct. I think checkpatch is overzealous here.
Yes. Nevermind that this for bool vs bitfield. A int is worse in
every respect in the criteria used in that mail.
next prev parent reply other threads:[~2018-12-20 17:44 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-19 18:20 [PATCH V3] net/mlx4: Get rid of page operation after dma_alloc_coherent Stephen Warren
2018-12-20 17:43 ` Jason Gunthorpe
2018-12-20 17:44 ` Christoph Hellwig [this message]
2018-12-20 17:49 ` Bart Van Assche
2018-12-21 2:25 ` rfc: bool structure members (was Re: [PATCH V3] net/mlx4: Get rid of page operation after dma_alloc_coherent) Joe Perches
2018-12-21 2:40 ` Andrew Morton
2018-12-21 3:31 ` Jason Gunthorpe
2018-12-21 5:12 ` Joe Perches
2018-12-21 23:52 ` Jason Gunthorpe
2018-12-21 23:52 ` Jason Gunthorpe
2018-12-23 16:42 ` Gal Pressman
2018-12-23 16:42 ` Gal Pressman
2018-12-23 16:53 ` Al Viro
2018-12-24 22:08 ` Jason Gunthorpe
2018-12-24 23:12 ` Jason Gunthorpe
2018-12-25 8:41 ` Gal Pressman
2018-12-25 8:41 ` Gal Pressman
2019-01-02 16:29 ` [PATCH V3] net/mlx4: Get rid of page operation after dma_alloc_coherent Stephen Warren
2019-01-03 7:48 ` Christoph Hellwig
2019-01-03 14:32 ` Tariq Toukan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181220174448.GA21149@lst.de \
--to=hch@lst.de \
--cc=dledford@redhat.com \
--cc=jgg@ziepe.ca \
--cc=linux-rdma@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=swarren@nvidia.com \
--cc=swarren@wwwdotorg.org \
--cc=tariqt@mellanox.com \
--cc=xavier.huwei@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.