From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: kernel-janitors@vger.kernel.org
Subject: Re: [PATCH] Input: nomadik-ske-keypad - Fix a loop timeout test
Date: Fri, 21 Dec 2018 08:40:21 +0000 [thread overview]
Message-ID: <20181221084021.GF211587@dtor-ws> (raw)
In-Reply-To: <20181218081854.GC32567@kadam>
On Tue, Dec 18, 2018 at 11:18:54AM +0300, Dan Carpenter wrote:
> The loop exits with "timeout" set to -1 not to 0.
>
> Fixes: 1158f0f16224 ("Input: add support for Nomadik SKE keypad controller")
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Applied, thank you.
> ---
> drivers/input/keyboard/nomadik-ske-keypad.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/input/keyboard/nomadik-ske-keypad.c b/drivers/input/keyboard/nomadik-ske-keypad.c
> index 8567ee47761e..ae3b04557074 100644
> --- a/drivers/input/keyboard/nomadik-ske-keypad.c
> +++ b/drivers/input/keyboard/nomadik-ske-keypad.c
> @@ -100,7 +100,7 @@ static int __init ske_keypad_chip_init(struct ske_keypad *keypad)
> while ((readl(keypad->reg_base + SKE_RIS) != 0x00000000) && timeout--)
> cpu_relax();
>
> - if (!timeout)
> + if (timeout = -1)
> return -EINVAL;
>
> /*
> --
> 2.17.1
>
--
Dmitry
prev parent reply other threads:[~2018-12-21 8:40 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-18 8:18 [PATCH] Input: nomadik-ske-keypad - Fix a loop timeout test Dan Carpenter
2018-12-21 8:40 ` Dmitry Torokhov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181221084021.GF211587@dtor-ws \
--to=dmitry.torokhov@gmail.com \
--cc=kernel-janitors@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.