From: John Snow <jsnow@redhat.com>
To: qemu-devel@nongnu.org, qemu-block@nongnu.org
Cc: eblake@redhat.com, Max Reitz <mreitz@redhat.com>,
Fam Zheng <fam@euphon.net>,
vsementsov@virtuozzo.com, John Snow <jsnow@redhat.com>,
Kevin Wolf <kwolf@redhat.com>,
Markus Armbruster <armbru@redhat.com>
Subject: [Qemu-devel] [PATCH v6 00/11] bitmaps: remove x- prefix from QMP api
Date: Fri, 21 Dec 2018 04:35:18 -0500 [thread overview]
Message-ID: <20181221093529.23855-1-jsnow@redhat.com> (raw)
Fix some outstanding bugs, change the design of an API element,
remove the x- prefix to signify stability, and add iotests.
V6:
- Cover letter touchups
- 09: Rewrite qmp_filter to cope with lists or dicts.
- 11: small touchups.
V5:
002: New bugfix.
003: I forgot to actually capture state->bitmap anywhere,
which is needed for restoration...
007: Better commit message
- use .items() instead of .keys() to save a lookup [Vladimir]
- use a sequence of tuples to preserve ordering in
the OrderedDict constructor [Vladimir]
- Move the sort_keys boolean up from patch 010
008: Better commit message
009: Better commit message
010: Moved the sort_keys function up to patch 007
011: Expanded this test considerably:
- query_bitmaps can now show empty results,
and prefixes results with "bitmaps:" in the log
- logging declarations are one line [Vladimir]
- Added a bad version of the bitmap handoff transaction [Eric]
- Added a bad version of the bitmap merge transaction,
which revealed a problem that patch 02 now addresses [Eric]
- Added bitmap removal / cleanup [Eric]
- Added newline at end of file. [Eric]
V4:
- Removed patches 1-5 which have been staged
- Rewrite qmp_log entirely, split into three patches
- Pretty-printing has been extended to log() as well as qmp_log()
- Adjust iotest 236 to be format generic instead of qcow2 [Vladimir]
- Adjust iotest 236 to not reduplicate serialization work [Vladimir]
- Many other small touchups
V3:
- Reworked qmp_log to pretty-print the outgoing command, too [Vladimir]
- Modified test to log only bitmap information [Vladimir]
- Test disable/enable transaction toggle [Eric]
John Snow (11):
blockdev: abort transactions in reverse order
block/dirty-bitmap: remove assertion from restore
blockdev: n-ary bitmap merge
block: remove 'x' prefix from experimental bitmap APIs
iotests.py: don't abort if IMGKEYSECRET is undefined
iotests: add filter_generated_node_ids
iotests: add qmp recursive sorting function
iotests: remove default filters from qmp_log
iotests: change qmp_log filters to expect QMP objects only
iotests: implement pretty-print for log and qmp_log
iotests: add iotest 236 for testing bitmap merge
block/dirty-bitmap.c | 1 -
blockdev.c | 107 +++++++----
qapi/block-core.json | 56 +++---
qapi/transaction.json | 12 +-
tests/qemu-iotests/206 | 8 +-
tests/qemu-iotests/223 | 4 +-
tests/qemu-iotests/236 | 161 ++++++++++++++++
tests/qemu-iotests/236.out | 351 ++++++++++++++++++++++++++++++++++
tests/qemu-iotests/group | 1 +
tests/qemu-iotests/iotests.py | 64 ++++++-
10 files changed, 677 insertions(+), 88 deletions(-)
create mode 100755 tests/qemu-iotests/236
create mode 100644 tests/qemu-iotests/236.out
--
2.17.2
next reply other threads:[~2018-12-21 9:35 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-21 9:35 John Snow [this message]
2018-12-21 9:35 ` [Qemu-devel] [PATCH v6 01/11] blockdev: abort transactions in reverse order John Snow
2019-01-11 17:52 ` Eric Blake
2019-01-11 19:34 ` Eric Blake
2018-12-21 9:35 ` [Qemu-devel] [PATCH v6 02/11] block/dirty-bitmap: remove assertion from restore John Snow
2018-12-21 9:35 ` [Qemu-devel] [PATCH v6 03/11] blockdev: n-ary bitmap merge John Snow
2018-12-21 9:35 ` [Qemu-devel] [PATCH v6 04/11] block: remove 'x' prefix from experimental bitmap APIs John Snow
2019-01-03 23:21 ` Eric Blake
2019-01-08 10:55 ` Vladimir Sementsov-Ogievskiy
2018-12-21 9:35 ` [Qemu-devel] [PATCH v6 05/11] iotests.py: don't abort if IMGKEYSECRET is undefined John Snow
2018-12-21 9:35 ` [Qemu-devel] [PATCH v6 06/11] iotests: add filter_generated_node_ids John Snow
2018-12-21 9:35 ` [Qemu-devel] [PATCH v6 07/11] iotests: add qmp recursive sorting function John Snow
2018-12-21 9:35 ` [Qemu-devel] [PATCH v6 08/11] iotests: remove default filters from qmp_log John Snow
2018-12-21 9:35 ` [Qemu-devel] [PATCH v6 09/11] iotests: change qmp_log filters to expect QMP objects only John Snow
2018-12-21 12:41 ` Vladimir Sementsov-Ogievskiy
2018-12-21 20:13 ` John Snow
2018-12-24 8:26 ` Vladimir Sementsov-Ogievskiy
2018-12-21 9:35 ` [Qemu-devel] [PATCH v6 10/11] iotests: implement pretty-print for log and qmp_log John Snow
2018-12-21 9:35 ` [Qemu-devel] [PATCH v6 11/11] iotests: add iotest 236 for testing bitmap merge John Snow
2019-01-09 2:50 ` Eric Blake
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181221093529.23855-1-jsnow@redhat.com \
--to=jsnow@redhat.com \
--cc=armbru@redhat.com \
--cc=eblake@redhat.com \
--cc=fam@euphon.net \
--cc=kwolf@redhat.com \
--cc=mreitz@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=vsementsov@virtuozzo.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.