From: Charles Keepax <ckeepax@opensource.cirrus.com>
To: James Schulman <james.schulman@cirrus.com>
Cc: mark.rutland@arm.com, brian.austin@cirrus.com,
alsa-devel@alsa-project.org, paul.handrigan@cirrus.com,
lgirdwood@gmail.com, robh+dt@kernel.org
Subject: Re: [PATCH v4 2/2] ASoC: cs35l36: Add device tree documentation for CS35L36
Date: Fri, 21 Dec 2018 11:12:55 +0000 [thread overview]
Message-ID: <20181221111255.GC16508@imbe.wolfsonmicro.main> (raw)
In-Reply-To: <1545334876-12054-2-git-send-email-james.schulman@cirrus.com>
On Thu, Dec 20, 2018 at 01:41:16PM -0600, James Schulman wrote:
> Add device tree documentation for Cirrus Logic CS35L36
> speaker amplifier
>
> Signed-off-by: James Schulman <james.schulman@cirrus.com>
> ---
> + cirrus,irq-config {
> + cirrus,irq-drive-select = <0x01>;
> + cirrus,irq-polarity = <0x00>;
The irq-polarity needs dropped from the example, but otherwise:
Reviewed-by: Charles Keepax <ckeepax@opensource.cirrus.com>
Thanks,
Charles
> + cirrus,irq-gpio-select = <0x01>;
> + };
> +};
> --
> 1.9.1
next prev parent reply other threads:[~2018-12-21 11:12 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-20 19:41 [PATCH v4 1/2] ASoC: cs35l36: Add support for Cirrus CS35L36 Amplifier James Schulman
2018-12-20 19:41 ` [PATCH v4 2/2] ASoC: cs35l36: Add device tree documentation for CS35L36 James Schulman
2018-12-21 11:12 ` Charles Keepax [this message]
2018-12-21 19:52 ` Schulman, James
2018-12-21 11:12 ` [PATCH v4 1/2] ASoC: cs35l36: Add support for Cirrus CS35L36 Amplifier Charles Keepax
2018-12-21 19:51 ` Schulman, James
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181221111255.GC16508@imbe.wolfsonmicro.main \
--to=ckeepax@opensource.cirrus.com \
--cc=alsa-devel@alsa-project.org \
--cc=brian.austin@cirrus.com \
--cc=james.schulman@cirrus.com \
--cc=lgirdwood@gmail.com \
--cc=mark.rutland@arm.com \
--cc=paul.handrigan@cirrus.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.