From: Mark Brown <broonie@kernel.org>
To: Charles Keepax <ckeepax@opensource.cirrus.com>
Cc: alsa-devel@alsa-project.org,
"Liam Girdwood" <lgirdwood@gmail.com>,
patches@opensource.cirrus.com, "Takashi Iwai" <tiwai@suse.com>,
"Michał Mirosław" <mirq-linux@rere.qmqm.pl>
Subject: Re: [PATCH 2/4] ASoC: wm8904: Automatically enable FLL when selected
Date: Fri, 21 Dec 2018 11:58:31 +0000 [thread overview]
Message-ID: <20181221115831.GD4996@sirena.org.uk> (raw)
In-Reply-To: <20181221115227.GG16508@imbe.wolfsonmicro.main>
[-- Attachment #1.1: Type: text/plain, Size: 586 bytes --]
On Fri, Dec 21, 2018 at 11:52:27AM +0000, Charles Keepax wrote:
> On Wed, Dec 19, 2018 at 09:11:15PM +0100, Michał Mirosław wrote:
> > + if (!wm8904->fll_fout) {
> > + int ret = wm8904_set_fll(component, WM8904_FLL_MCLK, WM8904_FLL_MCLK,
> > + clk_get_rate(wm8904->mclk), 12288000);
> > + if (ret)
> > + return ret;
> > + }
> What is your thinking on selecting a 12.28MHz clock? Will this
> not cause issues with say 44.1k playback?
The driver just shouldn't be making decisions like this at all, either
generic code or a machine driver should do so.
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
[-- Attachment #2: Type: text/plain, Size: 0 bytes --]
next prev parent reply other threads:[~2018-12-21 11:58 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-19 20:11 [PATCH 0/4] ASoC: wm8904: prepare for use from audio-graph-card Michał Mirosław
2018-12-19 20:11 ` [PATCH 2/4] ASoC: wm8904: Automatically enable FLL when selected Michał Mirosław
2018-12-21 11:52 ` Charles Keepax
2018-12-21 11:58 ` Mark Brown [this message]
2019-01-13 12:37 ` Michał Mirosław
2018-12-19 20:11 ` [PATCH 1/4] ASoC: wm8904: make the driver visible in Kconfig Michał Mirosław
2018-12-21 11:16 ` Charles Keepax
2018-12-19 20:11 ` [PATCH 4/4] ASoC: wm8904: enable MCLK in STANDBY Michał Mirosław
2018-12-21 11:30 ` Charles Keepax
2018-12-19 20:11 ` [PATCH 3/4] ASoC: wm8904: save model id directly in of_device_id.data Michał Mirosław
2018-12-21 11:27 ` Charles Keepax
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181221115831.GD4996@sirena.org.uk \
--to=broonie@kernel.org \
--cc=alsa-devel@alsa-project.org \
--cc=ckeepax@opensource.cirrus.com \
--cc=lgirdwood@gmail.com \
--cc=mirq-linux@rere.qmqm.pl \
--cc=patches@opensource.cirrus.com \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.