From: Cornelia Huck <cohuck@redhat.com>
To: "Marc-André Lureau" <marcandre.lureau@redhat.com>
Cc: qemu-devel@nongnu.org, imammedo@redhat.com, ehabkost@redhat.com
Subject: Re: [Qemu-devel] [PATCH v7 18/28] compat: replace PC_COMPAT_2_2 & HW_COMPAT_2_2 macros
Date: Fri, 21 Dec 2018 14:08:38 +0100 [thread overview]
Message-ID: <20181221140838.3240174f.cohuck@redhat.com> (raw)
In-Reply-To: <20181221090410.27250-19-marcandre.lureau@redhat.com>
On Fri, 21 Dec 2018 13:04:00 +0400
Marc-André Lureau <marcandre.lureau@redhat.com> wrote:
> Use static arrays instead. I decided to rename the conflicting
> pc_compat_2_2() function with pc_compat_2_2_fn().
>
> Suggested-by: Eduardo Habkost <ehabkost@redhat.com>
> Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>
> ---
> include/hw/boards.h | 3 ++
> include/hw/compat.h | 3 --
> include/hw/i386/pc.h | 97 ++------------------------------------------
> hw/core/machine.c | 3 ++
> hw/i386/pc.c | 95 +++++++++++++++++++++++++++++++++++++++++++
> hw/i386/pc_piix.c | 12 +++---
> hw/ppc/spapr.c | 2 +-
> 7 files changed, 110 insertions(+), 105 deletions(-)
Reviewed-by: Cornelia Huck <cohuck@redhat.com>
next prev parent reply other threads:[~2018-12-21 13:08 UTC|newest]
Thread overview: 80+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-21 9:03 [Qemu-devel] [PATCH v7 00/28] Generalize machine compatibility properties Marc-André Lureau
2018-12-21 9:03 ` [Qemu-devel] [PATCH v7 01/28] hw: apply accel compat properties without touching globals Marc-André Lureau
2018-12-21 11:58 ` Cornelia Huck
2018-12-21 9:03 ` [Qemu-devel] [PATCH v7 02/28] machines: replace COMPAT define with a static array Marc-André Lureau
2018-12-21 12:33 ` Cornelia Huck
2018-12-21 14:17 ` Igor Mammedov
2018-12-21 9:03 ` [Qemu-devel] [PATCH v7 03/28] hw: apply machine compat properties without touching globals Marc-André Lureau
2018-12-21 12:38 ` Cornelia Huck
2018-12-21 14:20 ` Igor Mammedov
2018-12-21 9:03 ` [Qemu-devel] [PATCH v7 04/28] machine: move compat properties out of globals Marc-André Lureau
2018-12-21 12:44 ` Cornelia Huck
2018-12-21 14:21 ` Igor Mammedov
2018-12-21 9:03 ` [Qemu-devel] [PATCH v7 05/28] hw: remove SET_MACHINE_COMPAT Marc-André Lureau
2018-12-21 12:44 ` Cornelia Huck
2018-12-21 14:22 ` Igor Mammedov
2018-12-21 9:03 ` [Qemu-devel] [PATCH v7 06/28] compat: replace PC_COMPAT_3_1 & HW_COMPAT_3_1 macros Marc-André Lureau
2018-12-21 12:47 ` Cornelia Huck
2018-12-27 6:35 ` Igor Mammedov
2018-12-21 9:03 ` [Qemu-devel] [PATCH v7 07/28] compat: replace PC_COMPAT_3_0 & HW_COMPAT_3_0 macros Marc-André Lureau
2018-12-21 12:50 ` Cornelia Huck
2018-12-27 6:37 ` Igor Mammedov
2018-12-21 9:03 ` [Qemu-devel] [PATCH v7 08/28] compat: replace PC_COMPAT_2_12 & HW_COMPAT_2_12 macros Marc-André Lureau
2018-12-21 12:52 ` Cornelia Huck
2018-12-27 6:39 ` Igor Mammedov
2018-12-21 9:03 ` [Qemu-devel] [PATCH v7 09/28] compat: replace PC_COMPAT_2_11 & HW_COMPAT_2_11 macros Marc-André Lureau
2018-12-21 12:53 ` Cornelia Huck
2018-12-27 6:40 ` Igor Mammedov
2018-12-21 9:03 ` [Qemu-devel] [PATCH v7 10/28] compat: replace PC_COMPAT_2_10 & HW_COMPAT_2_10 macros Marc-André Lureau
2018-12-21 12:55 ` Cornelia Huck
2018-12-27 6:41 ` Igor Mammedov
2018-12-21 9:03 ` [Qemu-devel] [PATCH v7 11/28] compat: replace PC_COMPAT_2_9 & HW_COMPAT_2_9 macros Marc-André Lureau
2018-12-21 12:56 ` Cornelia Huck
2018-12-27 6:44 ` Igor Mammedov
2018-12-21 9:03 ` [Qemu-devel] [PATCH v7 12/28] compat: replace PC_COMPAT_2_8 & HW_COMPAT_2_8 macros Marc-André Lureau
2018-12-21 12:58 ` Cornelia Huck
2018-12-27 6:45 ` Igor Mammedov
2018-12-21 9:03 ` [Qemu-devel] [PATCH v7 13/28] compat: replace PC_COMPAT_2_7 & HW_COMPAT_2_7 macros Marc-André Lureau
2018-12-21 13:00 ` Cornelia Huck
2018-12-27 6:47 ` Igor Mammedov
2018-12-21 9:03 ` [Qemu-devel] [PATCH v7 14/28] compat: replace PC_COMPAT_2_6 & HW_COMPAT_2_6 macros Marc-André Lureau
2018-12-21 13:03 ` Cornelia Huck
2018-12-27 6:48 ` Igor Mammedov
2018-12-21 9:03 ` [Qemu-devel] [PATCH v7 15/28] compat: replace PC_COMPAT_2_5 & HW_COMPAT_2_5 macros Marc-André Lureau
2018-12-21 13:04 ` Cornelia Huck
2018-12-27 6:50 ` Igor Mammedov
2018-12-21 9:03 ` [Qemu-devel] [PATCH v7 16/28] compat: replace PC_COMPAT_2_4 & HW_COMPAT_2_4 macros Marc-André Lureau
2018-12-21 13:05 ` Cornelia Huck
2018-12-27 6:51 ` Igor Mammedov
2018-12-21 9:03 ` [Qemu-devel] [PATCH v7 17/28] compat: replace PC_COMPAT_2_3 & HW_COMPAT_2_3 macros Marc-André Lureau
2018-12-21 13:07 ` Cornelia Huck
2018-12-27 6:52 ` Igor Mammedov
2018-12-21 9:04 ` [Qemu-devel] [PATCH v7 18/28] compat: replace PC_COMPAT_2_2 & HW_COMPAT_2_2 macros Marc-André Lureau
2018-12-21 13:08 ` Cornelia Huck [this message]
2018-12-27 6:53 ` Igor Mammedov
2018-12-21 9:04 ` [Qemu-devel] [PATCH v7 19/28] compat: replace PC_COMPAT_2_1 & HW_COMPAT_2_1 macros Marc-André Lureau
2018-12-21 13:09 ` Cornelia Huck
2018-12-27 6:54 ` Igor Mammedov
2018-12-21 9:04 ` [Qemu-devel] [PATCH v7 20/28] include: remove compat.h Marc-André Lureau
2018-12-21 13:10 ` Cornelia Huck
2018-12-27 6:56 ` Igor Mammedov
2018-12-21 9:04 ` [Qemu-devel] [PATCH v7 21/28] compat: remove remaining PC_COMPAT macros Marc-André Lureau
2018-12-21 13:12 ` Cornelia Huck
2018-12-27 6:58 ` Igor Mammedov
2018-12-21 9:04 ` [Qemu-devel] [PATCH v7 22/28] qdev: make a separate helper function to apply compat properties Marc-André Lureau
2018-12-21 14:38 ` Igor Mammedov
2018-12-21 15:25 ` Cornelia Huck
2018-12-21 9:04 ` [Qemu-devel] [PATCH v7 23/28] qdev: all globals are now user-provided Marc-André Lureau
2018-12-21 15:26 ` Cornelia Huck
2018-12-21 9:04 ` [Qemu-devel] [PATCH v7 24/28] qdev-props: convert global_props to GPtrArray Marc-André Lureau
2018-12-21 15:28 ` Cornelia Huck
2018-12-21 9:04 ` [Qemu-devel] [PATCH v7 25/28] qdev-props: remove errp from GlobalProperty Marc-André Lureau
2018-12-21 15:34 ` Cornelia Huck
2019-01-04 10:57 ` Marc-André Lureau
2019-01-04 11:04 ` Cornelia Huck
2018-12-21 9:04 ` [Qemu-devel] [PATCH v7 26/28] qdev-props: call object_apply_global_props() Marc-André Lureau
2018-12-21 15:35 ` Cornelia Huck
2018-12-21 9:04 ` [Qemu-devel] [PATCH v7 27/28] arm: replace instance_post_init() Marc-André Lureau
2018-12-21 9:04 ` [Qemu-devel] [PATCH v7 28/28] hostmem: use object id for memory region name with >= 4.0 Marc-André Lureau
2019-01-04 11:42 ` [Qemu-devel] [PATCH v7 00/28] Generalize machine compatibility properties Marc-André Lureau
2019-01-04 16:16 ` Eduardo Habkost
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181221140838.3240174f.cohuck@redhat.com \
--to=cohuck@redhat.com \
--cc=ehabkost@redhat.com \
--cc=imammedo@redhat.com \
--cc=marcandre.lureau@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.