From mboxrd@z Thu Jan 1 00:00:00 1970 From: Al Viro Date: Fri, 21 Dec 2018 16:36:54 +0000 Subject: Re: [PATCH] smack: Fix a memory leak in smack_add_opt() Message-Id: <20181221163654.GY2217@ZenIV.linux.org.uk> List-Id: References: <20181221090958.GE2735@kadam> In-Reply-To: <20181221090958.GE2735@kadam> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Dan Carpenter Cc: Casey Schaufler , James Morris , "Serge E. Hallyn" , linux-security-module@vger.kernel.org, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org On Fri, Dec 21, 2018 at 12:09:58PM +0300, Dan Carpenter wrote: > The function is leaking "opts" on the error paths. > > Fixes: 90e3b564ab93 ("smack: take the guts of smack_parse_opts_str() into a new helper") > Signed-off-by: Dan Carpenter D'oh... Applied, thanks for spotting that braino.