Re: Need help fixing pop/click artifacts in an ASOC driver

[Mark Brown <broonie@kernel.org>]

[-- Attachment #1.1: Type: text/plain, Size: 1141 bytes --]

On Fri, Dec 21, 2018 at 03:05:51PM +0200, Dimitris Papavasiliou wrote:

> without pushing the changes upstream.  You can see the patch in
> question here:

> https://github.com/raspberrypi/linux/commit/c53a137bd151130e29d7fc43947ac3e579a29ce4#diff-723fa079c49ec85d48e290fe84994b36

That's a change half implementing TDM modes with the goal of allowing a
bodge to force 32 bit frame sizes where that's required to get clocks to
divide out neatly.

> I can apply the patch via merge, so bothering with this is not at all
> necessary, but if this change is useful, perhaps it's worth submitting
> another patch for it.  I doubt this though, as it looks a bit hackish
> to me.

It's useful (that's a genuine issue) but it shouldn't be bodged by TDM
mode but should instead just be done as standard without the machine
driver needing to do TDM - check if the clock rate required is actually
generated then fall back to a less exact frame if that helps.  That way
everyone gets the benefit without needing custom configuration or code.
Basically it's doing the right thing in terms of configuring the
hardware but should be triggered differently.

[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

[-- Attachment #2: Type: text/plain, Size: 0 bytes --]