From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= Subject: Re: [v4 2/4] drm/i915/icl: Add icl pipe degamma and gamma support Date: Fri, 21 Dec 2018 19:38:35 +0200 Message-ID: <20181221173835.GK20097@intel.com> References: <1545335981-2338-1-git-send-email-uma.shankar@intel.com> <1545335981-2338-3-git-send-email-uma.shankar@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by gabe.freedesktop.org (Postfix) with ESMTPS id 4E0016E117 for ; Fri, 21 Dec 2018 17:38:39 +0000 (UTC) Content-Disposition: inline In-Reply-To: <1545335981-2338-3-git-send-email-uma.shankar@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Uma Shankar Cc: intel-gfx@lists.freedesktop.org, ville.syrjala@intel.com, maarten.lankhorst@intel.com List-Id: intel-gfx@lists.freedesktop.org T24gRnJpLCBEZWMgMjEsIDIwMTggYXQgMDE6Mjk6MzlBTSArMDUzMCwgVW1hIFNoYW5rYXIgd3Jv dGU6Cj4gQWRkIHN1cHBvcnQgZm9yIGljbCBwaXBlIGRlZ2FtbWEgYW5kIGdhbW1hLgo+IAo+IHYy OiBSZW1vdmVkIGEgUE9TVElOR19SRUFEIGFuZCBjb3JyZWN0ZWQgdGhlIEJpdAo+IERlZmluaXRp b24gYXMgcGVyIE1hYXJ0ZW4ncyBjb21tZW50cy4KPiAKPiB2MzogQWRkcmVzc2VkIE1hdHQncyBy ZXZpZXcgY29tbWVudHMuIFJlbW92ZWQgcm13IHBhdHRlcm5zCj4gYXMgc3VnZ2VzdGVkIGJ5IE1h dHQuCj4gCj4gdjQ6IEZpeGVkIE1hdHQncyByZXZpZXcgY29tbWVudHMuCj4gCj4gU2lnbmVkLW9m Zi1ieTogVW1hIFNoYW5rYXIgPHVtYS5zaGFua2FyQGludGVsLmNvbT4KPiAtLS0KPiAgZHJpdmVy cy9ncHUvZHJtL2k5MTUvaTkxNV9yZWcuaCAgICB8ICAzICsrCj4gIGRyaXZlcnMvZ3B1L2RybS9p OTE1L2ludGVsX2NvbG9yLmMgfCA2NyArKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysr KysrKwo+ICAyIGZpbGVzIGNoYW5nZWQsIDcwIGluc2VydGlvbnMoKykKPiAKPiBkaWZmIC0tZ2l0 IGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9yZWcuaCBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1 L2k5MTVfcmVnLmgKPiBpbmRleCAwMmFmOWI1Li4xODUyYzMzIDEwMDY0NAo+IC0tLSBhL2RyaXZl cnMvZ3B1L2RybS9pOTE1L2k5MTVfcmVnLmgKPiArKysgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9p OTE1X3JlZy5oCj4gQEAgLTcwOTIsNiArNzA5Miw5IEBAIGVudW0gewo+ICAjZGVmaW5lIEdBTU1B X01PREVfTU9ERV8xMkJJVAkoMiA8PCAwKQo+ICAjZGVmaW5lIEdBTU1BX01PREVfTU9ERV9TUExJ VAkoMyA8PCAwKQo+ICAKPiArI2RlZmluZQlQUkVfQ1NDX0dBTU1BX0VOQUJMRQkoMSA8PCAzMSkK PiArI2RlZmluZQlQT1NUX0NTQ19HQU1NQV9FTkFCTEUJKDEgPDwgMzApCj4gKwo+ICAvKiBETUMv Q1NSICovCj4gICNkZWZpbmUgQ1NSX1BST0dSQU0oaSkJCV9NTUlPKDB4ODAwMDAgKyAoaSkgKiA0 KQo+ICAjZGVmaW5lIENTUl9TU1BfQkFTRV9BRERSX0dFTjkJMHgwMDAwMkZDMAo+IGRpZmYgLS1n aXQgYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9jb2xvci5jIGIvZHJpdmVycy9ncHUvZHJt L2k5MTUvaW50ZWxfY29sb3IuYwo+IGluZGV4IGYzMmU0YTcuLmU3MmQ4ZDYgMTAwNjQ0Cj4gLS0t IGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfY29sb3IuYwo+ICsrKyBiL2RyaXZlcnMvZ3B1 L2RybS9pOTE1L2ludGVsX2NvbG9yLmMKPiBAQCAtNTM0LDYgKzUzNCw3MSBAQCBzdGF0aWMgdm9p ZCBnbGtfbG9hZF9sdXRzKHN0cnVjdCBpbnRlbF9jcnRjX3N0YXRlICpjcnRjX3N0YXRlKQo+ICAJ UE9TVElOR19SRUFEKEdBTU1BX01PREUocGlwZSkpOwo+ICB9Cj4gIAo+ICtzdGF0aWMgdm9pZCBp Y2xfbG9hZF9kZWdhbW1hX2x1dChzdHJ1Y3QgaW50ZWxfY3J0Y19zdGF0ZSAqY3J0Y19zdGF0ZSkK PiArewo+ICsJc3RydWN0IGRybV9kZXZpY2UgKmRldiA9IGNydGNfc3RhdGUtPmJhc2UuY3J0Yy0+ ZGV2Owo+ICsJc3RydWN0IGRybV9pOTE1X3ByaXZhdGUgKmRldl9wcml2ID0gdG9faTkxNShkZXYp Owo+ICsJZW51bSBwaXBlIHBpcGUgPSB0b19pbnRlbF9jcnRjKGNydGNfc3RhdGUtPmJhc2UuY3J0 YyktPnBpcGU7Cj4gKwljb25zdCB1aW50MzJfdCBsdXRfc2l6ZSA9IElOVEVMX0lORk8oZGV2X3By aXYpLT5jb2xvci5kZWdhbW1hX2x1dF9zaXplOwo+ICsJdWludDMyX3QgaTsKPiArCj4gKwkvKgo+ ICsJICogV2hlbiBzZXR0aW5nIHRoZSBhdXRvLWluY3JlbWVudCBiaXQsIHRoZSBoYXJkd2FyZSBz ZWVtcyB0bwo+ICsJICogaWdub3JlIHRoZSBpbmRleCBiaXRzLCBzbyB3ZSBuZWVkIHRvIHJlc2V0 IGl0IHRvIGluZGV4IDAKPiArCSAqIHNlcGFyYXRlbHkuCj4gKwkgKi8KPiArCUk5MTVfV1JJVEUo UFJFX0NTQ19HQU1DX0lOREVYKHBpcGUpLCAwKTsKPiArCUk5MTVfV1JJVEUoUFJFX0NTQ19HQU1D X0lOREVYKHBpcGUpLCBQUkVfQ1NDX0dBTUNfQVVUT19JTkNSRU1FTlQpOwo+ICsKPiArCWlmIChj cnRjX3N0YXRlLT5iYXNlLmRlZ2FtbWFfbHV0KSB7Cj4gKwkJc3RydWN0IGRybV9jb2xvcl9sdXQg Kmx1dCA9IGNydGNfc3RhdGUtPmJhc2UuZGVnYW1tYV9sdXQtPmRhdGE7Cj4gKwo+ICsJCWZvciAo aSA9IDA7IGkgPCBsdXRfc2l6ZTsgaSsrKSB7Cj4gKwkJCS8qCj4gKwkJCSAqIEZpcnN0IDMzIGVu dHJpZXMgcmVwcmVzZW50IHJhbmdlIGZyb20gMCB0byAxLjAKPiArCQkJICogMzR0aCBhbmQgMzV0 aCBlbnRyeSB3aWxsIHJlcHJlc2VudCBleHRlbmRlZCByYW5nZQo+ICsJCQkgKiBpbnB1dHMgMy4w IGFuZCA3LjAgcmVzcGVjdGl2ZWx5LCBjdXJyZW50bHkgY2xhbXBlZAo+ICsJCQkgKiBhdCAxLjAu IFNpbmNlIHRoZSBwcmVjaXNpb24gaXMgMTZiaXQsIHRoZSB1c2VyIHZhbHVlCj4gKwkJCSAqIGNh biBiZSBkaXJlY3RseSBmaWxsZWQgdG8gcmVnaXN0ZXIuCj4gKwkJCSAqIFRvRG86IEV4dGVuZCB0 byBtYXggNy4wLgo+ICsJCQkgKi8KPiArCQkJSTkxNV9XUklURShQUkVfQ1NDX0dBTUNfREFUQShw aXBlKSwgbHV0W2ldLnJlZCk7CgpyZWQ/IEkgd291bGQgaGF2ZSBnb25lIGZvciBncmVlbi4KCj4g KwkJfQo+ICsJfSBlbHNlIHsKPiArCQkvKiBsb2FkIGEgbGluZWFyIHRhYmxlLiAqLwo+ICsJCWZv ciAoaSA9IDA7IGkgPCBsdXRfc2l6ZTsgaSsrKSB7Cj4gKwkJCXVpbnQzMl90IHYgPSAoaSAqICgx IDw8IDE2KSkgLyAobHV0X3NpemUgLSAxKTsKPiArCj4gKwkJCUk5MTVfV1JJVEUoUFJFX0NTQ19H QU1DX0RBVEEocGlwZSksIHYpOwo+ICsJCX0KPiArCX0KPiArCj4gKwkvKiBDbGFtcCB2YWx1ZXMg PiAxLjAuICovCj4gKwl3aGlsZSAoaSsrIDwgMzUpCj4gKwkJSTkxNV9XUklURShQUkVfQ1NDX0dB TUNfREFUQShwaXBlKSwgKDEgPDwgMTYpKTsKClRoaXMgaXMgdGhlIGdsaysgZGVnYW1tYSBsdXQg aXMgaXQgbm90PyBXaHkgaXMgdGhpcyBjb2RlIApwcmV0ZW5kaW5nIHRvIGJlIGljbCsgb25seT8K CklNTyBzdGVwIDEgc2hvdWxkIGJlIHRvIGp1c3QgcmV1c2UgdGhlIGN1cnJlbnQgZ2xrIGNvZGUg Zm9yIGljbC4KV2hpY2ggSSB0aGluayBib2lscyBkb3duIHRvIGp1c3Qgc2V0dGluZyB0aGUgY29y cmVjdCBiaXQocykgaW4KR0FNTUFfTU9ERS4gQWZ0ZXIgdGhhdCB3ZSBjYW4gdGhpbmsgb2YgZXh0 ZW5kaW5nIGl0IHRvIHN1cHBvcnQKdXNlciBwcm92aWRlZCBkZWdhbW1hLiAKClRoZXJlIGlzIGEg Yml0IG9mIGEgcHJvYmxlbSB3aXRoIHRoYXQgb24gZ2xrL2NubCB0aG91Z2gKc2luY2Ugd2UgZG9u J3QgaGF2ZSB0aGUgb3V0cHV0IGNzYy4gSGVuY2Ugd2hlbiB0aGUgcGlwZSBjc2MKaXMgdXNlZCB3 ZSBuZWVkIHRvIGVpdGhlciByZWplY3QgZ2FtbWEgKHdoaWNoIGRvZXNuJ3Qgc291bmQgCnZlcnkg cHJvbmUgdG8gd29yayB3aXRoIGxlZ2FjeSB1c2Vyc3BhY2UpIG9yIHdlIHByb2dyYW0gdGhlCmRl Z2FtbWEgTFVUIHdpdGggdGhlIGRhdGEgbWVhbnQgZm9yIHRoZSBnYW1tYSBMVVQgd2hpY2ggaGFz Cml0cyBvd24gcHJvYmxlbXMuCgo+ICt9Cj4gKwo+ICtzdGF0aWMgdm9pZCBpY2xfbG9hZF9sdXRz KHN0cnVjdCBpbnRlbF9jcnRjX3N0YXRlICpjcnRjX3N0YXRlKQo+ICt7Cj4gKwlzdHJ1Y3QgZHJt X2NydGMgKmNydGMgPSBjcnRjX3N0YXRlLT5iYXNlLmNydGM7Cj4gKwlzdHJ1Y3QgZHJtX2Rldmlj ZSAqZGV2ID0gY3J0Y19zdGF0ZS0+YmFzZS5jcnRjLT5kZXY7Cj4gKwlzdHJ1Y3QgZHJtX2k5MTVf cHJpdmF0ZSAqZGV2X3ByaXYgPSB0b19pOTE1KGRldik7Cj4gKwllbnVtIHBpcGUgcGlwZSA9IHRv X2ludGVsX2NydGMoY3J0YyktPnBpcGU7Cj4gKwl1MzIgZ2FtbWFfbW9kZSA9IDA7Cj4gKwo+ICsJ aWYgKGNydGNfc3RhdGVfaXNfbGVnYWN5X2dhbW1hKGNydGNfc3RhdGUpKSB7Cj4gKwkJaGFzd2Vs bF9sb2FkX2x1dHMoY3J0Y19zdGF0ZSk7Cj4gKwkJcmV0dXJuOwo+ICsJfQo+ICsKPiArCWljbF9s b2FkX2RlZ2FtbWFfbHV0KGNydGNfc3RhdGUpOwo+ICsJYmR3X2xvYWRfZ2FtbWFfbHV0KGNydGNf c3RhdGUsIDApOwo+ICsKPiArCWdhbW1hX21vZGUgPSBHQU1NQV9NT0RFX01PREVfMTBCSVQgfCBQ UkVfQ1NDX0dBTU1BX0VOQUJMRQo+ICsJCQl8IFBPU1RfQ1NDX0dBTU1BX0VOQUJMRTsKPiArCUk5 MTVfV1JJVEUoR0FNTUFfTU9ERShwaXBlKSwgZ2FtbWFfbW9kZSk7Cj4gK30KPiArCj4gIC8qIExv YWRzIHRoZSBwYWxldHRlL2dhbW1hIHVuaXQgZm9yIHRoZSBDUlRDIG9uIENoZXJyeVZpZXcuICov Cj4gIHN0YXRpYyB2b2lkIGNoZXJyeXZpZXdfbG9hZF9sdXRzKHN0cnVjdCBpbnRlbF9jcnRjX3N0 YXRlICpjcnRjX3N0YXRlKQo+ICB7Cj4gQEAgLTY0OSw2ICs3MTQsOCBAQCB2b2lkIGludGVsX2Nv bG9yX2luaXQoc3RydWN0IGludGVsX2NydGMgKmNydGMpCj4gIAl9IGVsc2UgaWYgKElTX0dFTUlO SUxBS0UoZGV2X3ByaXYpIHx8IElTX0NBTk5PTkxBS0UoZGV2X3ByaXYpKSB7Cj4gIAkJZGV2X3By aXYtPmRpc3BsYXkubG9hZF9jc2NfbWF0cml4ID0gaWxrX2xvYWRfY3NjX21hdHJpeDsKPiAgCQlk ZXZfcHJpdi0+ZGlzcGxheS5sb2FkX2x1dHMgPSBnbGtfbG9hZF9sdXRzOwo+ICsJfSBlbHNlIGlm IChJU19JQ0VMQUtFKGRldl9wcml2KSkgewo+ICsJCWRldl9wcml2LT5kaXNwbGF5LmxvYWRfbHV0 cyA9IGljbF9sb2FkX2x1dHM7Cj4gIAl9IGVsc2Ugewo+ICAJCWRldl9wcml2LT5kaXNwbGF5Lmxv YWRfbHV0cyA9IGk5eHhfbG9hZF9sdXRzOwo+ICAJfQo+IC0tIAo+IDEuOS4xCj4gCj4gX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KPiBJbnRlbC1nZnggbWFp bGluZyBsaXN0Cj4gSW50ZWwtZ2Z4QGxpc3RzLmZyZWVkZXNrdG9wLm9yZwo+IGh0dHBzOi8vbGlz dHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vaW50ZWwtZ2Z4CgotLSAKVmlsbGUg U3lyasOkbMOkCkludGVsCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fCkludGVsLWdmeCBtYWlsaW5nIGxpc3QKSW50ZWwtZ2Z4QGxpc3RzLmZyZWVkZXNrdG9w Lm9yZwpodHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2ludGVs LWdmeAo=