From: Steven Rostedt <rostedt@goodmis.org>
To: Namhyung Kim <namhyung@kernel.org>
Cc: LKML <linux-kernel@vger.kernel.org>,
Linus Torvalds <torvalds@linux-foundation.org>,
Ingo Molnar <mingo@kernel.org>,
Andrew Morton <akpm@linux-foundation.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Joe Perches <joe@perches.com>,
Masami Hiramatsu <mhiramat@kernel.org>,
Tom Zanussi <zanussi@kernel.org>,
Andreas Schwab <schwab@linux-m68k.org>,
kernel-team@lge.com
Subject: Re: [PATCH v4] string.h: Add str_has_prefix() helper function
Date: Sat, 22 Dec 2018 10:12:44 -0500 [thread overview]
Message-ID: <20181222101244.7da017c9@vmware.local.home> (raw)
In-Reply-To: <20181222142411.GA10058@danjae.aot.lge.com>
On Sat, 22 Dec 2018 23:24:11 +0900
Namhyung Kim <namhyung@kernel.org> wrote:
> > No, because we don't know the length of str.
> >
> >
> > [ str = "h\0[bad memory]" ]
> >
> >
> > str_has_prefix(str, "TEST THIS BIG STRING AT FRONT")
> >
> >
> > If we use memcmp(), then we are testing way after str has ended, and
> > that can cause a memory fault.
>
> I don't know what's the bad memory causing memory fault but anyway
> memcpy() should stop at the NUL character first as it's different, no?
No, that's the difference between memcpy() and strncpy(), memcpy()
doesn't care about nul characters. It's copying memory not strings.
-- Steve
next prev parent reply other threads:[~2018-12-22 17:47 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-22 4:19 [PATCH v4] string.h: Add str_has_prefix() helper function Steven Rostedt
2018-12-22 4:42 ` Steven Rostedt
2018-12-22 9:33 ` Namhyung Kim
2018-12-22 12:24 ` Steven Rostedt
2018-12-22 14:24 ` Namhyung Kim
2018-12-22 15:12 ` Steven Rostedt [this message]
2018-12-22 16:16 ` Steven Rostedt
2018-12-22 16:46 ` Namhyung Kim
2018-12-22 17:19 ` Steven Rostedt
2018-12-22 17:23 ` Steven Rostedt
2018-12-22 17:24 ` Steven Rostedt
2018-12-23 3:13 ` Namhyung Kim
2018-12-23 3:23 ` Steven Rostedt
2018-12-23 3:05 ` Namhyung Kim
2019-01-11 8:10 ` [utility perl script] strncmp() -> str_has_prefix() conversions Joe Perches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181222101244.7da017c9@vmware.local.home \
--to=rostedt@goodmis.org \
--cc=akpm@linux-foundation.org \
--cc=gregkh@linuxfoundation.org \
--cc=joe@perches.com \
--cc=kernel-team@lge.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mhiramat@kernel.org \
--cc=mingo@kernel.org \
--cc=namhyung@kernel.org \
--cc=schwab@linux-m68k.org \
--cc=torvalds@linux-foundation.org \
--cc=zanussi@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.