From: Stephen Hemminger <stephen@networkplumber.org>
To: Haiyang Tan <haiyangtan@tencent.com>
Cc: Cristian Dumitrescu <cristian.dumitrescu@intel.com>, dev@dpdk.org
Subject: Re: [PATCH] hash: fix possible uninitialized variable
Date: Sat, 22 Dec 2018 23:43:50 -0800 [thread overview]
Message-ID: <20181222234350.789e2a28@xeon-e3> (raw)
In-Reply-To: <20181222121100.52827-1-haiyangtan@tencent.com>
On Sat, 22 Dec 2018 04:10:59 -0800
Haiyang Tan <haiyangtan@tencent.com> wrote:
> The uninitialized field 'extra_flag' of hash_cuckoo_params may enable
> certain feature silently. Typically, if bit0 of 'extra_flag' set, the
> hardware transactional memory support will be enabled unexpectedly.
>
> Signed-off-by: Haiyang Tan <haiyangtan@tencent.com>
This is not necessary. Structure initializations will fill in the other
elements with zero.
https://gcc.gnu.org/onlinedocs/gcc-4.9.0/gcc/Designated-Inits.html
Omitted field members are implicitly initialized the same as objects that have static storage duration.
next prev parent reply other threads:[~2018-12-23 7:43 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-22 12:10 [PATCH] hash: fix possible uninitialized variable Haiyang Tan
2018-12-23 7:43 ` Stephen Hemminger [this message]
2018-12-24 10:30 ` Dumitrescu, Cristian
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181222234350.789e2a28@xeon-e3 \
--to=stephen@networkplumber.org \
--cc=cristian.dumitrescu@intel.com \
--cc=dev@dpdk.org \
--cc=haiyangtan@tencent.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.