From mboxrd@z Thu Jan 1 00:00:00 1970 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Subject: smsc95xx: Add support for automated PHY address detection From: Andrew Lunn Message-Id: <20181223102329.GA32178@lunn.ch> Date: Sun, 23 Dec 2018 11:23:29 +0100 To: Marek Vasut Cc: linux-usb@vger.kernel.org, "David S . Miller" , Nisar Sayed , Woojung Huh , netdev , Florian Fainelli List-ID: PiA+ICtzdGF0aWMgaW50IHNtc2M5NXh4X3BoeV9hZGRyZXNzKHN0cnVjdCB1c2JuZXQgKmRldikK PiA+ICt7Cj4gPiArCXUzMiByZWFkX2J1ZjsKPiA+ICsJaW50IHJldCwgaWQxLCBpZDIsIHBoeWFk Owo+ID4gKwo+ID4gKwlyZXQgPSBzbXNjOTV4eF9yZWFkX3JlZyhkZXYsIEhXX0NGRywgJnJlYWRf YnVmKTsKPiA+ICsJaWYgKHJldCA8IDApCj4gPiArCQlyZXR1cm4gcmV0Owo+ID4gKwo+ID4gKwkv KiBDaGVjayBpZiB1c2luZyBleHRlcm5hbCBQSFksIGlmIG5vdCwgdXNlIGludGVybmFsIFBIWSBh ZGRyZXNzICovCj4gPiArCWlmICghKHJlYWRfYnVmICYgSFdfQ0ZHX1BTRUxfKSkKPiA+ICsJCXJl dHVybiBTTVNDOTVYWF9JTlRFUk5BTF9QSFlfSUQ7Cj4gPiArCj4gPiArCS8qCj4gPiArCSAqIERl dGVjdCBleHRlcm5hbCBQSFkgYWRkcmVzcy4gSGVyZSB3ZSBwcm9iZSB0aGUgTURJTyBidXMgZnJv bQo+ID4gKwkgKiB0aGUgaGlnaGVzdCBhZGRyZXNzLCBzaW5jZSBzb21lIFBIWXMgcmVzcG9uZCBh bHNvIG9uIGFkZHJlc3MKPiA+ICsJICogemVybywgd2hpY2ggdGhleSBjb25zaWRlciBNRElPIGJy b2FkY2FzdCBhZGRyZXNzLiBXZSByZWFsbHkKPiA+ICsJICogd2FudCB0byBnZXQgdGhlaXIgcHJv cGVyIGFkZHJlc3MgaW5zdGVhZCB0aG91Z2gsIHNvIHdlIHNjYW4KPiA+ICsJICogYWRkcmVzcyB6 ZXJvIGxhc3QuCj4gPiArCSAqLwo+ID4gKwlmb3IgKHBoeWFkID0gMHgxZjsgcGh5YWQgPj0gMDsg cGh5YWQtLSkgewo+ID4gKwkJaWQxID0gc21zYzk1eHhfbWRpb19yZWFkKGRldi0+bmV0LCBwaHlh ZCwgTUlJX1BIWVNJRDEpOwo+ID4gKwkJaWQyID0gc21zYzk1eHhfbWRpb19yZWFkKGRldi0+bmV0 LCBwaHlhZCwgTUlJX1BIWVNJRDIpOwo+ID4gKwkJLyogQ2hlY2sgZm9yIHZhbGlkIHJlc3BvbnNl IGZyb20gdGhlIFBIWSAqLwo+ID4gKwkJaWYgKGlkMSA+IDAgJiYgaWQyID4gMCAmJiBpZDEgIT0g MHg3ZmZmICYmIGlkMiAhPSAweGZmZmYpCj4gPiArCQkJcmV0dXJuIHBoeWFkOwo+ID4gKwl9CgpU aGlzIHdvdWxkIGJlIHNvIG11Y2ggZWFzaWVyIGlmIHRoZSBkcml2ZXIgdXNlZCB0aGUgY29yZSBt ZGlvL3BoeQpjb2RlLiBKdXN0IHNldCBtZGlvLT5waHlfbWFzayB0byB+QklUKDApIGFuZCB0aGVu IHVzZQpwaHlfZmluZF9maXJzdCgpLgoKQW55d2F5LCBuZXQgaXMgY2xvc2VkIGF0IHRoZSBtb21l bnQsIHNvIHBsZWFzZSByZXBvc3QgaW4gdGhyZWUgd2Vla3MKdGltZS4KCglBbmRyZXcK From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andrew Lunn Subject: Re: [PATCH] smsc95xx: Add support for automated PHY address detection Date: Sun, 23 Dec 2018 11:23:29 +0100 Message-ID: <20181223102329.GA32178@lunn.ch> References: <20180911101223.4217-1-marex@denx.de> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: linux-usb@vger.kernel.org, "David S . Miller" , Nisar Sayed , Woojung Huh , netdev , Florian Fainelli To: Marek Vasut Return-path: Received: from vps0.lunn.ch ([185.16.172.187]:56111 "EHLO vps0.lunn.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725886AbeLWKXe (ORCPT ); Sun, 23 Dec 2018 05:23:34 -0500 Content-Disposition: inline In-Reply-To: Sender: netdev-owner@vger.kernel.org List-ID: > > +static int smsc95xx_phy_address(struct usbnet *dev) > > +{ > > + u32 read_buf; > > + int ret, id1, id2, phyad; > > + > > + ret = smsc95xx_read_reg(dev, HW_CFG, &read_buf); > > + if (ret < 0) > > + return ret; > > + > > + /* Check if using external PHY, if not, use internal PHY address */ > > + if (!(read_buf & HW_CFG_PSEL_)) > > + return SMSC95XX_INTERNAL_PHY_ID; > > + > > + /* > > + * Detect external PHY address. Here we probe the MDIO bus from > > + * the highest address, since some PHYs respond also on address > > + * zero, which they consider MDIO broadcast address. We really > > + * want to get their proper address instead though, so we scan > > + * address zero last. > > + */ > > + for (phyad = 0x1f; phyad >= 0; phyad--) { > > + id1 = smsc95xx_mdio_read(dev->net, phyad, MII_PHYSID1); > > + id2 = smsc95xx_mdio_read(dev->net, phyad, MII_PHYSID2); > > + /* Check for valid response from the PHY */ > > + if (id1 > 0 && id2 > 0 && id1 != 0x7fff && id2 != 0xffff) > > + return phyad; > > + } This would be so much easier if the driver used the core mdio/phy code. Just set mdio->phy_mask to ~BIT(0) and then use phy_find_first(). Anyway, net is closed at the moment, so please repost in three weeks time. Andrew