From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.6 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS, USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AC9E6C43387 for ; Sun, 23 Dec 2018 16:28:42 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 6BDCB21920 for ; Sun, 23 Dec 2018 16:28:42 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=kroah.com header.i=@kroah.com header.b="cuj1n7Z5"; dkim=pass (2048-bit key) header.d=messagingengine.com header.i=@messagingengine.com header.b="xqwu95ld" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727064AbeLWQ2l (ORCPT ); Sun, 23 Dec 2018 11:28:41 -0500 Received: from new4-smtp.messagingengine.com ([66.111.4.230]:48299 "EHLO new4-smtp.messagingengine.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725837AbeLWQ2l (ORCPT ); Sun, 23 Dec 2018 11:28:41 -0500 Received: from compute6.internal (compute6.nyi.internal [10.202.2.46]) by mailnew.nyi.internal (Postfix) with ESMTP id B5A2B5CC7; Sun, 23 Dec 2018 11:28:38 -0500 (EST) Received: from mailfrontend1 ([10.202.2.162]) by compute6.internal (MEProxy); Sun, 23 Dec 2018 11:28:38 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kroah.com; h= date:from:to:cc:subject:message-id:references:mime-version :content-type:in-reply-to; s=fm2; bh=CWNNxg/4j0QNYujHcqsYXKDzP9W PqiX2KCu2eVKFs8E=; b=cuj1n7Z5MjeRtGcxDzz5jqoGSzGPReaC2LkF/6EppnQ oD9IShUqP1Din7Zv7n0S6yNQM+cORwBlRXYuSJKXJ8LdibDnFtFlWFm05dryxgv0 /R2DZ8oevNqupkwJIjQ1wc/UhdCAfz2e8So+1QU3Xpcg4si9pKAaHnZm679FpzZQ C8kfWBrTewuMca+QLpqfIxOx4rMLtDulvURkU8FJw7/W33Uw6+S4VWwvq93XUHFw pwTlEqoat7eHaFemj6IPH9/2tp44JgDIBFGE3R8h0RjxNxLhA/X76D5GprXLX2Vc 6O0Dh+AzrgGqFP04cgRJ91YXEPNWVhYnEnUHHhZ/Diw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm1; bh=CWNNxg /4j0QNYujHcqsYXKDzP9WPqiX2KCu2eVKFs8E=; b=xqwu95ldo9w8TE8A6rgADA RH40rQDTXDYuLMwmei+a8wUTGXxOK13Xs2yyCFQy7xK6R1acrCo669IDfyhGNghO SDHvhPFdIZ08oKtzLCfAkx1D5ITdPsk0Ahq0oZUqLDDUAOLaaZHmAv5qC0PNDAnK 7ZRn4E8XWFekkn1d7JjQ0UrPX6sK+S98JOkqm0ETwTrsm20Nu0zt5O76SCUATnUx 9Jt/CrrjlkiE9hHngXe/m8xzQ/pp7k5XNzfITqhBe2uZ37j6lNbB3TjCirEMjXny zxsYa3zWxpWPV4vCB1IzP+sDkEST0jH1YqEKGBDX1hTrjmmm7qolgtktJ3ee1m3w == X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedtkedrudejledgledtucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfquhhtnecuuegrihhlohhuthemucef tddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenogfuphgrmhfkphculdeftd dtmdenucfjughrpeffhffvuffkfhggtggujggfsehttdertddtredvnecuhfhrohhmpefi rhgvghcumffjuceoghhrvghgsehkrhhorghhrdgtohhmqeenucfkphepkeefrdekiedrke elrddutdejnecurfgrrhgrmhepmhgrihhlfhhrohhmpehgrhgvgheskhhrohgrhhdrtgho mhenucevlhhushhtvghrufhiiigvpedt X-ME-Proxy: Received: from localhost (5356596b.cm-6-7b.dynamic.ziggo.nl [83.86.89.107]) by mail.messagingengine.com (Postfix) with ESMTPA id D1657E40E1; Sun, 23 Dec 2018 11:28:37 -0500 (EST) Date: Sun, 23 Dec 2018 17:28:36 +0100 From: Greg KH To: Eric Blau Cc: stable@vger.kernel.org Subject: Re: [regression] USB power management failure to suspend / high CPU usage Message-ID: <20181223162836.GA1035@kroah.com> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.11.1 (2018-12-01) Sender: stable-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org On Sun, Dec 23, 2018 at 08:49:42AM -0500, Eric Blau wrote: > Hi folks, > > I noticed a regression introduced sometime after 4.19.4 in USB power > management. I have a 2015 MacBook Pro. When I try to do a suspend or a > suspend+hibernate, I get the following error messages trying to > suspend usb2 and the suspend fails. This works fine in 4.19.4: > > Dec 22 13:50:36 eric-macbookpro kernel: Freezing remaining freezable > tasks ... (elapsed 0.001 seconds) done. > Dec 22 13:50:36 eric-macbookpro kernel: Suspending console(s) (use > no_console_suspend to debug) > Dec 22 13:50:36 eric-macbookpro kernel: dpm_run_callback(): > usb_dev_freeze+0x0/0x10 returns -16 > Dec 22 13:50:36 eric-macbookpro kernel: PM: Device usb2 failed to > freeze async: error -16 > Dec 22 13:50:38 eric-macbookpro systemd[1]: > systemd-hybrid-sleep.service: Main process exited, code=exited, > status=1/FAILURE > Dec 22 13:50:38 eric-macbookpro systemd[1]: > systemd-hybrid-sleep.service: Failed with result 'exit-code'. > Dec 22 13:50:38 eric-macbookpro systemd[1]: Failed to start Hybrid > Suspend+Hibernate. > Dec 22 13:50:38 eric-macbookpro systemd[1]: Dependency failed for > Hybrid Suspend+Hibernate. > Dec 22 13:50:38 eric-macbookpro systemd[1]: hybrid-sleep.target: Job > hybrid-sleep.target/start failed with result 'dependency'. > Dec 22 13:50:38 eric-macbookpro systemd-logind[1573]: Operation > 'sleep' finished. > Dec 22 13:50:38 eric-macbookpro systemd[1]: Stopped target Sleep. > > The behavior exists in 4.19.8 and 4.19.11, the kernel versions I have > upgraded to with Arch Linux, so the regression was introduced sometime > between 4.19.4 and 4.19.8. Hibernate still works but when I resume > from hibernate, there is a ksoftirqd and kworker thread/process > together taking up 100% of one core. If I turn off auto power control > for usb1 and usb2, the threads stop spinning. i.e., > > echo 'on' > '/sys/bus/usb/devices/usb1/power/control > > Any suggestions as to where this regression was introduced and what > can be done to fix it? Sorry, this is a known issue, will be fixed in the next 4.19 release that should be out next week. If you are curious, it is fixed by commit 45f750c16cae ("xhci: Don't prevent USB2 bus suspend in state check intended for USB3 only") in Linus's tree. thanks, greg k-h