From: Andrew Lunn <andrew@lunn.ch>
To: Heiner Kallweit <hkallweit1@gmail.com>
Cc: Florian Fainelli <f.fainelli@gmail.com>,
David Miller <davem@davemloft.net>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>
Subject: Re: [PATCH net] net: phy: fix phy_init_hw fixup handling
Date: Sun, 23 Dec 2018 18:28:58 +0100 [thread overview]
Message-ID: <20181223172858.GE2791@lunn.ch> (raw)
In-Reply-To: <22637042-a3c0-de58-10a6-cd86a0af976a@gmail.com>
On Sun, Dec 23, 2018 at 06:23:18PM +0100, Heiner Kallweit wrote:
> On 23.12.2018 18:07, Andrew Lunn wrote:
> > On Sun, Dec 23, 2018 at 03:00:26PM +0100, Heiner Kallweit wrote:
> >> Currently we return immediately if callback config_init isn't defined.
> >> This prevents the fixups from being executed. I see no dependency
> >> between fixups and config_init, therefore change the function to
> >> run the fixups also if config_init isn't defined.
> >>
> >> Fixes: 2f5cb43406d0 ("phylib: Properly reinitialize PHYs after hibernation")
> >> Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com>
> >
> > Hi Heiner
> >
> > Is this a real fix? It seems like it has been like this forever. Do
> > you know of a PHY which is actually broken?
> >
> Right, the current behavior has been there forever. I'm not aware of
> any concrete case. I went for "net" because the current code could
> break a device.
Hi Heiner
https://www.kernel.org/doc/html/v4.15/process/stable-kernel-rules.html
The 4th bullet point:
o It must fix a real bug that bothers people (not a, “This could be a
problem...” type thing).
Andrew
next prev parent reply other threads:[~2018-12-23 17:29 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-23 14:00 [PATCH net] net: phy: fix phy_init_hw fixup handling Heiner Kallweit
2018-12-23 17:07 ` Andrew Lunn
2018-12-23 17:23 ` Heiner Kallweit
2018-12-23 17:28 ` Andrew Lunn [this message]
2018-12-23 17:30 ` Heiner Kallweit
2018-12-24 22:23 ` David Miller
2018-12-25 8:30 ` Heiner Kallweit
2018-12-25 15:59 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181223172858.GE2791@lunn.ch \
--to=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=f.fainelli@gmail.com \
--cc=hkallweit1@gmail.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.