All of lore.kernel.org
 help / color / mirror / Atom feed
From: Andrew Lunn <andrew@lunn.ch>
To: Lee Jones <lee.jones@linaro.org>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] mfd: tqmx86: IO controller with i2c, wachdog and gpio
Date: Mon, 24 Dec 2018 11:44:44 +0100	[thread overview]
Message-ID: <20181224104444.GA13866@lunn.ch> (raw)
In-Reply-To: <20181221143505.GQ13248@dell>

On Fri, Dec 21, 2018 at 02:35:05PM +0000, Lee Jones wrote:
> > +	if (ioeic_val) {
> > +		tqmx86_writeb(pld, ioeic_val, TQMX86_IOEIC);
> > +		if (tqmx86_readb(pld, TQMX86_IOEIC) != ioeic_val) {
> > +			dev_warn(pld->dev,
> > +				 "i2c/gpio interrupts not supported.\n");
> > +			gpio_irq = 0;
> > +		}
> > +	}
> > +
> > +	if (pld->info.i2c_type == I2C_KIND_SOFT) {
> > +		ocores_platfom_data.clock_khz = pld->pld_clock;
> > +		devs[i++] = tqmx86_devs[TQMX86_I2C_SOFT];
> > +	}
> 
> See other drivers to see how they handle optional cells.

Hi Lee

Could you give an example driver i can copy. My grep foo is not
finding anything useful.

Thanks
	Andrew

      parent reply	other threads:[~2018-12-24 10:44 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-12-18 16:53 [PATCH v2] mfd: tqmx86: IO controller with i2c, wachdog and gpio Andrew Lunn
2018-12-21 14:35 ` Lee Jones
2018-12-21 17:09   ` Andrew Lunn
2018-12-21 21:28   ` Andrew Lunn
2018-12-24 10:44   ` Andrew Lunn [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20181224104444.GA13866@lunn.ch \
    --to=andrew@lunn.ch \
    --cc=lee.jones@linaro.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.