From: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 1/2] package: pkg-autotools: Add option to run autogen.sh
Date: Mon, 24 Dec 2018 10:59:11 +0100 [thread overview]
Message-ID: <20181224105911.19475421@windsurf.home> (raw)
In-Reply-To: <20181224092159.GA2703@scaer>
Hello,
On Mon, 24 Dec 2018 10:21:59 +0100, Yann E. MORIN wrote:
> On 2018-12-24 00:37 +0200, Vadim Kochan spake thusly:
> > Add $(PKG)_AUTOGEN variable which allows to execute autogen.sh script
> > on pre-configure stage.
>
> I'm not sure we want to have this in the infra. IIRC, we already spoke
> about it in the past, more than once, and the conclusion had always been
> that this was not demed useful.
>
> First, we only have three autotools packages that need that. This is a
> bit on the short lead to turn it into the infra.
>
> Second, we don't want to make it easy to use autogen.sh. We prefer
> developpers to use AUTORECONF=YES instead. Using autogen.sh should be
> a last-resort option.
>
> Thirdly, and lastly, not all packages have autogen.sh, some have it as
> bootstrap.sh, for example Asterisk:
> http://git.asterisk.org/gitweb/?p=asterisk/asterisk.git;a=blob;f=bootstrap.sh
>
> (Note that we don't need to call Asterisk's bootstrap.sh in Buildroot,
> but that is just an example that such scripts are not always named
> autogen.sh.)
>
> So, my opinion is that we should not have it in the infra.
Overall, I agree with you. If we wanted to make this more flexible than
what we have today, I would suggest to allow customizing the command
that it used for autoreconfiguring.
Something like this:
$(2)_AUTORECONF_CMD ?= $(AUTORECONF)
define AUTORECONF_HOOK
@$(call MESSAGE,"Autoreconfiguring")
$(Q)cd $($(PKG)_SRCDIR) && $($(PKG)_AUTORECONF_ENV) $($(PKG)_AUTORECONF_CMD) $($(PKG)_AUTORECONF_OPTS)
endef
One drawback is that having a CMD variable doesn't really match our
typical CMDS pattern.
Best regards,
Thomas
--
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
next prev parent reply other threads:[~2018-12-24 9:59 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-23 22:37 [Buildroot] [PATCH 0/2] package: pkg-autotools: New $(PKG)_AUTOGEN variable Vadim Kochan
2018-12-23 22:37 ` [Buildroot] [PATCH 1/2] package: pkg-autotools: Add option to run autogen.sh Vadim Kochan
2018-12-24 9:21 ` Yann E. MORIN
2018-12-24 9:59 ` Thomas Petazzoni [this message]
2018-12-24 11:22 ` Yann E. MORIN
2018-12-23 22:37 ` [Buildroot] [PATCH 2/2] package: Use $(PKG)_AUTOGEN instead of calling autogen.sh manually Vadim Kochan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181224105911.19475421@windsurf.home \
--to=thomas.petazzoni@bootlin.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.