All of lore.kernel.org
 help / color / mirror / Atom feed
From: AKASHI Takahiro <takahiro.akashi@linaro.org>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 2/5] efi_loader: bootmgr: allow for running a given load option
Date: Tue, 25 Dec 2018 18:44:55 +0900	[thread overview]
Message-ID: <20181225094454.GF14405@linaro.org> (raw)
In-Reply-To: <1b90d5ae-82cd-2462-7fc0-941c55d96f62@suse.de>

On Sun, Dec 23, 2018 at 03:05:42AM +0100, Alexander Graf wrote:
> 
> 
> On 18.12.18 06:02, AKASHI Takahiro wrote:
> > With an extra argument, efi_bootmgr_load() can now load an efi binary
> > based on a "BootXXXX" variable specified.
> > 
> > Signed-off-by: AKASHI Takahiro <takahiro.akashi@linaro.org>
> > ---
> >  cmd/bootefi.c                | 2 +-
> >  include/efi_loader.h         | 3 ++-
> >  lib/efi_loader/efi_bootmgr.c | 9 ++++++++-
> >  3 files changed, 11 insertions(+), 3 deletions(-)
> > 
> > diff --git a/cmd/bootefi.c b/cmd/bootefi.c
> > index 7012d72ab50d..3ebae1cdad08 100644
> > --- a/cmd/bootefi.c
> > +++ b/cmd/bootefi.c
> > @@ -452,7 +452,7 @@ static int do_bootefi_bootmgr_exec(void)
> >  	void *addr;
> >  	efi_status_t r;
> >  
> > -	addr = efi_bootmgr_load(&device_path, &file_path);
> > +	addr = efi_bootmgr_load(-1, &device_path, &file_path);
> 
> Please make the -1 a special #define that is more verbose to readers.
> Something like EFI_BOOTMGR_DEFAULT_ORDER.

OK
Add it to efi_loader.h

-Takahiro Akashi

> 
> Alex

  reply	other threads:[~2018-12-25  9:44 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-12-18  5:02 [U-Boot] [PATCH 0/5] efi_loader: run a specific efi application more easily AKASHI Takahiro
2018-12-18  5:02 ` [U-Boot] [PATCH 1/5] efi_loader: bootmgr: support BootNext and BootCurrent variable behavior AKASHI Takahiro
2018-12-23  2:03   ` Alexander Graf
2018-12-25  9:36     ` AKASHI Takahiro
2018-12-26 21:23       ` Alexander Graf
2018-12-26 21:33         ` Heinrich Schuchardt
2018-12-26 21:41           ` Alexander Graf
2018-12-27  4:58   ` Heinrich Schuchardt
2019-01-07  6:58     ` AKASHI Takahiro
2018-12-18  5:02 ` [U-Boot] [PATCH 2/5] efi_loader: bootmgr: allow for running a given load option AKASHI Takahiro
2018-12-23  2:05   ` Alexander Graf
2018-12-25  9:44     ` AKASHI Takahiro [this message]
2018-12-18  5:02 ` [U-Boot] [PATCH 3/5] cmd: bootefi: carve out fdt parameter handling AKASHI Takahiro
2018-12-23  2:08   ` Alexander Graf
2018-12-25  9:48     ` AKASHI Takahiro
2018-12-18  5:02 ` [U-Boot] [PATCH 4/5] cmd: bootefi: run an EFI application of a specific load option AKASHI Takahiro
2018-12-23  2:15   ` Alexander Graf
2018-12-25  9:56     ` AKASHI Takahiro
2018-12-18  5:02 ` [U-Boot] [PATCH 5/5] cmd: run: add "-e" option to run an EFI application AKASHI Takahiro
2018-12-23  2:19   ` Alexander Graf
2018-12-25 11:29     ` AKASHI Takahiro
2018-12-26 21:24       ` Alexander Graf
2019-01-07  7:40         ` AKASHI Takahiro

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20181225094454.GF14405@linaro.org \
    --to=takahiro.akashi@linaro.org \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.