From: Fei Li <fli@suse.com>
To: qemu-devel@nongnu.org, shirley17fei@gmail.com
Cc: lifei1214@126.com, "Dr . David Alan Gilbert" <dgilbert@redhat.com>
Subject: [Qemu-devel] [PATCH for-4.0 v9 04/16] migration: add more error handling for postcopy_ram_enable_notify
Date: Tue, 25 Dec 2018 22:04:37 +0800 [thread overview]
Message-ID: <20181225140449.15786-5-fli@suse.com> (raw)
In-Reply-To: <20181225140449.15786-1-fli@suse.com>
Call postcopy_ram_incoming_cleanup() to do the cleanup when
postcopy_ram_enable_notify fails. Besides, report the error
message when qemu_ram_foreach_migratable_block() fails.
Cc: Dr. David Alan Gilbert <dgilbert@redhat.com>
Signed-off-by: Fei Li <fli@suse.com>
Reviewed-by: Dr. David Alan Gilbert <dgilbert@redhat.com>
---
migration/postcopy-ram.c | 1 +
migration/savevm.c | 1 +
2 files changed, 2 insertions(+)
diff --git a/migration/postcopy-ram.c b/migration/postcopy-ram.c
index e5c02a32c5..fa09dba534 100644
--- a/migration/postcopy-ram.c
+++ b/migration/postcopy-ram.c
@@ -1117,6 +1117,7 @@ int postcopy_ram_enable_notify(MigrationIncomingState *mis)
/* Mark so that we get notified of accesses to unwritten areas */
if (qemu_ram_foreach_migratable_block(ram_block_enable_notify, mis)) {
+ error_report("ram_block_enable_notify failed");
return -1;
}
diff --git a/migration/savevm.c b/migration/savevm.c
index 9e45fb4f3f..d784e8aa40 100644
--- a/migration/savevm.c
+++ b/migration/savevm.c
@@ -1729,6 +1729,7 @@ static int loadvm_postcopy_handle_listen(MigrationIncomingState *mis)
*/
if (migrate_postcopy_ram()) {
if (postcopy_ram_enable_notify(mis)) {
+ postcopy_ram_incoming_cleanup(mis);
return -1;
}
}
--
2.13.7
next prev parent reply other threads:[~2018-12-25 14:05 UTC|newest]
Thread overview: 74+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-25 14:04 [Qemu-devel] [PATCH for-4.0 v9 00/16] qemu_thread_create: propagate the error to callers to handle Fei Li
2018-12-25 14:04 ` [Qemu-devel] [PATCH for-4.0 v9 01/16] Fix segmentation fault when qemu_signal_init fails Fei Li
2018-12-25 14:04 ` [Qemu-devel] [PATCH for-4.0 v9 02/16] migration: fix the multifd code when receiving less channels Fei Li
2018-12-25 14:04 ` [Qemu-devel] [PATCH for-4.0 v9 03/16] migration: remove unused &local_err parameter in multifd_save_cleanup Fei Li
2019-01-07 16:50 ` Markus Armbruster
2019-01-08 15:58 ` fei
2018-12-25 14:04 ` Fei Li [this message]
2018-12-25 14:04 ` [Qemu-devel] [PATCH for-4.0 v9 05/16] migration: unify error handling for process_incoming_migration_co Fei Li
2019-01-03 11:25 ` Dr. David Alan Gilbert
2019-01-03 13:27 ` Fei Li
2018-12-25 14:04 ` [Qemu-devel] [PATCH for-4.0 v9 06/16] qemu_thread: Make qemu_thread_create() handle errors properly Fei Li
2019-01-07 17:18 ` Markus Armbruster
2019-01-08 15:55 ` fei
2019-01-08 17:07 ` Markus Armbruster
2019-01-09 13:19 ` Fei Li
2019-01-09 14:36 ` Markus Armbruster
2019-01-09 14:42 ` fei
2018-12-25 14:04 ` [Qemu-devel] [PATCH for-4.0 v9 07/16] qemu_thread: supplement error handling for qemu_X_start_vcpu Fei Li
2018-12-25 14:04 ` [Qemu-devel] [PATCH for-4.0 v9 08/16] qemu_thread: supplement error handling for qmp_dump_guest_memory Fei Li
2019-01-07 17:21 ` Markus Armbruster
2019-01-08 16:00 ` fei
2018-12-25 14:04 ` [Qemu-devel] [PATCH for-4.0 v9 09/16] qemu_thread: supplement error handling for pci_edu_realize Fei Li
2019-01-07 17:29 ` Markus Armbruster
2019-01-08 6:14 ` Jiri Slaby
2019-01-08 6:51 ` Peter Xu
2019-01-08 8:43 ` Markus Armbruster
2019-01-10 13:29 ` Fei Li
2019-01-11 2:49 ` Peter Xu
2019-01-11 13:19 ` Fei Li
2019-01-13 15:44 ` Fei Li
2019-01-14 12:36 ` Markus Armbruster
2019-01-14 13:38 ` Fei Li
2019-01-15 12:55 ` Markus Armbruster
2019-01-16 4:43 ` Fei Li
2018-12-25 14:04 ` [Qemu-devel] [PATCH for-4.0 v9 10/16] qemu_thread: supplement error handling for h_resize_hpt_prepare Fei Li
2019-01-02 2:36 ` David Gibson
2019-01-02 6:44 ` 李菲
2019-01-03 3:43 ` David Gibson
2019-01-03 13:41 ` Fei Li
2019-01-04 5:21 ` David Gibson
2019-01-04 6:20 ` Fei Li
2018-12-25 14:04 ` [Qemu-devel] [PATCH for-4.0 v9 11/16] qemu_thread: supplement error handling for emulated_realize Fei Li
2019-01-07 17:31 ` Markus Armbruster
2019-01-09 13:21 ` Fei Li
2018-12-25 14:04 ` [Qemu-devel] [PATCH for-4.0 v9 12/16] qemu_thread: supplement error handling for iothread_complete/qemu_signalfd_compat Fei Li
2019-01-07 17:50 ` Markus Armbruster
2019-01-08 16:18 ` fei
2019-01-13 16:16 ` Fei Li
2019-01-14 12:53 ` Markus Armbruster
2019-01-14 13:52 ` Fei Li
2018-12-25 14:04 ` [Qemu-devel] [PATCH for-4.0 v9 13/16] qemu_thread: supplement error handling for migration Fei Li
2019-01-03 12:35 ` Dr. David Alan Gilbert
2019-01-03 12:47 ` Fei Li
2019-01-09 15:26 ` Markus Armbruster
2019-01-09 16:01 ` fei
2018-12-25 14:04 ` [Qemu-devel] [PATCH for-4.0 v9 14/16] qemu_thread: supplement error handling for vnc_start_worker_thread Fei Li
2019-01-07 17:54 ` Markus Armbruster
2019-01-08 16:24 ` fei
2018-12-25 14:04 ` [Qemu-devel] [PATCH for-4.0 v9 15/16] qemu_thread: supplement error handling for touch_all_pages Fei Li
2019-01-07 18:13 ` Markus Armbruster
2019-01-09 16:13 ` fei
2018-12-25 14:04 ` [Qemu-devel] [PATCH for-4.0 v9 16/16] qemu_thread_join: fix segmentation fault Fei Li
2019-01-07 17:55 ` Markus Armbruster
2019-01-08 16:50 ` fei
2019-01-08 17:29 ` Markus Armbruster
2019-01-09 14:01 ` Fei Li
2019-01-09 15:24 ` Markus Armbruster
2019-01-09 15:57 ` fei
2019-01-10 9:20 ` Markus Armbruster
2019-01-10 13:24 ` Fei Li
2019-01-10 16:06 ` Markus Armbruster
2019-01-11 14:01 ` Fei Li
2019-01-02 13:46 ` [Qemu-devel] [PATCH for-4.0 v9 00/16] qemu_thread_create: propagate the error to callers to handle no-reply
2019-01-07 12:44 ` Fei Li
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181225140449.15786-5-fli@suse.com \
--to=fli@suse.com \
--cc=dgilbert@redhat.com \
--cc=lifei1214@126.com \
--cc=qemu-devel@nongnu.org \
--cc=shirley17fei@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.