From: Al Viro <viro@zeniv.linux.org.uk>
To: Alexey Dobriyan <adobriyan@gmail.com>
Cc: Kangjie Lu <kjlu@umn.edu>,
pakki001@umn.edu, Andrew Morton <akpm@linux-foundation.org>,
Davidlohr Bueso <dbueso@suse.de>,
David Howells <dhowells@redhat.com>,
linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org
Subject: Re: [PATCH] fs: proc: check status of register_filesystem
Date: Wed, 26 Dec 2018 06:58:50 +0000 [thread overview]
Message-ID: <20181226065850.GG2217@ZenIV.linux.org.uk> (raw)
In-Reply-To: <20181226061856.GA2122@avx2>
On Wed, Dec 26, 2018 at 09:18:56AM +0300, Alexey Dobriyan wrote:
> On Tue, Dec 25, 2018 at 09:06:40PM -0600, Kangjie Lu wrote:
> > register_filesystem() could fail. The fix issues an error message if it
> > fails.
>
> > - register_filesystem(&proc_fs_type);
> > + if (register_filesystem(&proc_fs_type))
> > + pr_err("failed to register the filesystem.\n");
>
> No, register_filesystem() should do it.
Folks, check when would it fail. If we have something called "proc"
already registered by the time when proc_root_init() runs... might
as well have been a panic().
next prev parent reply other threads:[~2018-12-26 6:59 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-26 3:06 [PATCH] fs: proc: check status of register_filesystem Kangjie Lu
2018-12-26 6:18 ` Alexey Dobriyan
2018-12-26 6:58 ` Al Viro [this message]
2019-01-02 9:38 ` David Howells
2019-01-02 9:38 ` David Howells
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181226065850.GG2217@ZenIV.linux.org.uk \
--to=viro@zeniv.linux.org.uk \
--cc=adobriyan@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=dbueso@suse.de \
--cc=dhowells@redhat.com \
--cc=kjlu@umn.edu \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pakki001@umn.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.