From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Michael S. Tsirkin" Subject: Re: [PATCH RFC 1/2] virtio-net: bql support Date: Wed, 26 Dec 2018 10:15:05 -0500 Message-ID: <20181226101411-mutt-send-email-mst@kernel.org> References: <20181205225323.12555-1-mst@redhat.com> <20181205225323.12555-2-mst@redhat.com> <21384cb5-99a6-7431-1039-b356521e1bc3@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Content-Disposition: inline In-Reply-To: <21384cb5-99a6-7431-1039-b356521e1bc3@redhat.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: virtualization-bounces@lists.linux-foundation.org Errors-To: virtualization-bounces@lists.linux-foundation.org To: Jason Wang Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, virtualization@lists.linux-foundation.org, maxime.coquelin@redhat.com, wexu@redhat.com, "David S. Miller" List-Id: virtualization@lists.linuxfoundation.org T24gVGh1LCBEZWMgMDYsIDIwMTggYXQgMDQ6MTc6MzZQTSArMDgwMCwgSmFzb24gV2FuZyB3cm90 ZToKPiAKPiBPbiAyMDE4LzEyLzYg5LiK5Y2INjo1NCwgTWljaGFlbCBTLiBUc2lya2luIHdyb3Rl Ogo+ID4gV2hlbiB1c2VfbmFwaSBpcyBzZXQsIGxldCdzIGVuYWJsZSBCUUxzLiAgTm90ZTogc29t ZSBvZiB0aGUgaXNzdWVzIGFyZQo+ID4gc2ltaWxhciB0byB3aWZpLiAgSXQncyB3b3J0aCBjb25z aWRlcmluZyB3aGV0aGVyIHNvbWV0aGluZyBzaW1pbGFyIHRvCj4gPiBjb21taXQgMzYxNDhjMmJi ZmJlICgibWFjODAyMTE6IEFkanVzdCBUU1EgcGFjaW5nIHNoaWZ0IikgbWlnaHQgYmUKPiA+IGJl bmVmaXRpYWwuCj4gCj4gCj4gSSd2ZSBwbGF5ZWQgYSBzaW1pbGFyIHBhdGNoIHNldmVyYWwgZGF5 cyBiZWZvcmUuIFRoZSB0cmlja3kgcGFydCBpcyB0aGUgbW9kZQo+IHN3aXRjaGluZyBiZXR3ZWVu IG5hcGkgYW5kIG5vIG5hcGkuIFdlIHNob3VsZCBtYWtlIHN1cmUgd2hlbiB0aGUgcGFja2V0IGlz Cj4gc2VudCBhbmQgdHJha2NlZCBieSBCUUwswqAgaXQgc2hvdWxkIGJlIGNvbnN1bWVkIGJ5IEJR TCBhcyB3ZWxsLiBJIGRpZCBpdCBieQo+IHRyYWNraW5nIGl0IHRocm91Z2ggc2tiLT5jYi7CoCBB bmQgZGVhbCB3aXRoIHRoZSBmcmVlemUgYnkgcmVzZXQgdGhlIEJRTAo+IHN0YXR1cy4gUGF0Y2gg YXR0YWNoZWQuCj4gCj4gQnV0IHdoZW4gdGVzdGluZyB3aXRoIHZob3N0LW5ldCwgSSBkb24ndCB2 ZXJ5IGEgc3RhYmxlIHBlcmZvcm1hbmNlLCBpdCB3YXMKPiBwcm9iYWJseSBiZWNhdXNlIHdlIGJh dGNoIHRoZSB1c2VkIHJpbmcgdXBkYXRpbmcgc28gdHggaW50ZXJydXB0IG1heSBjb21lCj4gcmFu ZG9tbHkuIFdlIHByb2JhYmx5IG5lZWQgdG8gaW1wbGVtZW50IHRpbWUgYm91bmRlZCBjb2FsZXNj aW5nIG1lY2hhbmlzbQo+IHdoaWNoIGNvdWxkIGJlIGNvbmZpZ3VyZWQgZnJvbSB1c2Vyc3BhY2Uu Cj4gCj4gQnR3LCBtYXliZSBpdCdzIHRpbWUganVzdCBlbmFibGUgbmFwaSBUWCBieSBkZWZhdWx0 LiBJIGdldCB+MTAlIFRDUF9SUgo+IHJlZ3Jlc3Npb24gb24gbWFjaGluZSB3aXRob3V0IEFQSUN2 LCAoaGF2ZW4ndCBmb3VuZCB0aW1lIHRvIHRlc3QgQVBJQ3YKPiBtYWNoaW5lKS4gQnV0IGNvbnNp ZGVyIGl0IHdhcyBmb3IgY29ycmVjdG5lc3MsIEkgdGhpbmsgaXQncyBhY2NlcHRhYmxlPyBUaGVu Cj4gd2UgY2FuIGRvIG9wdGltaXphdGlvbiBvbiB0b3A/Cj4gCj4gCj4gVGhhbmtzCgpJIGRvbid0 IHNlZSBob3cgaXQncyBmb3IgY29ycmVjdG5lc3MgdG8gYmUgZnJhbmsuCldoYXQgaWYgd2UganVz dCBkbyB0aGUgYnVsayBmcmVlPyBEb2VzIHRoYXQgZml4IHRoZSByZWdyZXNzaW9uPwoKCj4gCj4g PiBTaWduZWQtb2ZmLWJ5OiBNaWNoYWVsIFMuIFRzaXJraW4gPG1zdEByZWRoYXQuY29tPgo+ID4g LS0tCj4gPiAgIGRyaXZlcnMvbmV0L3ZpcnRpb19uZXQuYyB8IDI3ICsrKysrKysrKysrKysrKysr KystLS0tLS0tLQo+ID4gICAxIGZpbGUgY2hhbmdlZCwgMTkgaW5zZXJ0aW9ucygrKSwgOCBkZWxl dGlvbnMoLSkKPiA+IAo+ID4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvbmV0L3ZpcnRpb19uZXQuYyBi L2RyaXZlcnMvbmV0L3ZpcnRpb19uZXQuYwo+ID4gaW5kZXggY2VjZmQ3N2M5ZjNjLi5iNjU3YmRl NmI5NGIgMTAwNjQ0Cj4gPiAtLS0gYS9kcml2ZXJzL25ldC92aXJ0aW9fbmV0LmMKPiA+ICsrKyBi L2RyaXZlcnMvbmV0L3ZpcnRpb19uZXQuYwo+ID4gQEAgLTEzMjUsNyArMTMyNSw4IEBAIHN0YXRp YyBpbnQgdmlydG5ldF9yZWNlaXZlKHN0cnVjdCByZWNlaXZlX3F1ZXVlICpycSwgaW50IGJ1ZGdl dCwKPiA+ICAgCXJldHVybiBzdGF0cy5wYWNrZXRzOwo+ID4gICB9Cj4gPiAtc3RhdGljIHZvaWQg ZnJlZV9vbGRfeG1pdF9za2JzKHN0cnVjdCBzZW5kX3F1ZXVlICpzcSkKPiA+ICtzdGF0aWMgdm9p ZCBmcmVlX29sZF94bWl0X3NrYnMoc3RydWN0IHNlbmRfcXVldWUgKnNxLCBzdHJ1Y3QgbmV0ZGV2 X3F1ZXVlICp0eHEsCj4gPiArCQkJICAgICAgIGJvb2wgdXNlX25hcGkpCj4gPiAgIHsKPiA+ICAg CXN0cnVjdCBza19idWZmICpza2I7Cj4gPiAgIAl1bnNpZ25lZCBpbnQgbGVuOwo+ID4gQEAgLTEz NDcsNiArMTM0OCw5IEBAIHN0YXRpYyB2b2lkIGZyZWVfb2xkX3htaXRfc2ticyhzdHJ1Y3Qgc2Vu ZF9xdWV1ZSAqc3EpCj4gPiAgIAlpZiAoIXBhY2tldHMpCj4gPiAgIAkJcmV0dXJuOwo+ID4gKwlp ZiAodXNlX25hcGkpCj4gPiArCQluZXRkZXZfdHhfY29tcGxldGVkX3F1ZXVlKHR4cSwgcGFja2V0 cywgYnl0ZXMpOwo+ID4gKwo+ID4gICAJdTY0X3N0YXRzX3VwZGF0ZV9iZWdpbigmc3EtPnN0YXRz LnN5bmNwKTsKPiA+ICAgCXNxLT5zdGF0cy5ieXRlcyArPSBieXRlczsKPiA+ICAgCXNxLT5zdGF0 cy5wYWNrZXRzICs9IHBhY2tldHM7Cj4gPiBAQCAtMTM2NCw3ICsxMzY4LDcgQEAgc3RhdGljIHZv aWQgdmlydG5ldF9wb2xsX2NsZWFudHgoc3RydWN0IHJlY2VpdmVfcXVldWUgKnJxKQo+ID4gICAJ CXJldHVybjsKPiA+ICAgCWlmIChfX25ldGlmX3R4X3RyeWxvY2sodHhxKSkgewo+ID4gLQkJZnJl ZV9vbGRfeG1pdF9za2JzKHNxKTsKPiA+ICsJCWZyZWVfb2xkX3htaXRfc2ticyhzcSwgdHhxLCB0 cnVlKTsKPiA+ICAgCQlfX25ldGlmX3R4X3VubG9jayh0eHEpOwo+ID4gICAJfQo+ID4gQEAgLTE0 NDAsNyArMTQ0NCw3IEBAIHN0YXRpYyBpbnQgdmlydG5ldF9wb2xsX3R4KHN0cnVjdCBuYXBpX3N0 cnVjdCAqbmFwaSwgaW50IGJ1ZGdldCkKPiA+ICAgCXN0cnVjdCBuZXRkZXZfcXVldWUgKnR4cSA9 IG5ldGRldl9nZXRfdHhfcXVldWUodmktPmRldiwgdnEydHhxKHNxLT52cSkpOwo+ID4gICAJX19u ZXRpZl90eF9sb2NrKHR4cSwgcmF3X3NtcF9wcm9jZXNzb3JfaWQoKSk7Cj4gPiAtCWZyZWVfb2xk X3htaXRfc2ticyhzcSk7Cj4gPiArCWZyZWVfb2xkX3htaXRfc2ticyhzcSwgdHhxLCB0cnVlKTsK PiA+ICAgCV9fbmV0aWZfdHhfdW5sb2NrKHR4cSk7Cj4gPiAgIAl2aXJ0cXVldWVfbmFwaV9jb21w bGV0ZShuYXBpLCBzcS0+dnEsIDApOwo+ID4gQEAgLTE1MDUsMTMgKzE1MDksMTUgQEAgc3RhdGlj IG5ldGRldl90eF90IHN0YXJ0X3htaXQoc3RydWN0IHNrX2J1ZmYgKnNrYiwgc3RydWN0IG5ldF9k ZXZpY2UgKmRldikKPiA+ICAgCXN0cnVjdCBzZW5kX3F1ZXVlICpzcSA9ICZ2aS0+c3FbcW51bV07 Cj4gPiAgIAlpbnQgZXJyOwo+ID4gICAJc3RydWN0IG5ldGRldl9xdWV1ZSAqdHhxID0gbmV0ZGV2 X2dldF90eF9xdWV1ZShkZXYsIHFudW0pOwo+ID4gLQlib29sIGtpY2sgPSAhc2tiLT54bWl0X21v cmU7Cj4gPiArCWJvb2wgbW9yZSA9IHNrYi0+eG1pdF9tb3JlOwo+ID4gICAJYm9vbCB1c2VfbmFw aSA9IHNxLT5uYXBpLndlaWdodDsKPiA+ICsJdW5zaWduZWQgaW50IGJ5dGVzID0gc2tiLT5sZW47 Cj4gPiArCWJvb2wga2ljazsKPiA+ICAgCS8qIEZyZWUgdXAgYW55IHBlbmRpbmcgb2xkIGJ1ZmZl cnMgYmVmb3JlIHF1ZXVlaW5nIG5ldyBvbmVzLiAqLwo+ID4gLQlmcmVlX29sZF94bWl0X3NrYnMo c3EpOwo+ID4gKwlmcmVlX29sZF94bWl0X3NrYnMoc3EsIHR4cSwgdXNlX25hcGkpOwo+ID4gLQlp ZiAodXNlX25hcGkgJiYga2ljaykKPiA+ICsJaWYgKHVzZV9uYXBpICYmICFtb3JlKQo+ID4gICAJ CXZpcnRxdWV1ZV9lbmFibGVfY2JfZGVsYXllZChzcS0+dnEpOwo+ID4gICAJLyogdGltZXN0YW1w IHBhY2tldCBpbiBzb2Z0d2FyZSAqLwo+ID4gQEAgLTE1NTIsNyArMTU1OCw3IEBAIHN0YXRpYyBu ZXRkZXZfdHhfdCBzdGFydF94bWl0KHN0cnVjdCBza19idWZmICpza2IsIHN0cnVjdCBuZXRfZGV2 aWNlICpkZXYpCj4gPiAgIAkJaWYgKCF1c2VfbmFwaSAmJgo+ID4gICAJCSAgICB1bmxpa2VseSgh dmlydHF1ZXVlX2VuYWJsZV9jYl9kZWxheWVkKHNxLT52cSkpKSB7Cj4gPiAgIAkJCS8qIE1vcmUg anVzdCBnb3QgdXNlZCwgZnJlZSB0aGVtIHRoZW4gcmVjaGVjay4gKi8KPiA+IC0JCQlmcmVlX29s ZF94bWl0X3NrYnMoc3EpOwo+ID4gKwkJCWZyZWVfb2xkX3htaXRfc2ticyhzcSwgdHhxLCBmYWxz ZSk7Cj4gPiAgIAkJCWlmIChzcS0+dnEtPm51bV9mcmVlID49IDIrTUFYX1NLQl9GUkFHUykgewo+ ID4gICAJCQkJbmV0aWZfc3RhcnRfc3VicXVldWUoZGV2LCBxbnVtKTsKPiA+ICAgCQkJCXZpcnRx dWV1ZV9kaXNhYmxlX2NiKHNxLT52cSk7Cj4gPiBAQCAtMTU2MCw3ICsxNTY2LDEyIEBAIHN0YXRp YyBuZXRkZXZfdHhfdCBzdGFydF94bWl0KHN0cnVjdCBza19idWZmICpza2IsIHN0cnVjdCBuZXRf ZGV2aWNlICpkZXYpCj4gPiAgIAkJfQo+ID4gICAJfQo+ID4gLQlpZiAoa2ljayB8fCBuZXRpZl94 bWl0X3N0b3BwZWQodHhxKSkgewo+ID4gKwlpZiAodXNlX25hcGkpCj4gPiArCQlraWNrID0gX19u ZXRkZXZfdHhfc2VudF9xdWV1ZSh0eHEsIGJ5dGVzLCBtb3JlKTsKPiA+ICsJZWxzZQo+ID4gKwkJ a2ljayA9ICFtb3JlIHx8IG5ldGlmX3htaXRfc3RvcHBlZCh0eHEpOwo+ID4gKwo+ID4gKwlpZiAo a2ljaykgewo+ID4gICAJCWlmICh2aXJ0cXVldWVfa2lja19wcmVwYXJlKHNxLT52cSkgJiYgdmly dHF1ZXVlX25vdGlmeShzcS0+dnEpKSB7Cj4gPiAgIAkJCXU2NF9zdGF0c191cGRhdGVfYmVnaW4o JnNxLT5zdGF0cy5zeW5jcCk7Cj4gPiAgIAkJCXNxLT5zdGF0cy5raWNrcysrOwpfX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpWaXJ0dWFsaXphdGlvbiBtYWls aW5nIGxpc3QKVmlydHVhbGl6YXRpb25AbGlzdHMubGludXgtZm91bmRhdGlvbi5vcmcKaHR0cHM6 Ly9saXN0cy5saW51eGZvdW5kYXRpb24ub3JnL21haWxtYW4vbGlzdGluZm8vdmlydHVhbGl6YXRp b24= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 11952C43387 for ; Wed, 26 Dec 2018 15:15:17 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id CD16F218AD for ; Wed, 26 Dec 2018 15:15:16 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727297AbeLZPPP (ORCPT ); Wed, 26 Dec 2018 10:15:15 -0500 Received: from mx1.redhat.com ([209.132.183.28]:44814 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725784AbeLZPPP (ORCPT ); Wed, 26 Dec 2018 10:15:15 -0500 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id E63C081127; Wed, 26 Dec 2018 15:15:14 +0000 (UTC) Received: from redhat.com (ovpn-120-80.rdu2.redhat.com [10.10.120.80]) by smtp.corp.redhat.com (Postfix) with ESMTP id 4376F5C22C; Wed, 26 Dec 2018 15:15:06 +0000 (UTC) Date: Wed, 26 Dec 2018 10:15:05 -0500 From: "Michael S. Tsirkin" To: Jason Wang Cc: linux-kernel@vger.kernel.org, maxime.coquelin@redhat.com, tiwei.bie@intel.com, wexu@redhat.com, jfreimann@redhat.com, "David S. Miller" , virtualization@lists.linux-foundation.org, netdev@vger.kernel.org Subject: Re: [PATCH RFC 1/2] virtio-net: bql support Message-ID: <20181226101411-mutt-send-email-mst@kernel.org> References: <20181205225323.12555-1-mst@redhat.com> <20181205225323.12555-2-mst@redhat.com> <21384cb5-99a6-7431-1039-b356521e1bc3@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <21384cb5-99a6-7431-1039-b356521e1bc3@redhat.com> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.27]); Wed, 26 Dec 2018 15:15:15 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Dec 06, 2018 at 04:17:36PM +0800, Jason Wang wrote: > > On 2018/12/6 上午6:54, Michael S. Tsirkin wrote: > > When use_napi is set, let's enable BQLs. Note: some of the issues are > > similar to wifi. It's worth considering whether something similar to > > commit 36148c2bbfbe ("mac80211: Adjust TSQ pacing shift") might be > > benefitial. > > > I've played a similar patch several days before. The tricky part is the mode > switching between napi and no napi. We should make sure when the packet is > sent and trakced by BQL,  it should be consumed by BQL as well. I did it by > tracking it through skb->cb.  And deal with the freeze by reset the BQL > status. Patch attached. > > But when testing with vhost-net, I don't very a stable performance, it was > probably because we batch the used ring updating so tx interrupt may come > randomly. We probably need to implement time bounded coalescing mechanism > which could be configured from userspace. > > Btw, maybe it's time just enable napi TX by default. I get ~10% TCP_RR > regression on machine without APICv, (haven't found time to test APICv > machine). But consider it was for correctness, I think it's acceptable? Then > we can do optimization on top? > > > Thanks I don't see how it's for correctness to be frank. What if we just do the bulk free? Does that fix the regression? > > > Signed-off-by: Michael S. Tsirkin > > --- > > drivers/net/virtio_net.c | 27 +++++++++++++++++++-------- > > 1 file changed, 19 insertions(+), 8 deletions(-) > > > > diff --git a/drivers/net/virtio_net.c b/drivers/net/virtio_net.c > > index cecfd77c9f3c..b657bde6b94b 100644 > > --- a/drivers/net/virtio_net.c > > +++ b/drivers/net/virtio_net.c > > @@ -1325,7 +1325,8 @@ static int virtnet_receive(struct receive_queue *rq, int budget, > > return stats.packets; > > } > > -static void free_old_xmit_skbs(struct send_queue *sq) > > +static void free_old_xmit_skbs(struct send_queue *sq, struct netdev_queue *txq, > > + bool use_napi) > > { > > struct sk_buff *skb; > > unsigned int len; > > @@ -1347,6 +1348,9 @@ static void free_old_xmit_skbs(struct send_queue *sq) > > if (!packets) > > return; > > + if (use_napi) > > + netdev_tx_completed_queue(txq, packets, bytes); > > + > > u64_stats_update_begin(&sq->stats.syncp); > > sq->stats.bytes += bytes; > > sq->stats.packets += packets; > > @@ -1364,7 +1368,7 @@ static void virtnet_poll_cleantx(struct receive_queue *rq) > > return; > > if (__netif_tx_trylock(txq)) { > > - free_old_xmit_skbs(sq); > > + free_old_xmit_skbs(sq, txq, true); > > __netif_tx_unlock(txq); > > } > > @@ -1440,7 +1444,7 @@ static int virtnet_poll_tx(struct napi_struct *napi, int budget) > > struct netdev_queue *txq = netdev_get_tx_queue(vi->dev, vq2txq(sq->vq)); > > __netif_tx_lock(txq, raw_smp_processor_id()); > > - free_old_xmit_skbs(sq); > > + free_old_xmit_skbs(sq, txq, true); > > __netif_tx_unlock(txq); > > virtqueue_napi_complete(napi, sq->vq, 0); > > @@ -1505,13 +1509,15 @@ static netdev_tx_t start_xmit(struct sk_buff *skb, struct net_device *dev) > > struct send_queue *sq = &vi->sq[qnum]; > > int err; > > struct netdev_queue *txq = netdev_get_tx_queue(dev, qnum); > > - bool kick = !skb->xmit_more; > > + bool more = skb->xmit_more; > > bool use_napi = sq->napi.weight; > > + unsigned int bytes = skb->len; > > + bool kick; > > /* Free up any pending old buffers before queueing new ones. */ > > - free_old_xmit_skbs(sq); > > + free_old_xmit_skbs(sq, txq, use_napi); > > - if (use_napi && kick) > > + if (use_napi && !more) > > virtqueue_enable_cb_delayed(sq->vq); > > /* timestamp packet in software */ > > @@ -1552,7 +1558,7 @@ static netdev_tx_t start_xmit(struct sk_buff *skb, struct net_device *dev) > > if (!use_napi && > > unlikely(!virtqueue_enable_cb_delayed(sq->vq))) { > > /* More just got used, free them then recheck. */ > > - free_old_xmit_skbs(sq); > > + free_old_xmit_skbs(sq, txq, false); > > if (sq->vq->num_free >= 2+MAX_SKB_FRAGS) { > > netif_start_subqueue(dev, qnum); > > virtqueue_disable_cb(sq->vq); > > @@ -1560,7 +1566,12 @@ static netdev_tx_t start_xmit(struct sk_buff *skb, struct net_device *dev) > > } > > } > > - if (kick || netif_xmit_stopped(txq)) { > > + if (use_napi) > > + kick = __netdev_tx_sent_queue(txq, bytes, more); > > + else > > + kick = !more || netif_xmit_stopped(txq); > > + > > + if (kick) { > > if (virtqueue_kick_prepare(sq->vq) && virtqueue_notify(sq->vq)) { > > u64_stats_update_begin(&sq->stats.syncp); > > sq->stats.kicks++;