From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sam Ravnborg Subject: Re: [PATCH] drm/bridge/panel: Remove duplicate header Date: Wed, 26 Dec 2018 11:54:32 +0100 Message-ID: <20181226105432.GA27553@ravnborg.org> References: <20181224143218.GA3170@hp-pavilion-15-notebook-pc-brajeswar> <1891132.39bZHgSTRL@avalon> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <1891132.39bZHgSTRL@avalon> Sender: linux-kernel-owner@vger.kernel.org To: Laurent Pinchart Cc: Brajeswar Ghosh , sabyasachi.linux@gmail.com, airlied@linux.ie, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, jrdr.linux@gmail.com List-Id: dri-devel@lists.freedesktop.org Hi Brajeswar > On Monday, 24 December 2018 16:32:18 EET Brajeswar Ghosh wrote: > > Remove drm/drm_panel.h which is included more than once > > > > Signed-off-by: Brajeswar Ghosh > > --- > > drivers/gpu/drm/bridge/panel.c | 1 - > > 1 file changed, 1 deletion(-) > > > > diff --git a/drivers/gpu/drm/bridge/panel.c b/drivers/gpu/drm/bridge/panel.c > > index 7cbaba213ef6..402b318eeeb2 100644 > > --- a/drivers/gpu/drm/bridge/panel.c > > +++ b/drivers/gpu/drm/bridge/panel.c > > @@ -15,7 +15,6 @@ > > #include > > #include > > #include > > -#include > > While at it, how about sorting headers alphabetically to make sure this won't > happen again ? Even better would be to address the todo item: "Clean up the DRM header mess" (see Documentation/gpu/todo.rst) In other words - replace the include of "drmP.h" with the relevant header files. Sorted, as suggested by Laurent. Sam