From: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
To: buildroot@busybox.net
Subject: [Buildroot] [EXT] Re: [PATCH] boot/mv-ddr-marvell: support custom GIT settings
Date: Wed, 26 Dec 2018 11:31:53 +0100 [thread overview]
Message-ID: <20181226113153.696dc370@windsurf.home> (raw)
In-Reply-To: <SN2PR18MB07361F184E2286FF9C3EB1B0CAB40@SN2PR18MB0736.namprd18.prod.outlook.com>
Hello Kostya,
On Tue, 25 Dec 2018 09:09:26 +0000, Kostya Porotchkin wrote:
> > As I see you're an @marvell.com, do you need that to use an internal
> > repository during development? If so, then why can't you just use the
> > OVERRIDE_SRCDIR mechanism instead?
> [KP] It is more than just a local repository. I have to allow CI server to automatically build test and release images from the current internal GIT trees.
Sorry, but this is not a valid justification. With this justification,
we would have to add version selection to *all* Buildroot packages.
Indeed, one might want to do CI testing on any random user-space
library or application. So if your use-case for wanting version
selection in mv-ddr-marvell is CI testing, then we won't accept this
patch.
However, if people porting ATF/U-Boot to new Marvell-based platforms
need to have their own custom version of mv-ddr-marvell, then having
version selection can be accepted because it puts this package in the
same situation as uboot, linux or atf, where we do offer version
selection.
Best regards,
Thomas
--
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
next prev parent reply other threads:[~2018-12-26 10:31 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-24 13:18 [Buildroot] [PATCH] boot/mv-ddr-marvell: support custom GIT settings kostap at marvell.com
2018-12-24 18:57 ` Yann E. MORIN
2018-12-25 9:09 ` [Buildroot] [EXT] " Kostya Porotchkin
2018-12-26 10:31 ` Thomas Petazzoni [this message]
2018-12-26 10:59 ` Kostya Porotchkin
2018-12-26 11:25 ` Yann E. MORIN
2018-12-26 12:33 ` Kostya Porotchkin
2018-12-26 13:24 ` Thomas Petazzoni
2018-12-26 13:30 ` Thomas Petazzoni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181226113153.696dc370@windsurf.home \
--to=thomas.petazzoni@bootlin.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.