All of lore.kernel.org
 help / color / mirror / Atom feed
From: hch@lst.de (Christoph Hellwig)
Subject: [PATCH 2/2] nvme pci: try to allocate multiple irq vectors again in case of -EINVAL
Date: Wed, 26 Dec 2018 19:20:27 +0100	[thread overview]
Message-ID: <20181226182027.GA5866@lst.de> (raw)
In-Reply-To: <20181226103755.2101-3-ming.lei@redhat.com>

On Wed, Dec 26, 2018@06:37:55PM +0800, Ming Lei wrote:
> It is observed on QEMU that pci_alloc_irq_vectors_affinity() may
> returns -EINVAL when the requested number is too big(such as 64).

Which is not how this API is supposed to work and documented to work.

We need to fix pci_alloc_irq_vectors_affinity to not return a spurious
error and just return the allocated number of vectors instead of
hacking around that in drivers.

  reply	other threads:[~2018-12-26 18:20 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-12-26 10:37 [PATCH 0/2] nvme pci: two fixes on nvme_setup_irqs Ming Lei
2018-12-26 10:37 ` [PATCH 1/2] nvme pci: fix nvme_setup_irqs() Ming Lei
2018-12-26 10:37 ` [PATCH 2/2] nvme pci: try to allocate multiple irq vectors again in case of -EINVAL Ming Lei
2018-12-26 18:20   ` Christoph Hellwig [this message]
2018-12-27  8:21     ` Ming Lei
2018-12-27  8:21       ` Ming Lei
2018-12-27 13:08       ` Christoph Hellwig
2018-12-27 13:08         ` Christoph Hellwig
2018-12-27 22:16         ` Ming Lei
2018-12-27 22:16           ` Ming Lei
2018-12-31 21:51         ` Bjorn Helgaas
2018-12-31 21:51           ` Bjorn Helgaas

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20181226182027.GA5866@lst.de \
    --to=hch@lst.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.