All of lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 5/5 v5] boot/systemd-boot: new package
Date: Wed, 26 Dec 2018 22:23:29 +0100	[thread overview]
Message-ID: <20181226222329.18046c1c@windsurf> (raw)
In-Reply-To: <d38239f86f99924e87dcb6e045b2de3ac0cb435f.1545814334.git.yann.morin.1998@free.fr>

Hello,

Thanks for working on this!

On Wed, 26 Dec 2018 09:52:30 +0100, Yann E. MORIN wrote:
> From: James Hilliard <james.hilliard1@gmail.com>
> 
> systemd-boot is the integration of gummiboot into systemd, and gummiboot
> is no longer maintained [0]. However, it is still interesting to use it
> as a simple, stand-alone bootloader.
> 
> Since systemd-boot is really part of systemd, when systemd is enabled
> (as an init system), we rely on it to build the boot blobs, and
> systemd-boot (this package) is not available.
> 
> Now, when systemd is not enabled, systemd-boot (this package) will
> actually build the boot blobs, and only that. No userspace tool is
> built.
> 
> To avoid duplication, we just symlink the systemd patches as-is. We just
> need to add a specific patch, that just relaxes the dependency checks,
> since we're only interested in building the boot blobs.
> 
> [0] https://cgit.freedesktop.org/gummiboot/commit/?id=55df1539c9d330732e88bd196afee386db6e4a1d
> 
> Signed-off-by: James Hilliard <james.hilliard1@gmail.com>

Do we have a serious valid use-case for wanting to use systemd-boot
without systemd? This adds a fair bit of complexity, so I'd like to be
sure of what we're doing here.

An example of the complexity is with the symlinks to the patches. Every
time a patch is added/removed in package/systemd/, one should remember
to adjust the symlinks in boot/systemd-boot/. This is something that
can very easily be missed.

So it would be good to make sure we have a really solid use-case for
adding this complexity.

Best regards,

Thomas
-- 
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com

  parent reply	other threads:[~2018-12-26 21:23 UTC|newest]

Thread overview: 43+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-12-26  8:52 [Buildroot] [PATCH 0/5 v5] systemd-boot: new simple EFI bootloader replacing gummmiboot (branch yem/systemd-boot) Yann E. MORIN
2018-12-26  8:52 ` [Buildroot] [PATCH 1/5 v5] package/meson: never try to run generated target binaries Yann E. MORIN
2018-12-28 10:54   ` Thomas Petazzoni
2018-12-26  8:52 ` [Buildroot] [PATCH 2/5 v5] package/meson: fix CPU familly Yann E. MORIN
2018-12-28 10:54   ` Thomas Petazzoni
2018-12-26  8:52 ` [Buildroot] [PATCH 3/5 v5] core/pkg-infra: allow meson packages to specify custom build rules Yann E. MORIN
2018-12-26 11:36   ` James Hilliard
2018-12-26 12:06     ` Yann E. MORIN
2018-12-27  4:21       ` James Hilliard
2018-12-27  8:23         ` Yann E. MORIN
2018-12-28 10:54   ` Thomas Petazzoni
2018-12-26  8:52 ` [Buildroot] [PATCH 4/5 v5] package/systemd: enable building of systemd-boot Yann E. MORIN
2018-12-26  8:52 ` [Buildroot] [PATCH 5/5 v5] boot/systemd-boot: new package Yann E. MORIN
2018-12-26  9:33   ` Yann E. MORIN
2018-12-26 21:23   ` Thomas Petazzoni [this message]
2018-12-26 21:37     ` James Hilliard
2018-12-26 21:43       ` Thomas Petazzoni
2018-12-26 21:52         ` James Hilliard
2018-12-26 21:41     ` Yann E. MORIN
2018-12-26 22:07       ` James Hilliard
2018-12-26 22:12         ` James Hilliard
2018-12-26 22:52           ` James Hilliard
2018-12-27  1:27             ` James Hilliard
2018-12-27  8:49               ` Yann E. MORIN
2018-12-27  9:07                 ` James Hilliard
2018-12-27  9:11                   ` Yann E. MORIN
2018-12-27  9:13                     ` James Hilliard
2018-12-27 10:40                       ` Yann E. MORIN
2018-12-27 10:42                         ` James Hilliard
2018-12-27 10:57                           ` Yann E. MORIN
2018-12-27 11:01                             ` James Hilliard
2018-12-29  9:35                               ` Yann E. MORIN
2018-12-29 10:50                                 ` James Hilliard
2018-12-29 11:38                                   ` Yann E. MORIN
2018-12-29 11:43                                     ` James Hilliard
2018-12-30  8:44                                     ` James Hilliard
2018-12-31 10:16                                       ` Yann E. MORIN
2018-12-31 10:24                                         ` James Hilliard
2018-12-31 10:36                                           ` Yann E. MORIN
2018-12-31 12:43       ` Peter Korsgaard
2019-01-10 23:47   ` Arnout Vandecappelle
2019-01-11  5:59     ` Yann E. MORIN
2019-01-11  6:47     ` James Hilliard

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20181226222329.18046c1c@windsurf \
    --to=thomas.petazzoni@bootlin.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.