All of lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH v3 2/3] doc/manual: document the waf packages may need to select host-waf
Date: Wed, 26 Dec 2018 22:31:41 +0100	[thread overview]
Message-ID: <20181226223141.5ba89c26@windsurf> (raw)
In-Reply-To: <20181223171950.3979-2-casantos@datacom.com.br>

Hello Carlos,

Minor nit: title should use the prefix docs/manual.

On Sun, 23 Dec 2018 15:19:49 -0200, Carlos Santos wrote:
> Now that waf has a blind Config.in.host we can require that packages
> setting <PKG>_NEEDS_EXTERNAL_WAF to YES slso select host-waf.
> 
> Signed-off-by: Carlos Santos <casantos@datacom.com.br>
> ---
>  docs/manual/adding-packages-waf.txt | 5 ++++-
>  1 file changed, 4 insertions(+), 1 deletion(-)
> 
> diff --git a/docs/manual/adding-packages-waf.txt b/docs/manual/adding-packages-waf.txt
> index 43b557c070..f38c3a6f55 100644
> --- a/docs/manual/adding-packages-waf.txt
> +++ b/docs/manual/adding-packages-waf.txt
> @@ -64,7 +64,10 @@ also be defined.
>    Buildroot to use the bundled +waf+ executable. If set to +NO+, the
>    default, then Buildroot will use the waf executable provided in the
>    package source tree; if set to +YES+, then Buidlroot will download,
> -  install waf as a host tool and use it to build the package.
> +  install waf as a host tool and use it to build the package. Packages
> +  that need the host waf tool must select +BR2_PACKAGE_HOST_WAF+ in

Perhaps: "Packages in this situation must select..."

> +  their Config.in. It is not necessary to add host-waf to
> +  +LIBFOO_DEPENDENCIES+, since this is done atomatically.

atomatically -> automatically.

(Note: I would have fixed these minors nits myself when applying, but I
sent some other questions/comments on PATCH 1/3 anyway.)

Best regards,

Thomas
-- 
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com

  reply	other threads:[~2018-12-26 21:31 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-12-23 17:19 [Buildroot] [PATCH v3 1/3] package/waf: add a blind Config.in.host Carlos Santos
2018-12-23 17:19 ` [Buildroot] [PATCH v3 2/3] doc/manual: document the waf packages may need to select host-waf Carlos Santos
2018-12-26 21:31   ` Thomas Petazzoni [this message]
2018-12-23 17:19 ` [Buildroot] [PATCH v3 3/3] package/mpv: selec host-waf Carlos Santos
2018-12-26 21:30 ` [Buildroot] [PATCH v3 1/3] package/waf: add a blind Config.in.host Thomas Petazzoni
2018-12-26 21:55   ` Yann E. MORIN
2019-01-03 21:50     ` Thomas Petazzoni
2019-01-03 22:06       ` Yann E. MORIN
2019-01-03 22:14         ` Yann E. MORIN
2019-01-03 23:34         ` Carlos Santos
2019-01-04  8:58           ` Thomas Petazzoni
2019-01-04 10:05             ` Carlos Santos
2019-01-04 10:10               ` Thomas Petazzoni
2019-01-04 11:06         ` Arnout Vandecappelle
2019-01-04 11:51           ` Yann E. MORIN

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20181226223141.5ba89c26@windsurf \
    --to=thomas.petazzoni@bootlin.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.