From: Segher Boessenkool <segher@kernel.crashing.org>
To: Ben Hutchings <ben@decadent.org.uk>
Cc: linuxppc-dev@lists.ozlabs.org, debian-kernel@lists.debian.org
Subject: Re: [PATCH] powerpc: Fix -mcpu= options for SPE-only compiler
Date: Wed, 26 Dec 2018 17:45:52 -0600 [thread overview]
Message-ID: <20181226234552.GA28554@gate.crashing.org> (raw)
In-Reply-To: <20181226141511.3ag7uf6rvdgzlmxt@decadent.org.uk>
Hi!
On Wed, Dec 26, 2018 at 02:15:11PM +0000, Ben Hutchings wrote:
> GCC for Debian's "powerpcspe" architecture only supports 32-bit
> SPE targets, and using -mcpu=powerpc or -mcpu=powerpc64 is a fatal
> error.
I don't see where your patch touches -mcpu=powerpc, and I don't see how
it would make a difference either?
> +ifdef CONFIG_PPC64
> ifdef CONFIG_PPC_BOOK3S_64
> ifdef CONFIG_CPU_LITTLE_ENDIAN
> CFLAGS-$(CONFIG_GENERIC_CPU) += -mcpu=power8
> @@ -177,6 +178,7 @@ endif
> else
> CFLAGS-$(CONFIG_GENERIC_CPU) += -mcpu=powerpc64
> endif
> +endif
How can CONFIG_PPC_BOOK3S_64 be true while CONFIG_PPC64 is fals? That
does not make a lot of sense.
Segher
next prev parent reply other threads:[~2018-12-26 23:49 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-26 14:15 [PATCH] powerpc: Fix -mcpu= options for SPE-only compiler Ben Hutchings
2018-12-26 23:45 ` Segher Boessenkool [this message]
2018-12-27 2:32 ` Ben Hutchings
2018-12-29 11:40 ` Segher Boessenkool
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181226234552.GA28554@gate.crashing.org \
--to=segher@kernel.crashing.org \
--cc=ben@decadent.org.uk \
--cc=debian-kernel@lists.debian.org \
--cc=linuxppc-dev@lists.ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.