All of lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] qemu: Remove broken/unneeded PYTHONPATH
Date: Fri, 28 Dec 2018 11:47:39 +0100	[thread overview]
Message-ID: <20181228114739.5060f65c@windsurf> (raw)
In-Reply-To: <20181227215246.14372-1-tpiepho@impinj.com>

Hello,

On Thu, 27 Dec 2018 21:53:07 +0000, Trent Piepho wrote:
> Qemu uses the host-python when building, but the .mk file is pointing the
> host-python interpreter to the target python site-packages, which is both
> incorrect and also unneeded.
> 
> Qemu doesn't need any extra packages [1], so there's no need to provide
> this path.  And indeed qemu builds fine when setting the path to a
> non-existent directory.
> 
> Since target qemu neither depends on nor selects target python, it's
> quite possible to build qemu without a target python, in which case the
> supplied PYTHONPATH is a non-existent directory.
> 
> But even if qemu did want a python package, pointing the host-python to
> the target site-packages will not work.  The package could contain a
> compiled shared library for the target architecture that the host python
> can not load.  This can be tested by adding "import numpy" to one of
> qemu's python scripts and observing target python-numpy failing to load
> when the script is run at build time.
> 
> [1] https://lists.gnu.org/archive/html/qemu-devel/2017-08/msg01758.html
>   "Avoid third-party package dependencies - QEMU currently has none!"
> 
> Signed-off-by: Trent Piepho <tpiepho@impinj.com>
> ---
>  package/qemu/qemu.mk | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)

Applied to master, thanks.

Thomas
-- 
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com

      reply	other threads:[~2018-12-28 10:47 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-12-27 21:53 [Buildroot] [PATCH] qemu: Remove broken/unneeded PYTHONPATH Trent Piepho
2018-12-28 10:47 ` Thomas Petazzoni [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20181228114739.5060f65c@windsurf \
    --to=thomas.petazzoni@bootlin.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.