From: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 1/1] package/libwebsockets: bump to v3.1.0
Date: Sat, 29 Dec 2018 10:42:39 +0100 [thread overview]
Message-ID: <20181229104239.16975c35@windsurf> (raw)
In-Reply-To: <1546068063-11514-1-git-send-email-qwendu@gmail.com>
Hello,
Thanks a lot for this new iteration! From a formatting point of view,
it looks correct now (thanks to the patch being sent using git
send-email). There is however one remaining issue, see below.
On Sat, 29 Dec 2018 15:21:03 +0800, qwendu wrote:
> From: qwen dux <qwendu@gmail.com>
>
> Signed-off-by: qwen dux <qwendu@gmail.com>
> ---
> package/libwebsockets/0001-cmake-no-strict-aliasin.patch | 16 ++++++++++++++++
> package/libwebsockets/0002-libuv.c.uninitialized.patch | 13 +++++++++++++
> package/libwebsockets/libwebsockets.hash | 2 +-
> package/libwebsockets/libwebsockets.mk | 2 +-
> 4 files changed, 31 insertions(+), 2 deletions(-)
> create mode 100644 package/libwebsockets/0001-cmake-no-strict-aliasin.patch
> create mode 100644 package/libwebsockets/0002-libuv.c.uninitialized.patch
>
> diff --git a/package/libwebsockets/0001-cmake-no-strict-aliasin.patch b/package/libwebsockets/0001-cmake-no-strict-aliasin.patch
> new file mode 100644
> index 0000000..8515d40
> --- /dev/null
> +++ b/package/libwebsockets/0001-cmake-no-strict-aliasin.patch
For all patches, we require them to have a description + Signed-off-by
line. In addition, for this specific package, which is managed using
Git by the upstream developers, we like to have git-formatted patches.
So, you should clone the libwebsockets Git repository, create a branch
based on the tag v3.1.0, and create two commits for your two build
fixes, with an appropriate commit log containing a description +
Signed-off-by, and then use:
git format-patch -N HEAD~2
to generate the two patches.
Could you fix this up and send an updated version ?
Thanks a lot!
Thomas
--
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
prev parent reply other threads:[~2018-12-29 9:42 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-29 7:21 [Buildroot] [PATCH 1/1] package/libwebsockets: bump to v3.1.0 qwendu
2018-12-29 9:42 ` Thomas Petazzoni [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181229104239.16975c35@windsurf \
--to=thomas.petazzoni@bootlin.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.