Re: Trouble compiling ... Re: ofono fails to compile on gcc-6.3

[Pavel Machek <pavel@ucw.cz>]

[-- Attachment #1: Type: text/plain, Size: 2192 bytes --]

Hi!

> >>   CC       drivers/rilmodem/network-registration.o
> >>   drivers/rilmodem/network-registration.c:40:32: error: unknown option
> >>   after ‘#pragma GCC diagnostic’ kind [-Werror=pragmas]
> >>    #pragma GCC diagnostic ignored "-Wrestrict"
> >>cc1: error: unrecognized command line option ‘-Wno-format-truncation’
> >>   [-Werror]
> >>   cc1: all warnings being treated as errors
> >>
> >>I commented out #pragma, and this allows compilation to
> >>continue... until I hit same issue in
> >>drivers/rilmodem/call-forwarding.c:41:32:
> 
> Yeah, I'm not sure what to do with these.  Marcel put in the #pragmas to
> silence some warnings on GCC 8.x, but it seems GCC 6 doesn't know about
> these #pragma directives and complains.

/* Test for GCC > 3.2.0 */
#if __GNUC__ > 3 || \
    (__GNUC__ == 3 && (__GNUC_MINOR__ > 2 || \
                           (__GNUC_MINOR__ == 2 && \
			                           __GNUC_PATCHLEVEL__
						   > 0))
#pragma...
#endif

?

> >Plus there's new one:
> >   CC       drivers/rilmodem/sim.o
> >   drivers/rilmodem/sim.c: In function ‘ril_file_io_cb’:
> >   drivers/rilmodem/sim.c:381:49: warning: passing argument 2 of
> >   ‘l_util_from_hexstring’ from incompatible pointer type
> >     response = l_util_from_hexstring(hex_response, &len);
> >                                                      ^
> >						     In file included
> >   from ./ell/ell.h:1:0,
> >                    from drivers/rilmodem/sim.c:34:
> >		   ./ell/util.h:271:16: note: expected ‘size_t *’ but
> >   argument is of type ‘long int *’
> >    unsigned char *l_util_from_hexstring(const char *str, size_t
> >   *out_len);
> >                   ^
> 
> Ah darn, thought I got them all but seems I missed one.  Should be fixed
> now.

Ok, good.

Would it be possible to get reasonable error message when ell is not
found?

"ell not found, you need to install it, please see README file"? It
took me a while to figure out...

Thanks,

									Pavel

-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 181 bytes --]