All of lore.kernel.org
 help / color / mirror / Atom feed
From: Otto Sabart <ottosabart@seberm.com>
To: Jonathan Corbet <corbet@lwn.net>
Cc: linux-doc@vger.kernel.org, Tejun Heo <tj@kernel.org>,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] doc: cgroup: use graphviz code instead of ASCII art
Date: Sun, 30 Dec 2018 19:57:30 +0100	[thread overview]
Message-ID: <20181230185730.GA14598@personal> (raw)
In-Reply-To: <20181230104020.1074d807@lwn.net>

[-- Attachment #1: Type: text/plain, Size: 1037 bytes --]


On 30. Dec (Sunday) v 10:40:29 -0700 2018, Jonathan Corbet wrote:
> On Sun, 30 Dec 2018 17:49:45 +0100
> Otto Sabart <ottosabart@seberm.com> wrote:
> 
> > The graphviz looks better. This patch also fixes multiple build warnings:
> > "WARNING: Block quote ends without a blank line; unexpected unindent."
> > 
> > Signed-off-by: Otto Sabart <ottosabart@seberm.com>
> 
> The graphviz looks better *in some settings*, such as the formatted
> version of the docs.  Please remember, though, that we need to preserve
> the readability of the plain-text documents as well, and my own feeling
> is that this patch is a step backward in that regard.  I'll defer to
> Tejun on this if he feels otherwise, but my sense is that this is not
> something we want to do.
> 
> OTOH fixing the warnings would be a good thing; I think it just needs a
> bit more use of literal blocks.  I would gladly accept a patch that did
> just that.

Ok, no problem. I will send another patch which fixes only these
warnings.

Thanks,

Ota

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

  reply	other threads:[~2018-12-30 18:57 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-12-30 16:49 [PATCH 1/2] doc: cgroup: use graphviz code instead of ASCII art Otto Sabart
2018-12-30 17:40 ` Jonathan Corbet
2018-12-30 18:57   ` Otto Sabart [this message]
2019-01-02 15:56   ` Tejun Heo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20181230185730.GA14598@personal \
    --to=ottosabart@seberm.com \
    --cc=corbet@lwn.net \
    --cc=linux-doc@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=tj@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.