All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ladislav Michl <ladis@linux-mips.org>
To: Sascha Hauer <s.hauer@pengutronix.de>
Cc: Andrey Smirnov <andrew.smirnov@gmail.com>,
	Barebox List <barebox@lists.infradead.org>
Subject: Re: [PATCH] of: Add .of suffix to device names from devicetree
Date: Mon, 31 Dec 2018 12:12:58 +0100	[thread overview]
Message-ID: <20181231111258.GA6011@lenoch> (raw)
In-Reply-To: <20181114085233.5000-1-s.hauer@pengutronix.de>

On Wed, Nov 14, 2018 at 09:52:33AM +0100, Sascha Hauer wrote:
> Previous implementation used to add a number to the device names
> for devices registered from the device tree which did not have a 'reg'
> property, thus a device node named "state" resulted in a device name
> "state.<x>". Current implementation skips that number and we get a
> device named "state". This conflicts with our barebox state
> implementation which tries to register a device named "state" itself.
> We could rename the state device nodes of all our device trees, but it
> causes less trouble to rename the devices.
> 
> This adds a ".of" suffix to the device names for devices registered from
> the device tree which also has the nice effect that they now can easily
> be recognized.

Well, that also breaks scripting based on device name (example):
-if [ ${fffa4000.gadget@fffa4000.vbus} != 1 ]
+if [ ${fffa4000.gadget@fffa4000.of.vbus} != 1 ]
 then
        echo "No USB Device cable plugged, normal boot"
        exit 0

I can live with that, but would welcome suggestions how to write above
code in some nicer way.

Thank you

> Fixes: 7e497d48acbd11 ("of: Port latest of_device_make_bus_id() implementation")

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

  parent reply	other threads:[~2018-12-31 11:13 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-11-14  8:52 [PATCH] of: Add .of suffix to device names from devicetree Sascha Hauer
2018-11-14 12:48 ` Jan Lübbe
2018-11-14 15:59 ` Andrey Smirnov
2018-11-15  9:33   ` Sascha Hauer
2018-12-31 11:12 ` Ladislav Michl [this message]
2019-01-04  8:12   ` Sascha Hauer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20181231111258.GA6011@lenoch \
    --to=ladis@linux-mips.org \
    --cc=andrew.smirnov@gmail.com \
    --cc=barebox@lists.infradead.org \
    --cc=s.hauer@pengutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.