All of lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 1/1] glib-networking: bump version to 2.56.1
Date: Mon, 31 Dec 2018 13:57:55 +0100	[thread overview]
Message-ID: <20181231135755.5bd0e1fb@windsurf> (raw)
In-Reply-To: <20181226232942.99929-1-aduskett@gmail.com>

Hello,

On Wed, 26 Dec 2018 18:29:42 -0500, aduskett at gmail.com wrote:
> From: Adam Duskett <Aduskett@gmail.com>
> 
> Other changes:
>   - glib-networking is now a meson package and has no support for auto-tools.
>   - Update configure options to reflect the above change to meson.
>   - gnutls is now a dependency of glib-networking.
>   - Add License file hash.

I've applied, but there was one thing that was not correct. See below.

> Fixes:
>  - http://autobuild.buildroot.org/results/848282be656809e26a704ff92842e6bde6875a3e

Minor detail: it was no longer fixing any build issue, so I've dropped
this.

> diff --git a/package/glib-networking/Config.in b/package/glib-networking/Config.in
> index ec2962392c..510eb42c13 100644
> --- a/package/glib-networking/Config.in
> +++ b/package/glib-networking/Config.in
> @@ -3,10 +3,11 @@ config BR2_PACKAGE_GLIB_NETWORKING
>  	depends on BR2_USE_WCHAR # glib2
>  	depends on BR2_TOOLCHAIN_HAS_THREADS # glib2
>  	depends on BR2_USE_MMU # glib2
> +	depends on !BR2_STATIC_LIBS # gnutls

You forgot to add the select on BR2_PACKAGE_GNUTLS. This means that you
didn't test a minimal build of glib-networking, because if you had done
that, Buildroot would have complained that gnutls gets built without
being selected in the configuration.

I've fixed this issue when applying.

Thanks,

Thomas
-- 
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com

      parent reply	other threads:[~2018-12-31 12:57 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-12-26 23:29 [Buildroot] [PATCH 1/1] glib-networking: bump version to 2.56.1 aduskett at gmail.com
2018-12-27  8:48 ` Thomas Petazzoni
2018-12-31 12:57 ` Thomas Petazzoni [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20181231135755.5bd0e1fb@windsurf \
    --to=thomas.petazzoni@bootlin.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.