All of lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 1/1] package/udisks: Fix compilation issue with missing sys/sysmacros.h
Date: Mon, 31 Dec 2018 14:39:37 +0100	[thread overview]
Message-ID: <20181231143937.5007b30a@windsurf> (raw)
In-Reply-To: <20181231091551.6335-1-vadim4j@gmail.com>

Hello,

On Mon, 31 Dec 2018 11:15:51 +0200, Vadim Kochan wrote:
> It fixes compilation error with undefined "minor", "major" and
> "makedev" objects which caused by missing include of <sys/sysmacros.h>
> 
> These definitions were moved to <sys/sysmacros.h> in newer gibc.

It is not really that they have been moved: they were already in
sysmacros.h. However, sysmacros.h used to be included by sys/types.h,
and this inclusion got removed, so sysmacros.h must now be included
explicitly.

I fixed this in the commit log and in the patch description, made other
minor tweaks in the commit log, and applied. Thanks!

Best regards,

Thomas
-- 
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com

  reply	other threads:[~2018-12-31 13:39 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-12-31  9:15 [Buildroot] [PATCH 1/1] package/udisks: Fix compilation issue with missing sys/sysmacros.h Vadim Kochan
2018-12-31 13:39 ` Thomas Petazzoni [this message]
2019-01-23 15:16 ` Peter Korsgaard

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20181231143937.5007b30a@windsurf \
    --to=thomas.petazzoni@bootlin.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.