All of lore.kernel.org
 help / color / mirror / Atom feed
From: Andrei Warkentin <awarkentin@vmware.com>
To: "H. Peter Anvin" <hpa@zytor.com>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH] /dev/mem: Fix wrong error on accessing beyond valid memory addresses.
Date: Mon, 14 Nov 2011 13:21:40 -0800 (PST)	[thread overview]
Message-ID: <2018804336.46235.1321305700330.JavaMail.root@zimbra-prod-mbox-2.vmware.com> (raw)
In-Reply-To: <1320881479-16711-1-git-send-email-andreiw@vmware.com>

Hi Peter,

----- Original Message -----
> From: "Andrei Warkentin" <andreiw@vmware.com>
> To: linux-kernel@vger.kernel.org
> Cc: "Andrei Warkentin" <andreiw@vmware.com>, "H. Peter Anvin" <hpa@zytor.com>
> Sent: Wednesday, November 9, 2011 6:31:19 PM
> Subject: [PATCH] /dev/mem: Fix wrong error on accessing beyond valid memory addresses.
> 
> Currently this returns -EFAULT, but it really should be returning 0,
> as in - 0 bytes read or written. This is what you would get by
> opening a block device, seeking to the end, and trying to read
> something. Additionally, make lseek() check the sought-to offset
> to pass the valid_phys_addr_range test.
> 
> Cc: H. Peter Anvin <hpa@zytor.com>
> Signed-off-by: Andrei Warkentin <andreiw@vmware.com>
> ---

I know you're very busy, but I was wondering if you could
give your two cents on this change. This change grew from
our discussion on LKML last week.

Thanks ahead,
A

  reply	other threads:[~2011-11-14 21:21 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-11-09 23:31 [PATCH] /dev/mem: Fix wrong error on accessing beyond valid memory addresses Andrei Warkentin
2011-11-14 21:21 ` Andrei Warkentin [this message]
2011-11-14 21:59   ` H. Peter Anvin
2011-11-14 22:11     ` Andrei Warkentin
2011-11-14 22:12       ` H. Peter Anvin
2011-11-14 22:33         ` Andrei Warkentin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2018804336.46235.1321305700330.JavaMail.root@zimbra-prod-mbox-2.vmware.com \
    --to=awarkentin@vmware.com \
    --cc=hpa@zytor.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.