All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jens Axboe <axboe@kernel.dk>
To: Pavel Begunkov <asml.silence@gmail.com>,
	Caleb Sander Mateos <csander@purestorage.com>
Cc: io-uring@vger.kernel.org
Subject: Re: [PATCH liburing 1/4] Add vectored registered buffer req init helpers
Date: Fri, 7 Mar 2025 11:06:04 -0700	[thread overview]
Message-ID: <2018ed5c-2be8-4237-b09d-4d9cdbae8c33@kernel.dk> (raw)
In-Reply-To: <ae241647-3d95-4989-a733-c9271b45dd50@gmail.com>

On 3/7/25 10:26 AM, Pavel Begunkov wrote:
> On 3/7/25 17:10, Caleb Sander Mateos wrote:
>> On Fri, Mar 7, 2025 at 8:22 AM Pavel Begunkov <asml.silence@gmail.com> wrote:
> ...
>>> +IOURINGINLINE void io_uring_prep_writev2_fixed(struct io_uring_sqe *sqe, int fd,
>>> +                                      const struct iovec *iovecs,
>>> +                                      unsigned nr_vecs, __u64 offset,
>>> +                                      int flags, int buf_index)
>>> +{
>>> +       io_uring_prep_writev2(sqe, fd, iovecs, nr_vecs, offset, flags);
>>> +       sqe->opcode = IORING_OP_WRITE_FIXED;
>>
>> IORING_OP_WRITEV_FIXED?
> 
> Good catch, that came from a prototype where it was based on
> that opcode, I should just use the helper in the test.

Both also need an ffi addition in the map.

-- 
Jens Axboe


  reply	other threads:[~2025-03-07 18:06 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-03-07 16:22 [PATCH liburing 0/4] vectored registered buffer support and tests Pavel Begunkov
2025-03-07 16:22 ` [PATCH liburing 1/4] Add vectored registered buffer req init helpers Pavel Begunkov
2025-03-07 17:10   ` Caleb Sander Mateos
2025-03-07 17:26     ` Pavel Begunkov
2025-03-07 18:06       ` Jens Axboe [this message]
2025-03-07 16:22 ` [PATCH liburing 2/4] test/sendzc: test registered vectored buffers Pavel Begunkov
2025-03-07 16:22 ` [PATCH liburing 3/4] tests/helpers: add t_create_socketpair_ip Pavel Begunkov
2025-03-07 16:22 ` [PATCH liburing 4/4] tests: targeted registered vector tests Pavel Begunkov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2018ed5c-2be8-4237-b09d-4d9cdbae8c33@kernel.dk \
    --to=axboe@kernel.dk \
    --cc=asml.silence@gmail.com \
    --cc=csander@purestorage.com \
    --cc=io-uring@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.