From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Michael S. Tsirkin" Subject: Re: [PATCH RFC 1/2] virtio-net: bql support Date: Wed, 2 Jan 2019 08:54:24 -0500 Message-ID: <20190102083202-mutt-send-email-mst@kernel.org> References: <20181205225323.12555-1-mst@redhat.com> <20181205225323.12555-2-mst@redhat.com> <21384cb5-99a6-7431-1039-b356521e1bc3@redhat.com> <20181226102100-mutt-send-email-mst@kernel.org> <620cfd46-aa3e-7eb6-0757-f4afbafda44b@redhat.com> <20181230134539-mutt-send-email-mst@kernel.org> <01e0fe8f-bd75-c39b-9d77-c5a9baf87348@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Content-Disposition: inline In-Reply-To: <01e0fe8f-bd75-c39b-9d77-c5a9baf87348@redhat.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: virtualization-bounces@lists.linux-foundation.org Errors-To: virtualization-bounces@lists.linux-foundation.org To: Jason Wang Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, virtualization@lists.linux-foundation.org, maxime.coquelin@redhat.com, wexu@redhat.com, "David S. Miller" List-Id: virtualization@lists.linuxfoundation.org T24gV2VkLCBKYW4gMDIsIDIwMTkgYXQgMTE6MzA6MTFBTSArMDgwMCwgSmFzb24gV2FuZyB3cm90 ZToKPiAKPiBPbiAyMDE4LzEyLzMxIOS4iuWNiDI6NDgsIE1pY2hhZWwgUy4gVHNpcmtpbiB3cm90 ZToKPiA+IE9uIFRodSwgRGVjIDI3LCAyMDE4IGF0IDA2OjA0OjUzUE0gKzA4MDAsIEphc29uIFdh bmcgd3JvdGU6Cj4gPiA+IE9uIDIwMTgvMTIvMjYg5LiL5Y2IMTE6MjIsIE1pY2hhZWwgUy4gVHNp cmtpbiB3cm90ZToKPiA+ID4gPiBPbiBUaHUsIERlYyAwNiwgMjAxOCBhdCAwNDoxNzozNlBNICsw ODAwLCBKYXNvbiBXYW5nIHdyb3RlOgo+ID4gPiA+ID4gT24gMjAxOC8xMi82IOS4iuWNiDY6NTQs IE1pY2hhZWwgUy4gVHNpcmtpbiB3cm90ZToKPiA+ID4gPiA+ID4gV2hlbiB1c2VfbmFwaSBpcyBz ZXQsIGxldCdzIGVuYWJsZSBCUUxzLiAgTm90ZTogc29tZSBvZiB0aGUgaXNzdWVzIGFyZQo+ID4g PiA+ID4gPiBzaW1pbGFyIHRvIHdpZmkuICBJdCdzIHdvcnRoIGNvbnNpZGVyaW5nIHdoZXRoZXIg c29tZXRoaW5nIHNpbWlsYXIgdG8KPiA+ID4gPiA+ID4gY29tbWl0IDM2MTQ4YzJiYmZiZSAoIm1h YzgwMjExOiBBZGp1c3QgVFNRIHBhY2luZyBzaGlmdCIpIG1pZ2h0IGJlCj4gPiA+ID4gPiA+IGJl bmVmaXRpYWwuCj4gPiA+ID4gPiBJJ3ZlIHBsYXllZCBhIHNpbWlsYXIgcGF0Y2ggc2V2ZXJhbCBk YXlzIGJlZm9yZS4gVGhlIHRyaWNreSBwYXJ0IGlzIHRoZSBtb2RlCj4gPiA+ID4gPiBzd2l0Y2hp bmcgYmV0d2VlbiBuYXBpIGFuZCBubyBuYXBpLiBXZSBzaG91bGQgbWFrZSBzdXJlIHdoZW4gdGhl IHBhY2tldCBpcwo+ID4gPiA+ID4gc2VudCBhbmQgdHJha2NlZCBieSBCUUwswqAgaXQgc2hvdWxk IGJlIGNvbnN1bWVkIGJ5IEJRTCBhcyB3ZWxsLgo+ID4gPiA+IEkganVzdCB3ZW50IG92ZXIgdGhl IHBhdGNoIGFnYWluIGFuZCBJIGRvbid0IHVuZGVyc3RhbmQgdGhpcyBjb21tZW50Lgo+ID4gPiA+ IFRoaXMgcGF0Y2ggb25seSBlbmFibGVkIEJRTCB3aXRoIHR4IG5hcGkuCj4gPiA+ID4gCj4gPiA+ ID4gVGh1cyB0aGVyZSdzIG5vIG1vZGUgc3dpdGNoaW5nLgo+ID4gPiA+IAo+ID4gPiA+IFdoYXQg ZGlkIEkgbWlzcz8KPiA+ID4gQ29uc2lkZXIgdGhlIGNhc2U6Cj4gPiA+IAo+ID4gPiAKPiA+ID4g VFggTkFQSSBpcyBkaXNhYmxlZDoKPiA+ID4gCj4gPiA+IHNlbmQgTiBwYWNrZXRzCj4gPiA+IAo+ ID4gPiB0dXJuIFRYIE5BUEkgb246Cj4gPiA+IAo+ID4gPiBnZXQgdHggaW50ZXJydXB0Cj4gPiA+ IAo+ID4gPiBCUUwgdHJ5IHRvIGNvbnN1bWUgdGhvc2UgcGFja2V0cyB3aGVuIGxlYWQgV0FSTiBm b3IgZHFsLgo+ID4gPiAKPiA+ID4gCj4gPiA+IFRoYW5rcwo+ID4gQ2FuIG9uZSByZWFsbHkgc3dp dGNoIHR4IG5hcGkgb24gYW5kIG9mZj8gSG93Pwo+ID4gV2hpbGUgcm9vdCBjYW4gY2hhbmdlIHRo ZSBuYXBpX3R4IG1vZHVsZSBwYXJhbWV0ZXIsIEkgZG9uJ3QgdGhpbmsKPiA+IHRoYXQgaGFzIGFu eSBlZmZlY3Qgb3V0c2lkZSBkZXZpY2UgcHJvYmUgdGltZS4gV2hhdCBkaWQgSSBtaXNzPwo+ID4g Cj4gPiAKPiA+IAo+IAo+IFdlIHN1cHBvcnQgc3dpdGNoIHRoZSBtb2RlIHRocm91Z2ggZXRodG9v bCByZWNlbnRseS4gU2VlCj4gCj4gY29tbWl0IDBjNDY1YmUxODNjN2M1N2EyNjQ0NmRmNmVhOTZk ODY3NmI4NjVmOTIKPiBBdXRob3I6IEphc29uIFdhbmcgPGphc293YW5nQHJlZGhhdC5jb20+Cj4g RGF0ZTrCoMKgIFR1ZSBPY3QgOSAxMDowNjoyNiAyMDE4ICswODAwCj4gCj4gwqDCoMKgIHZpcnRp b19uZXQ6IGV0aHRvb2wgdHggbmFwaSBjb25maWd1cmF0aW9uCj4gCj4gwqDCoMKgIEltcGxlbWVu dCBldGh0b29sIC5zZXRfY29hbGVzY2UgKC1DKSBhbmQgLmdldF9jb2FsZXNjZSAoLWMpIGhhbmRs ZXJzLgo+IMKgwqDCoCBJbnRlcnJ1cHQgbW9kZXJhdGlvbiBpcyBjdXJyZW50bHkgbm90IHN1cHBv cnRlZCwgc28gdGhlc2UgYWNjZXB0IGFuZAo+IMKgwqDCoCBkaXNwbGF5IHRoZSBkZWZhdWx0IHNl dHRpbmdzIG9mIDAgdXNlYyBhbmQgMSBmcmFtZS4KPiAKPiDCoMKgwqAgVG9nZ2xlIHR4IG5hcGkg dGhyb3VnaCBzZXR0aW5nIHR4LWZyYW1lcy4gU28gYXMgdG8gbm90IGludGVyZmVyZQo+IMKgwqDC oCB3aXRoIHBvc3NpYmxlIGZ1dHVyZSBpbnRlcnJ1cHQgbW9kZXJhdGlvbiwgdmFsdWUgMSBtZWFu cyB0eCBuYXBpIHdoaWxlCj4gwqDCoMKgIHZhbHVlIDAgbWVhbnMgbm90Lgo+IAo+IMKgwqDCoCBP bmx5IGFsbG93IHRoZSBzd2l0Y2hpbmcgd2hlbiBkZXZpY2UgaXMgZG93biBmb3Igc2ltcGxpY2l0 eS4KPiAKPiDCoMKgwqAgTGluazogaHR0cHM6Ly9wYXRjaHdvcmsub3psYWJzLm9yZy9wYXRjaC85 NDgxNDkvCj4gwqDCoMKgIFN1Z2dlc3RlZC1ieTogSmFzb24gV2FuZyA8amFzb3dhbmdAcmVkaGF0 LmNvbT4KPiDCoMKgwqAgU2lnbmVkLW9mZi1ieTogV2lsbGVtIGRlIEJydWlqbiA8d2lsbGVtYkBn b29nbGUuY29tPgo+IMKgwqDCoCBTaWduZWQtb2ZmLWJ5OiBKYXNvbiBXYW5nIDxqYXNvd2FuZ0By ZWRoYXQuY29tPgo+IMKgwqDCoCBTaWduZWQtb2ZmLWJ5OiBEYXZpZCBTLiBNaWxsZXIgPGRhdmVt QGRhdmVtbG9mdC5uZXQ+Cj4gCj4gVGhhbmtzCgoKSXQncyBkaXNhYmxlZCB3aGVuIGRldmljZSBp cyB1cCAtIGlzbid0IHRoYXQgZW5vdWdoPwoKLS0gCk1TVApfX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fXwpWaXJ0dWFsaXphdGlvbiBtYWlsaW5nIGxpc3QKVmly dHVhbGl6YXRpb25AbGlzdHMubGludXgtZm91bmRhdGlvbi5vcmcKaHR0cHM6Ly9saXN0cy5saW51 eGZvdW5kYXRpb24ub3JnL21haWxtYW4vbGlzdGluZm8vdmlydHVhbGl6YXRpb24= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 39C8BC43387 for ; Wed, 2 Jan 2019 13:54:41 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 0C2A9218DE for ; Wed, 2 Jan 2019 13:54:41 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729965AbfABNyk (ORCPT ); Wed, 2 Jan 2019 08:54:40 -0500 Received: from mx1.redhat.com ([209.132.183.28]:58682 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727294AbfABNyj (ORCPT ); Wed, 2 Jan 2019 08:54:39 -0500 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id DF970C058CB2; Wed, 2 Jan 2019 13:54:38 +0000 (UTC) Received: from redhat.com (ovpn-120-148.rdu2.redhat.com [10.10.120.148]) by smtp.corp.redhat.com (Postfix) with ESMTP id 427125D9C5; Wed, 2 Jan 2019 13:54:26 +0000 (UTC) Date: Wed, 2 Jan 2019 08:54:24 -0500 From: "Michael S. Tsirkin" To: Jason Wang Cc: linux-kernel@vger.kernel.org, maxime.coquelin@redhat.com, tiwei.bie@intel.com, wexu@redhat.com, jfreimann@redhat.com, "David S. Miller" , virtualization@lists.linux-foundation.org, netdev@vger.kernel.org Subject: Re: [PATCH RFC 1/2] virtio-net: bql support Message-ID: <20190102083202-mutt-send-email-mst@kernel.org> References: <20181205225323.12555-1-mst@redhat.com> <20181205225323.12555-2-mst@redhat.com> <21384cb5-99a6-7431-1039-b356521e1bc3@redhat.com> <20181226102100-mutt-send-email-mst@kernel.org> <620cfd46-aa3e-7eb6-0757-f4afbafda44b@redhat.com> <20181230134539-mutt-send-email-mst@kernel.org> <01e0fe8f-bd75-c39b-9d77-c5a9baf87348@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <01e0fe8f-bd75-c39b-9d77-c5a9baf87348@redhat.com> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.32]); Wed, 02 Jan 2019 13:54:39 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Jan 02, 2019 at 11:30:11AM +0800, Jason Wang wrote: > > On 2018/12/31 上午2:48, Michael S. Tsirkin wrote: > > On Thu, Dec 27, 2018 at 06:04:53PM +0800, Jason Wang wrote: > > > On 2018/12/26 下午11:22, Michael S. Tsirkin wrote: > > > > On Thu, Dec 06, 2018 at 04:17:36PM +0800, Jason Wang wrote: > > > > > On 2018/12/6 上午6:54, Michael S. Tsirkin wrote: > > > > > > When use_napi is set, let's enable BQLs. Note: some of the issues are > > > > > > similar to wifi. It's worth considering whether something similar to > > > > > > commit 36148c2bbfbe ("mac80211: Adjust TSQ pacing shift") might be > > > > > > benefitial. > > > > > I've played a similar patch several days before. The tricky part is the mode > > > > > switching between napi and no napi. We should make sure when the packet is > > > > > sent and trakced by BQL,  it should be consumed by BQL as well. > > > > I just went over the patch again and I don't understand this comment. > > > > This patch only enabled BQL with tx napi. > > > > > > > > Thus there's no mode switching. > > > > > > > > What did I miss? > > > Consider the case: > > > > > > > > > TX NAPI is disabled: > > > > > > send N packets > > > > > > turn TX NAPI on: > > > > > > get tx interrupt > > > > > > BQL try to consume those packets when lead WARN for dql. > > > > > > > > > Thanks > > Can one really switch tx napi on and off? How? > > While root can change the napi_tx module parameter, I don't think > > that has any effect outside device probe time. What did I miss? > > > > > > > > We support switch the mode through ethtool recently. See > > commit 0c465be183c7c57a26446df6ea96d8676b865f92 > Author: Jason Wang > Date:   Tue Oct 9 10:06:26 2018 +0800 > >     virtio_net: ethtool tx napi configuration > >     Implement ethtool .set_coalesce (-C) and .get_coalesce (-c) handlers. >     Interrupt moderation is currently not supported, so these accept and >     display the default settings of 0 usec and 1 frame. > >     Toggle tx napi through setting tx-frames. So as to not interfere >     with possible future interrupt moderation, value 1 means tx napi while >     value 0 means not. > >     Only allow the switching when device is down for simplicity. > >     Link: https://patchwork.ozlabs.org/patch/948149/ >     Suggested-by: Jason Wang >     Signed-off-by: Willem de Bruijn >     Signed-off-by: Jason Wang >     Signed-off-by: David S. Miller > > Thanks It's disabled when device is up - isn't that enough? -- MST